From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87579C25B6B for ; Thu, 26 Oct 2023 18:45:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231148AbjJZSpz (ORCPT ); Thu, 26 Oct 2023 14:45:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229991AbjJZSpx (ORCPT ); Thu, 26 Oct 2023 14:45:53 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 591681AD for ; Thu, 26 Oct 2023 11:45:50 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-507962561adso1894979e87.0 for ; Thu, 26 Oct 2023 11:45:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698345948; x=1698950748; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=Dfq44KtpvVoTi226YXMj5pM9/ZBtfwTToNeSkmatPXk=; b=kPPKS60s7Gx2wy9Oj0La519Iquo3rC/zpwmJcUtDPOl5BZFEGhBWliSCdrgodyjYRh 5jK0IVIlUKlCy7T/KiRJq3wpNhhOOvtHzl3vEOXogyORYqmZ8A/zsCcjfSu11cMMVCb1 QB4WwNCYdsZbcoxvaXmJUH1Y2CCi//WwH5xmCteeViBlUSyIfL8IKQX9bMEFgQyywuPZ JxrL6ONOYBPUkEqIeNveR8YYp/A9El5QSEpUfapEiflCcjd8otSdt5hIbNMlKWQYnkBv 7pa/Du4IF8WGy4JoSVbFvT2nVkoxolTHhzH/vpi5N76YxQ/QF0BPiE8x/EVOq2d7r6NJ UFVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698345948; x=1698950748; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Dfq44KtpvVoTi226YXMj5pM9/ZBtfwTToNeSkmatPXk=; b=e42Z8t5a5BW+uE6y+lyvURKUbQAgAcrxZ6mxp2MDXDysN9/wKP6axgVnaOgHIMcqvc /qPuScwEEGOmhUFJAAZK283ouxKrs0FnAZmxnfIRlg1J3dClqnlKLKo4ce/ATrczn1fh FYF/IEltXa8pqMa+8R1Vk04F9JQkSRoVux+c77I+CyELKj0ss38te1VxyGEzSc9X6Wdk XxvQoj/ekUi9hgKJZx25MAJGZVFjFdn5hq89fi0w5hE/4E8tqq+Hoc9tF6lI64srVqQE A08A5QaAcH0WFem5hbrxFoUg4sJA144W1glVKaP+AxfTbFiNYrD0nrXVrTvK6oYDyyJ1 Rikg== X-Gm-Message-State: AOJu0YzE8fRWWZGzWGLSyHlWl9MeHvBpyuoDqIBEGPYvNHfaHPbrNQHp PtlDRJyZMtzRpWdxAyF7YuzYHQ== X-Google-Smtp-Source: AGHT+IFujQppv52TAisp40xugmwbZaGNvITv9y42W1AvnCP4R391ggguFC+CGFL20f2whKEh/xoHkQ== X-Received: by 2002:a19:c510:0:b0:503:34b8:20b with SMTP id w16-20020a19c510000000b0050334b8020bmr143296lfe.65.1698345948438; Thu, 26 Oct 2023 11:45:48 -0700 (PDT) Received: from [172.30.204.255] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id n21-20020a05651203f500b005079f69e019sm3092962lfq.59.2023.10.26.11.45.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Oct 2023 11:45:48 -0700 (PDT) Message-ID: <1b99abed-6572-4550-98cc-56667a507883@linaro.org> Date: Thu, 26 Oct 2023 20:45:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] clk: qcom: ipq6018: add USB GDSCs From: Konrad Dybcio To: Robert Marko , agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: <20231025104457.628109-1-robimarko@gmail.com> <20231025104457.628109-2-robimarko@gmail.com> <77314fe2-2936-4f89-a347-4eb288507c47@linaro.org> Content-Language: en-US In-Reply-To: <77314fe2-2936-4f89-a347-4eb288507c47@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26/23 20:42, Konrad Dybcio wrote: > > > On 10/25/23 12:44, Robert Marko wrote: >> IPQ6018 has GDSC-s for each of the USB ports, so lets define them as such >> and drop the curent code that is de-asserting the USB GDSC-s as part of >> the GCC probe. >> >> Signed-off-by: Robert Marko >> --- > Applying patches 1 and 3 without this one breaks usb, no? Sorry, my hands don't keep up with my brain - that's almost another speculative execution vulnerability! What I meant to say is: applying patches 1 and 2 breaks USB but the solution here would be to apply patch 1 and patch 3, followed by patch 2 (unless it will make the USB defer, IDK, it's probably easier to just test than to dive deep into the code) with Bjorn taking both subsystems, we can make that work I think Konrad