From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 338D1314B6C for ; Thu, 4 Dec 2025 09:25:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764840314; cv=none; b=OfXf+HCjyY2UEEwjO9cBHKRWdIjqHNzP4L04WDBXnEOaMz05u//xAJjZIdE9sDYbmokATW8gV1PCb/WMABhbn8ZPJJmmNQAGV4aTHWFn+yda8TT1nP6J+ZdUeinE43hvK6eOgKt4NxmP17GqQ7vcyEezqCb+QkteswQCmhhelGk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764840314; c=relaxed/simple; bh=j5esf63xn1fFUsqmJ7HKrO7rH17nmE7cmM+3N7VS5AQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=b5Yhc+e4vTXPHsU/2WiqTsiUqd4/iUM6klj7YmAfxC0K53cs/WPJTOzUgaIKuFBU8423St5q8PHFj592IH8/hTRIWqphjvl+Ogl6qOEc+PtX6fK0bA4V+Sj3nUEzpqfLpVVsocm+JiEoyZW9Apv7gRUOiD+wy8zEnvJsobxU4gM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XBcFk/0f; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=eOVSIOye; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XBcFk/0f"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="eOVSIOye" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764840310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VcV0ei5qdE7A9DKITUM8bd6drauNXBLY6Q2f/9Ll4N8=; b=XBcFk/0fLBqS/2XAS73dycT2uvqdmzUmaP586gdataRNlgRV0SHDEJaIUD/BBg+32qHaFj +x5abrOCb1W61kOgK0Y9KsI2CCjOg0d3dHSzmBL6RVfgKSzno74yw6SdgL1RwyufcMC5fT PUHy3JMmtIaFaS6ezyFY1mGCA1XQmHU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-595-Ppw1xFlVPZKkVTZWUuiqfg-1; Thu, 04 Dec 2025 04:25:08 -0500 X-MC-Unique: Ppw1xFlVPZKkVTZWUuiqfg-1 X-Mimecast-MFC-AGG-ID: Ppw1xFlVPZKkVTZWUuiqfg_1764840307 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-42e2d02b528so446139f8f.0 for ; Thu, 04 Dec 2025 01:25:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764840307; x=1765445107; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VcV0ei5qdE7A9DKITUM8bd6drauNXBLY6Q2f/9Ll4N8=; b=eOVSIOye4Q0+8MBZo9YTsTm1cwj5uFABQhIBN83Qq1En1nl2UBq28ahG/Cph61MKXz J7aDpcsLbp5PLUYT+cBvTZxf4N4sbgtqozZVMcaemBAAaBGdmVvKXwQ6OmTDAQEbWV/k MMK136QGEfi85d222KCKHwJZMmVA7Cd1q461/cm8iHGuZn+YmXBZwndB6zHEypDawxTb mQ71Xo6kCbBmKTyqFUMUxWf/BMXfwp0Sj1Rcn6qYs8wWRvElzluJPpuwOnhCD6yzna9t EWEDh7FAs81E6tug6k0zFgkZie/rPGzaKsSZBIgimoeiUUwxBPtbEmuiO6T6vehLN+Ce YPAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764840307; x=1765445107; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VcV0ei5qdE7A9DKITUM8bd6drauNXBLY6Q2f/9Ll4N8=; b=e5l2u++8df2uFDa+d09+Sgd94u1APg6z3bhsxjerhS7tfCSQ3D+D5B+jAAH4U1DzI8 lAp1RAQZF+ESVaYEciFKAPfAuIcLGdUxBWuvdRnLnTww8r1qzJdh8tRAH4rTEHYQKYJl y86Ei6YEGKl+q+OVyB9wVqcG3XJis4Gw1hDED9x/EITdV1oNtSIVqqolT4ZpWNPaR9Yz F7AxQk7XlFQXfNUBib+oUjJype9W6rshrlUkdwZfTtTXlfWjwPuceYfIkpnTlE680dfp 1gvmM+e9VcOm3GDDGU2rlSQdmkhVMnUJwrZ5wcmTaDFz6HGthe0ICmvlFAUVSO23QKdS YfGQ== X-Forwarded-Encrypted: i=1; AJvYcCWzkiitptmxf8Hl6CUmDxUUxWkZPPE9zLrbsc7vbLpI0gI1qDOncSXiIVOH26BVudGSS8I1DqMdQJd5c4M=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0LM4kOQGXoeY94A2vNAeqFEfBBYb4SmHcZvSmPpHJRu4DPJeh Hl7wTviqUp3aEX7pQNiq1JyPZuJFVm31MatSnLWaXta4pLy9HACr1AQKHgBBxr1pp5FopHXg+Er FcT0CADjRnwcQ4QghY4CKHq6rKpZJWm2mN5DpVsWZsazDIuKIFr2eouhMBB9eUyKxDg== X-Gm-Gg: ASbGncsYR61RrqrQr3QsTpc6p43cQF8G9YMP2SNRjsvkutYLXpXdQ+rnIf6mYvGA/PI o/u2hpOTcD1XmbiRiyYxnqMhFB99cm4KQmslxmrw0Kht0qHuuvBXdpLLiP3jzE3BMFpV8y31LH+ taTEJhpJf17HTx0gSKF6nBCPZNeliMXzG3WMsmEGncgkSDpZlv1uaSrTEenir4NqOD6+EKfBvU4 IhTI8lk4OMPY7+9NvJjyR3RRugoumPEt//WqoO7XT2k9Mnfwg2/Yz8Zay87WP7QcG8oU1nh0XJD K+0vgXJUa+4iO4R+OP3xO2IDMMNQ3Tt+zzB6Sez4t39QKSnSf7tdPeZR9n4dUpz4oYjAqa4d2X0 IIa1FaJkPg0Zs X-Received: by 2002:a05:6000:40e0:b0:42b:3d9d:c605 with SMTP id ffacd0b85a97d-42f731c8442mr5415664f8f.49.1764840306825; Thu, 04 Dec 2025 01:25:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IGHjvJVp3Q6NIJehYvKFw1+VG08krfj0o2zOuN0+0X29DCI8T/sHlFf0MSXLhEUByimYbuJ3A== X-Received: by 2002:a05:6000:40e0:b0:42b:3d9d:c605 with SMTP id ffacd0b85a97d-42f731c8442mr5415628f8f.49.1764840306405; Thu, 04 Dec 2025 01:25:06 -0800 (PST) Received: from [192.168.88.32] ([212.105.153.24]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7cbe8fe8sm2153754f8f.2.2025.12.04.01.25.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Dec 2025 01:25:05 -0800 (PST) Message-ID: <1b9ade5b-bfa9-4bcd-9bc4-6457dffcd887@redhat.com> Date: Thu, 4 Dec 2025 10:25:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [net PATCH] net: macb: Relocate mog_init_rings() callback from macb_mac_link_up() to macb_open() To: Xiaolei Wang , nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, Kexin.Hao@windriver.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251128103647.351259-1-xiaolei.wang@windriver.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251128103647.351259-1-xiaolei.wang@windriver.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/28/25 11:36 AM, Xiaolei Wang wrote: > In the non-RT kernel, local_bh_disable() merely disables preemption, > whereas it maps to an actual spin lock in the RT kernel. Consequently, > when attempting to refill RX buffers via netdev_alloc_skb() in > macb_mac_link_up(), a deadlock scenario arises as follows: > The dependency chain caused by macb_mac_link_up(): > &bp->lock --> (softirq_ctrl.lock) --> _xmit_ETHER#2 I'm sorry, but I can't see how this dependency chain is caused by mog_init_rings(), please extend the above info pin pointing the function/code effectively acquiring the lock and how it's reached. > The dependency chain caused by macb_start_xmit(): > _xmit_ETHER#2 --> &bp->lock > > Notably, invoking the mog_init_rings() callback upon link establishment > is unnecessary. Instead, we can exclusively call mog_init_rings() within > the ndo_open() callback. This adjustment resolves the deadlock issue. > Given that mog_init_rings() is only applicable to > non-MACB_CAPS_MACB_IS_EMAC cases, we can simply move it to macb_open() > and simultaneously eliminate the MACB_CAPS_MACB_IS_EMAC check. > > Suggested-by: Kevin Hao > Signed-off-by: Xiaolei Wang Please include a suitable fixes tag. Thanks, Paolo