From: Joe Perches <joe@perches.com>
To: Aditya Srivastava <yashsri421@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org, lukas.bulwahn@gmail.com
Subject: Re: [PATCH v3] checkpatch: add fix option for MAINTAINERS_STYLE
Date: Mon, 16 Nov 2020 20:26:54 -0800 [thread overview]
Message-ID: <1b9c5353c6318cc7a4e013886012739e6627d82d.camel@perches.com> (raw)
In-Reply-To: <20201117040501.21914-1-yashsri421@gmail.com>
On Tue, 2020-11-17 at 09:35 +0530, Aditya Srivastava wrote:
> Checkpatch expects entries in MAINTAINERS file in a specific order and
> warns if the changes made do not follow the specified order.
>
> E.g., running checkpatch on commit b33bc2b878e0 ("nexthop: Add entry to
> MAINTAINERS") reports this warning:
>
> WARNING: Misordered MAINTAINERS entry - list file patterns in
> alphabetic order
> +F: include/uapi/linux/nexthop.h
> +F: include/net/netns/nexthop.h
>
> Provide a simple fix by swapping the unordered lines, if both the lines
> are additions (start with '+')
On second thought, nak.
This fails when there are 3 consecutive misordered lines.
SECTION
F: c
F: b
F: a
next prev parent reply other threads:[~2020-11-17 4:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 4:05 Aditya Srivastava
2020-11-17 4:20 ` Joe Perches
2020-11-17 4:26 ` Joe Perches [this message]
2020-11-17 4:29 ` Joe Perches
2020-11-17 10:21 ` Lukas Bulwahn
2020-11-17 10:54 ` Aditya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b9c5353c6318cc7a4e013886012739e6627d82d.camel@perches.com \
--to=joe@perches.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=yashsri421@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®