From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757085AbXKZRMM (ORCPT ); Mon, 26 Nov 2007 12:12:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753756AbXKZRL5 (ORCPT ); Mon, 26 Nov 2007 12:11:57 -0500 Received: from wa-out-1112.google.com ([209.85.146.180]:29102 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753361AbXKZRLz convert rfc822-to-8bit (ORCPT ); Mon, 26 Nov 2007 12:11:55 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=YRO6HqySb7uEuKPlwHkrzbvchqUskLhE94UQBkSCgI8Pme8V5PQvShWxIwPCq1sNJeuKZJTj/oA9AsQfHc9wxbJhM9vPvwCsqbh02yGa8rT/ujggkoKlBwOYUIn8h3inbVXlJj9e6MYWkyPLxH7a+upi0VfZzJDyL0/Iwzl1hAk= Message-ID: <1ba2fa240711260911i705350f3hefeddc7a09f76d1a@mail.gmail.com> Date: Mon, 26 Nov 2007 19:11:51 +0200 From: "Tomas Winkler" To: "=?ISO-8859-1?Q?Miguel_Bot=F3n?=" Subject: Re: [PATCH 2/2] iwlwifi: add power management support -v2 Cc: "Linux Kernel Mailing List" , linux-wireless@vger.kernel.org, linville@tuxdriver.com, yi.zhu@intel.com In-Reply-To: <200711261718.14711.mboton@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Content-Disposition: inline References: <200711170006.49654.mboton.lkml@gmail.com> <1ba2fa240711162215p30b8bc7fj9f36020378ff596a@mail.gmail.com> <200711261718.14711.mboton@gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Nov 26, 2007 6:18 PM, Miguel Botón wrote: > > On Saturday 17 November 2007 07:15:05 Tomas Winkler wrote: > > Why power management shouldn't be enabled while in AC? The semantic of this > > ioctls is quite unclear. > I > IWL_POWER_AC and IWL_POWER_BATTERY are just two power modes. IWL_POWER_AC > would be the default power mode when we're in AC (no power saving) and > IWL_POWER_BATTERY would be the default power mode when we're in battery > (power saving mode). That's why we set IWL_POWER_ENABLED flag with > IWL_POWER_BATTERY, because it is the only power mode that saves power. > > We can change to IWL_POWER_BATTERY or IWL_POWER_AC in any moment. > > This patch, depending if power management is enabled or not, sets which power > mode we should use, Then, it checks if we're already using this mode or not. > I'm not sure who introduced this names (lazy to look to history) but that's very misleading. Nothing says that while in AC we cannot do power saving and vice versa. This naming is scattered all over the code, there should be only one place where AC and BATTERY are translated into appropriate (maybe configurable) power levels. We have 5 power levels defined for iwlwifi. Tomas > -- > Miguel Botón >