Re: pull request: wireless-2.6 2008-08-26

["Tomas Winkler" <tomasw@gmail.com>]

On Wed, Aug 27, 2008 at 2:10 PM, Marcel Holtmann
<holtmann@linux.intel.com> wrote:
> Hi Dave,
>
>> > Afther massive ath9k merge I didn't see it was a conceptual problem.
>>
>> Stop right there.
>>
>> You don't see it as a problem because you're not the one who has to
>> explain all of this shit to Linus and ends up getting flamed by him
>> when inappropriate changes are in my tree outside of the merge window.
>
> I did a quick review of the offending patch queue. And some of them
> should go in since they are fixing real bugs (as far as I can tell from
> a quick review). Others have to clearly wait for the next merge window.
>
> Thomas, please go through the list of patches and pick the real bug
> fixes. The cleanup patches can't go in since they are after the merge
> window.

I just repeat myself again, for the current series except the scanning
cleaning patches these patches
are must. This particular patch is there just because the hidden AP
connectivity fixes were stacked above it.

 And being one of the offenders why Dave got flamed by Linus,
> there is no way to get these through. And my big offender was a
> regression that broke userspace and came with a lengthy commit message.

There is a central problem here, since I cannot really adjust driver
development progress from obvious reason with Linux merging window.
Upstream kernel is unfortunately not the only customer I report to. So
actually stable versions got half backed drivers depending on some
arbitrary time cut from my (selfish) development point of view.
In this particular point we are really only cleaning bug database, our
mistake here is that we didn't export these bug to external bugzilla.

> Speaking of which, you better have a more convincing commit message if
> you wanna get something in after the merge window. It should make clear
> why this is a bug or a regression and why it can't wait until the next
> merge window.

Yes, I've already got this message on 3 channels already :)

> Please take this into account for any future patches since Linus now set
> a really high bar for patches after the merge window.

Understood.
Tomas