From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: cong yang <yangcong5@huaqin.corp-partner.google.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, dmitry.torokhov@gmail.com, jikos@kernel.org,
benjamin.tissoires@redhat.com, dianders@chromium.org,
hsinyi@google.com, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: input: touchscreen: Add ilitek 9882T touchscreen chip
Date: Tue, 6 Jun 2023 08:21:10 +0200 [thread overview]
Message-ID: <1ba84b37-ae64-ef0b-b7cd-8941916962ca@linaro.org> (raw)
In-Reply-To: <CAHwB_NLOrecxxP0kGS2ycXAw93XOSOiR+qPo50D292tDNKiqQQ@mail.gmail.com>
On 06/06/2023 04:18, cong yang wrote:
> Hi,Krzysztof
>
> On Mon, Jun 5, 2023 at 6:34 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 05/06/2023 08:05, Cong Yang wrote:
>>> Add an ilitek touch screen chip ili9882t.
>>>
>>> Signed-off-by: Cong Yang <yangcong5@huaqin.corp-partner.google.com>
>>> ---
>>> .../bindings/input/elan,ekth6915.yaml | 23 ++++++++++++++++---
>>> 1 file changed, 20 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml
>>> index 05e6f2df604c..f0e7ffdce605 100644
>>> --- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml
>>> +++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml
>>> @@ -15,11 +15,14 @@ description:
>>>
>>> properties:
>>> compatible:
>>> - items:
>>> - - const: elan,ekth6915
>>> + enum:
>>> + - elan,ekth6915
>>> + - ilitek,ili9882t
>>>
>>> reg:
>>> - const: 0x10
>>> + enum:
>>> + - 0x10
>>> + - 0x41
>>>
>>> interrupts:
>>> maxItems: 1
>>> @@ -29,11 +32,13 @@ properties:
>>>
>>> vcc33-supply:
>>> description: The 3.3V supply to the touchscreen.
>>> + If using ili9882t then this supply will not be needed.
>>
>> What does it mean "will not be needed"? Describe the hardware, not your
>> drivers.
>>
>> I don't think you tested your DTS. Submit DTS users, because I do not
>> believe you are testing your patches. You already got such comment and I
>> don't see much of improvements here.
>
> I ran make dt_binding_check in the codebase root directory before
> sending the V2 Patch, and there were no errors or warnings (the V1
> version run reported some errors). Is there some other way to test DTS
> ?
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-06 6:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 6:05 [PATCH v2 0/2] Add ili9882t timing Cong Yang
2023-06-05 6:05 ` [PATCH v2 1/2] dt-bindings: input: touchscreen: Add ilitek 9882T touchscreen chip Cong Yang
2023-06-05 10:20 ` Conor Dooley
2023-06-06 2:06 ` cong yang
2023-06-06 18:47 ` Dmitry Torokhov
2023-06-09 22:03 ` Rob Herring
2023-06-05 10:34 ` Krzysztof Kozlowski
2023-06-06 2:18 ` cong yang
2023-06-06 6:21 ` Krzysztof Kozlowski [this message]
2023-06-06 18:51 ` Dmitry Torokhov
2023-06-07 8:55 ` cong yang
2023-06-05 6:05 ` [PATCH v2 2/2] HID: i2c-hid: elan: Add ili9882t timing Cong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ba84b37-ae64-ef0b-b7cd-8941916962ca@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=benjamin.tissoires@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hsinyi@google.com \
--cc=jikos@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=yangcong5@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®