From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E2553A1E8A for ; Mon, 29 Dec 2025 06:43:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766990616; cv=none; b=TvOZ2gV6RXjYXAKaD0pnZWVGYHCplnRv+qNN54mZyoTuYRb2MZ1J5FqUfEOepmAkzhg+FVS65ruxmNuOb4OUOcKiWBoWA2TQtG8KoU5MLAwzI78tRtvCRfLysOWwi0ukKL+TF8pcNtdnMT2OwpsAPc/PUSZZUbxnqG5i6rVRzao= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766990616; c=relaxed/simple; bh=emeZJcdH5hNvRLpqWgQp3UuLS1GNerHk4L/icBjX9Cs=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=OuGyhpRDvSNmkTSPp9vfwN0N1uosMnwjrB2/VE7LjApNTtfsgzPVTqAlHgIOIfBfuOcNHhntzpjWEHc1adSLlH5uurbWgHlT/TPWrgTq/qWS7KxzPXArDBbV/7qJHLfzEj78HXpyIacBumD5kMHfQTO161Qo8fE+7LJw4OkpfoM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mDOXUb7A; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mDOXUb7A" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-64b921d9e67so12366345a12.3 for ; Sun, 28 Dec 2025 22:43:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766990612; x=1767595412; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=emeZJcdH5hNvRLpqWgQp3UuLS1GNerHk4L/icBjX9Cs=; b=mDOXUb7AV9bODVzL+TucWUElmUOP49mXlC72LsjsgTyw2UW2dKls83BSyTk8OaG+/c Wid+BdwZMs2zbbnP3CgyoNIZAd0+HcRSepL216HAchaKI63T39uZ74YhG3rcn1ZmjPmK FqdpF+Ai9Uab1YStO9RYAD6Y5QZKaPdUXJFRVAsqk3IpoiqBOxjmyenCclgOQLRUVl40 +L7Gt6lIzWBamlvELIKH1dqQ65L4vMXQhAfsvIDP8rphRRSKZXxgMNu8b3D/CRbmt+IP yOpq/up+AN4bkTLzpFBxchk/ISZn59/vafwz294UMVyJt56xMS8YXAtRYjBVuUCsFbhK wjWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766990612; x=1767595412; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=emeZJcdH5hNvRLpqWgQp3UuLS1GNerHk4L/icBjX9Cs=; b=MuGekbxKdZpqOJe6jqv2rwDEpX4wGQq2ZwUjygmtZU17rzC7BDwxy7noiAmvHvApIB lhJHCwHogEs0a2VmODNlkmxX6p7kAenYXMZCvgdQBTrYSdvMTd1+0j12XPq8mkZcO2Di iWdsUOyYYQaikRBxJe7ZimrsnqgqR6mNiHFw9o1rI9MqhnGecj+rhaKJXJhtn+cnGdZX QIGBVYiBoLcIpDqYlp1hGvuTpK89cnclhCrztv5Il+4S9KSzHg9nM7l0gz0J0C+3l9lv +lkiU1Z6b/c8JbBBqP14fFqEe0YeX/njSanq3JxlG5j7ZMe5iugzmnbQPTCilq41Pef2 nhyw== X-Forwarded-Encrypted: i=1; AJvYcCUAFx+bMyWaN2WEVnDAC3KccNPh1huGMh/KMSgM55pKudnIkG6YL8VdRBhdApHDVmHmnBR0K7zu47MgX7o=@vger.kernel.org X-Gm-Message-State: AOJu0YzoZAonvoar5exUSkB1gHvBA6zT1Lx/Wo4z4d7QWJ9whiwYjvy7 +qo8rvVCjQO6jMN5wUndwW1dL5ai2jvd+ZNb/Tb8czIxoop7+NkpvkukP7Mu5cwXQ8o= X-Gm-Gg: AY/fxX67RzwYd4et48Zkhn9m0AOb8Lw90A4FeDnEguFUf8OPAl6x3lBBnXl7jHpviWW WBRGqzR+T0XA852gSRxKuwKhx6L6wiLVDiPPGpKfd39i4WHp4s//2TL/rMKWEcv9AicL1t+b9dC qPPpJE7rpVGFaQTMlFCPTOqCvstqzj6UDMLpqOvHHPiZyhctfr86RGZVh9T0FBLT3+Gr39VS6wy tYP3H/4a1tHLOM/TZX4lrUMHPYz/AmhXqt2pc99Cl0/HgmUmRpm9UZOcSiNDriSN37RQX9s8Ib1 kXVe9UL/tGPC9o0Qio++DpYsMRcrXsBy7PjUKVjNbuC5gpE4wc/Uc1EfQpeM99uXlWB0U3DHkUj pzgUCDKIebFMglMNc4JWiL5tz67rCF3PIJ2evhFj0jBCyaHmIuxV/TYysMBwVmlaHgZQ8XCZzyE m/o5Es2og62mgUQGC4W1DHmxaSM7KM X-Google-Smtp-Source: AGHT+IHRmBOGqlCeKbl6AHWmj9HVgDJ0CGIkFOOn3hfusMT9yYcnhprZUQ1h5GdB1IBCiYDbcyaVyw== X-Received: by 2002:a50:fc0d:0:b0:641:2cf3:ec3e with SMTP id 4fb4d7f45d1cf-64b8e949b04mr22229273a12.11.1766990611728; Sun, 28 Dec 2025 22:43:31 -0800 (PST) Received: from draszik.lan ([212.129.79.255]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b9105a9c4sm31042004a12.12.2025.12.28.22.43.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 22:43:31 -0800 (PST) Message-ID: <1baa0a0e89385b7ca8f56f65efd79a42f3eeaa74.camel@linaro.org> Subject: Re: [PATCH 5/8] regulator: core: remove dead code in regulator_resolve_supply() From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Mark Brown Cc: Liam Girdwood , Javier Martinez Canillas , Jon Hunter , Dmitry Baryshkov , Oleksij Rempel , Peter Griffin , Tudor Ambarus , Will McVicker , Juan Yescas , kernel-team@android.com, linux-kernel@vger.kernel.org Date: Mon, 29 Dec 2025 06:43:51 +0000 In-Reply-To: References: <20251227-regulators-defer-v1-0-3104b22d84cb@linaro.org> <20251227-regulators-defer-v1-5-3104b22d84cb@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-2+build3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Mark, On Sat, 2025-12-27 at 20:01 +0000, Mark Brown wrote: > On Sat, Dec 27, 2025 at 12:17:49PM +0000, Andr=C3=A9 Draszik wrote: >=20 > > No functional change intended. >=20 > > Fixes: 98e48cd9283d ("regulator: core: resolve supply for boot-on/alway= s-on regulators") >=20 > If this is just a cleanup then clearly it's not fixing a bug.=C2=A0 Pleas= e > don't throw Fixes tags on random commits that don't actually fix bugs, > it just makes noise for people who are looking for actual fixes. I added it to highlight that the dead code removal should have been part of that commit, but left out CC:stable for the reason that this commit is not strictly required. Especially the now incorrect comment in the code was a bit confusing since that commit, and I wanted to make it easier for future reader of that code, no matter which kernel version somebody else might be looking at. Anyway, will drop in next version. Cheers, Andre'