From: "Arnd Bergmann" <arnd@arndb.de>
To: "Romain Gantois" <romain.gantois@bootlin.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] misc: ti_fpc202: Support special-purpose GPIO lines with LED features
Date: Tue, 27 Jan 2026 15:03:48 +0100 [thread overview]
Message-ID: <1bae4f71-9688-4e6c-8025-920dc20cdf88@app.fastmail.com> (raw)
In-Reply-To: <20260127-fpc202-leds-v1-2-ebd0cfb9f9a1@bootlin.com>
On Tue, Jan 27, 2026, at 14:51, Romain Gantois wrote:
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -118,6 +118,7 @@ config TI_FPC202
> depends on I2C
> select GPIOLIB
> select I2C_ATR
> + select LEDS_CLASS
> help
> If you say yes here you get support for the Texas Instruments FPC202
> Dual Port Controller.
Selecting a foreign subsystem is usually a bad idea, as it
leads to dependency loops.
For LEDS_CLASS, I think this needs to be 'depends on LEDS_CLASS',
or possibly 'depends on LEDS_CLASS || !LEDS_CLASS' if you want
to keep that optional.
I would also change the GPIOLIB dependency the same way, but that
should be a separate patch of course.
Arnd
next prev parent reply other threads:[~2026-01-27 14:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 13:51 [PATCH 0/2] misc: ti_fpc202: Add LED support Romain Gantois
2026-01-27 13:51 ` [PATCH 1/2] dt-bindings: misc: Describe FPC202 LED features Romain Gantois
2026-01-27 19:45 ` Conor Dooley
2026-01-27 13:51 ` [PATCH 2/2] misc: ti_fpc202: Support special-purpose GPIO lines with " Romain Gantois
2026-01-27 14:03 ` Arnd Bergmann [this message]
2026-01-27 22:40 ` kernel test robot
2026-01-27 22:42 ` kernel test robot
2026-01-27 22:43 ` kernel test robot
2026-01-28 0:30 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bae4f71-9688-4e6c-8025-920dc20cdf88@app.fastmail.com \
--to=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=romain.gantois@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®