From: Dan Carpenter <dan.carpenter@linaro.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Brandon Pollack <brpol@chromium.org>,
linux-kernel@vger.kernel.org, masahiroy@kernel.org,
ojeda@kernel.org, alex.gaynor@gmail.com, keescook@chromium.org,
nathan@kernel.org
Subject: Re: [PATCH v2] .gitignore: ignore smatch generated files
Date: Mon, 8 May 2023 12:42:23 +0300 [thread overview]
Message-ID: <1bb3aa1d-1f01-4260-9ebd-598f3dffa420@kili.mountain> (raw)
In-Reply-To: <CANiq72kHP7SQNkY2iU6h3PacmRZUN3yRfk2VJjROz51YVBXoxw@mail.gmail.com>
On Mon, May 08, 2023 at 11:29:47AM +0200, Miguel Ojeda wrote:
> On Mon, May 8, 2023 at 7:54 AM Brandon Pollack <brpol@chromium.org> wrote:
> >
> > ignore smatch generated files.
>
> Sorry, I should have mentioned this in v1: this line just repeats the
> title -- please also give the rationale for the change in the commit
> message, not just what changed.
>
I secretly wanted to say both things you said. Also please start the
commit message with a Capital letter. Here is my proposed commit
message:
The Smatch static checker creates some data files in the kernel root
directory. Add them to the .gitignore file so that no one accidentally
commits them.
regards,
dan carpenter
prev parent reply other threads:[~2023-05-08 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 5:52 Brandon Pollack
2023-05-08 5:58 ` Dan Carpenter
2023-05-08 9:29 ` Miguel Ojeda
2023-05-08 9:42 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bb3aa1d-1f01-4260-9ebd-598f3dffa420@kili.mountain \
--to=dan.carpenter@linaro.org \
--cc=alex.gaynor@gmail.com \
--cc=brpol@chromium.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=nathan@kernel.org \
--cc=ojeda@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®