From: Russell Haley <yumpusamongus@gmail.com>
To: Mario Limonciello <mario.limonciello@amd.com>,
Hanabishi <i.r.e.c.c.a.k.u.n+kernel.org@gmail.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] cpufreq/amd-pstate: Set initial min_freq to lowest_nonlinear_freq
Date: Sat, 4 Jan 2025 21:37:10 -0600 [thread overview]
Message-ID: <1bb556a4-6b9b-42ae-98d2-15c8986cb88d@gmail.com> (raw)
In-Reply-To: <62f0402c-89a4-4ca8-b443-fbc9cc3b2055@amd.com>
On 12/8/24 10:35 AM, Mario Limonciello wrote:
> On 12/8/2024 01:54, Hanabishi wrote:
>> Hello. Maybe I'm too late on this, but I have some concerns.
>>
>> On 10/17/24 05:39, Dhananjay Ugwekar wrote:
>>> In other systems, power consumption has increased but so has the
>>> throughput/watt.
>>
>> I just want to bring up the fact that this change affects all
>> governors. It sounds good for the performance governor, but not so
>> much for the powersave governor.
>>
>> So the question is: don't we want the lowest power consumption
>> possible in the powersave mode? Even if it means decreased efficiency.
>> Powersave by definition supposed to make battery last as long as
>> possible no matter what, isn't it?
>>
>
> No, the powersave governor isn't a one stop shop to bring everything to
> longest battery.
>
> By your argument we should set the EPP to "power" by default and "boost"
> to off by default when the powersave governor is enacted?
>
> All of those are far too aggressive for a default behavior. Setting the
> lowest nonlinear frequency as the default lowest scaling frequency is
> about having a good default that balances responsiveness, battery life
> and performance.
>
> Like all knobs anyone that doesn't agree with it can of course modify it
> from sysfs.
>
If the documentation is correct, the lowest_nonlinear_frequency *does*
result in the lowest battery consumption unless you are running one or
more threads at 100% utilization until the battery dies. In that case,
lowest nonlinear frequency should result in greatest number of
instructions retired when the battery dies. I say instructions retired
rather than work completed, because "100% until the battery dies" is
only stress tests, malware, and damn-the-torpedos concurrency frameworks
that use spinwaits.
If that is not true, then either the documentation is wrong, or the
CPU's reporting of its lowest nonlinear frequency is wrong.
I am puzzled why the CPU even exposes frequencies below
lowest-nonlinear. They should always be worse than PWM-ing between C0 at
lowest nonlinear freq and some deeper C-state. Testing software that has
to run on much slower CPUs, I guess?
next prev parent reply other threads:[~2025-01-05 3:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 5:39 Dhananjay Ugwekar
2024-10-17 5:39 ` [PATCH v3 1/2] cpufreq/amd-pstate: Remove the redundant verify() function Dhananjay Ugwekar
2024-10-17 5:39 ` [PATCH v3 2/2] cpufreq/amd-pstate: Set the initial min_freq to lowest_nonlinear_freq Dhananjay Ugwekar
2024-10-17 14:46 ` Mario Limonciello
2024-12-08 7:54 ` [PATCH v3 0/2] cpufreq/amd-pstate: Set " Hanabishi
2024-12-08 16:35 ` Mario Limonciello
2025-01-05 3:37 ` Russell Haley [this message]
2025-01-06 4:43 ` Dhananjay Ugwekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bb556a4-6b9b-42ae-98d2-15c8986cb88d@gmail.com \
--to=yumpusamongus@gmail.com \
--cc=i.r.e.c.c.a.k.u.n+kernel.org@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®