From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 463E3230BDB for ; Thu, 19 Feb 2026 01:08:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771463301; cv=none; b=Rs2YZoXm7OI+iabfr6RisSxVhvp08ZWjkGwy6UUwUs9U2VIrhIK4zYAez3on4C3JXRBy46F+IIuRB0HVYQl/n/gWjmtZtjLMnhbRqenZApB6rxb3FV0FoEB7K60REpOMQHHkefaMjroT400m87YFtj0iKJNXj7VXiM0Uo2qKdrY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771463301; c=relaxed/simple; bh=zpc3vxBmyowwamws9N66QY8zHz5nQtFouvAS9YUCUgc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=W38pfm0xuwXoubt+9St6MdJXy6xHResDe/YNG4GvXm4l6S7IwxDalGSEKDtkxdUx/zB/HOXuY8PVnjVjqWluQ3VZvm5gbeii6aHgD86QeM1m5grtmyQbT/zWNOaIyhNLHSh4tAySRfFI8xaJWJKwIx68X6PlLSi3LQb+/cIPlLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SSz/ai7w; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EasqSy80; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SSz/ai7w"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EasqSy80" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61J18JRD3077992 for ; Thu, 19 Feb 2026 01:08:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= B1geA/cGZaqJIXyTzO6HfoUpfe8wABs6l5WrCbK8kMw=; b=SSz/ai7wIa66qU+i 1X7aS3LxJY9HJZBYkmKv1DZO22dgE/ymWtMUikWhqz1P7qaSbpcKe88/1EAqMi9b UnXqqAiZqJYDfl6ISb2I+VrYIiIKdMhRSEPPXQL8J4qcijRIajDcsEhbMxNds0UY gYCV6Ky4OqTri8/KUCSuTwp2PSOi3fgzDBCUoqe9yfpCAt+199qixkaWeAQ46MIF PtlrGmLPl2wVT+OiW+PTarS5jB/kkYnpT3cRaaDbmblEklJH86fRfifqmCzVSRSV oylShsIKF4cUSdR+UloXeq5vRdTS+o3UlSAw3dpNOflTBZ+VrnyYTb/tU8PJZC3e UaP4qw== Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cdrk8000q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Feb 2026 01:08:18 +0000 (GMT) Received: by mail-ot1-f72.google.com with SMTP id 46e09a7af769-7d4ee07e31dso8378825a34.0 for ; Wed, 18 Feb 2026 17:08:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771463298; x=1772068098; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=B1geA/cGZaqJIXyTzO6HfoUpfe8wABs6l5WrCbK8kMw=; b=EasqSy80UOA/+MDSZFbGSxhshs3NBqByea46Kvf0zuj+ZowWevUWILj/o6mhwQr+gm ZHAIwiMiQuob1zjWyg844/7q8JsSaN29BIQikrU4KPIsMo7XbAvgp/7i46xelX8fzauV lM7B2Axgw758gHRJVmJ1sQM4VbHQPJEP9Fsz8t5oNKeQErzspqr9sYWCaalrDAmcZ9qA VZv8pIq+0d7jfL4sL6apC+5L2wakM2wbcnuvbDgX++KLuZb9vnR36X3toNrRn/JVFlu5 9wZgllUXUj+hti0mlmYtjzZvQgYgOQZoCiGzRJqsIpdMMN8bf0EM/zj71cbCJdeNQq1m stFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771463298; x=1772068098; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B1geA/cGZaqJIXyTzO6HfoUpfe8wABs6l5WrCbK8kMw=; b=luHX8t1fqomQeuwkqRWw8Vwh7uFPViFv1hVYAuC3hGxFildQye+JjYKtkk40DkL7aL emJku0Zrt/D1wa5WsupcvM1ZlfyxFvBNHmG6PstDiEkK6gNU+0lrLe1fEodN4nfgDNGz impd+nDjjj4up3AwGXUJiYLFOyWM0ryWq6/yD5xZbGo+ApONLL7svzmmteD3aEMRiGO8 /cObxgbK1MFXEfN+nAaxMtjm0g4LQAICOXXbucvu5CRSNtUJ/OZm6qKqz/Zy7UcWAMEk rIai+9DJ8iL2VFDNkYoEsiA5c1yrli4V+53dubCmeQfuZzeqsuJk0ckxELCOKMGXX6cM 3Vrg== X-Forwarded-Encrypted: i=1; AJvYcCUc5gfCpurJpWCPDWIQiUcagWZgpg2WkucZjBz9k95/+OC1qYuHEuafOdMWT1v78hyEAeSeFnGWmkdqZQE=@vger.kernel.org X-Gm-Message-State: AOJu0Yxsxv0NwY9ya1Skv7BTIuDgc3qldkprl9JQ+ruBFbpD5vz9qGjC rV1kvF8AB/evvogMViYvczusBaB+nvvwFtwSFs8IjeBeWkik4xfppgCWluwuUYOXE5In4cpIUtI huIRdf4/BL9BusZT4yQ7nrl1u5GLRByIPMBbbRytOS6IYj7GApJEgFycFn0U8Kbc71yw= X-Gm-Gg: AZuq6aJAaDWjI0Zv7+sOPKMpeoqVr16ZpDyHO5YMbDoZzm0fnfyqAUXroddrh5xPHWd gcFINKLMjh6IKCh0nBndw424tLBNpl04h+0yBO8Zoz+YzvXXTH7VhAqxf4YPeKudsvxRnVsQQfr /J26oOU4vEHqXXDrp/s7KAJdSBazyG6b4uaFBod9nIM/TBXhK/F/+9c0o+w6vRnFjFgApQh15Qe AC6T5vB/sTJ9CgxDlfg/4F4BCM6WXthIKKhQ6gUt+sKDsmi7b6odrPRE1NrLZ+lECof5yN1vVFo ob1TmzSPZcik3GkxLAehNXdcXxmfZnTRIAVvrRdVtAMZb09Gh0LWwX9kSzlYyIorU0pi+J4mcqN ktcNUpwXvLB1UJMvjDrmJ5VzgpyX4GmQOhelYVQTEXmqXsCZ+ykKFCQXYAF/yOojg57/Q+LnGbB QlrA== X-Received: by 2002:a05:6830:660c:b0:7cf:d7ab:bc5d with SMTP id 46e09a7af769-7d516a1d0f0mr127702a34.15.1771463298158; Wed, 18 Feb 2026 17:08:18 -0800 (PST) X-Received: by 2002:a05:6830:660c:b0:7cf:d7ab:bc5d with SMTP id 46e09a7af769-7d516a1d0f0mr127684a34.15.1771463297760; Wed, 18 Feb 2026 17:08:17 -0800 (PST) Received: from [10.62.37.112] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d4a7720a95sm18315578a34.29.2026.02.18.17.08.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Feb 2026 17:08:17 -0800 (PST) Message-ID: <1bb6ddd1-54ec-4085-a321-a9b4f2b54950@oss.qualcomm.com> Date: Wed, 18 Feb 2026 17:08:15 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v2 1/5] media: dt-bindings: Add CAMSS device for SM8750 To: Bryan O'Donoghue , Hangxiang Ma , Robert Foss , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, jeyaprakash.soundrapandian@oss.qualcomm.com References: <20260119-add-support-for-camss-on-sm8750-v2-0-3e06583a0a81@oss.qualcomm.com> <20260119-add-support-for-camss-on-sm8750-v2-1-3e06583a0a81@oss.qualcomm.com> <406f2ca6-d136-4c05-bb46-65d39c1eedbc@linaro.org> Content-Language: en-US From: Vijay Kumar Tumati In-Reply-To: <406f2ca6-d136-4c05-bb46-65d39c1eedbc@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 3B7ByG7EWmN7XtpfnKbh1ElAcf2tHeAg X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE5MDAwNyBTYWx0ZWRfX/ffdXRVNNnui 4XDQJodyYMb26+fvfivnspxbc4opZriFc4uEe910F3wxtjvOAXvayyjd+zbEkGbgGJq+TM/O035 xs0qTbwmmySerh52YVC6HfBA3rHSA/2GtBNRupOO0jYKcQqI3rRq7uo4VlzKA9CLMwCNxYsc50O MsxWuaZwdtjAN8icATsnrlPtSo2X0PkTR5FCIA0ehUvYiBr3k7f9FP/xOGYm70yj9zJwidHYEGM PANxvE/0mVXhYp2kvsD8oBWv1xKdNUm80a+/cW/rUSsTcy2xLBqZ0d62hc45gMnvou9diKjbYcG mDL2SAswHKfQ13wNyri8nKKEoxJCrMRMdMwQBm6vPUvrZdzwIGUvKdKAdK94VJU/CxXXrj2ZeOI xJ5CEy7x9NObuXMPHv3uOCq+/U9xFYO16qv2tJfXtzIF4lC5nuBHo1+Ecnzoyrhq7OOyvNMMt4e DKSHJ5YCaKUPUL3FRCw== X-Authority-Analysis: v=2.4 cv=MJBtWcZl c=1 sm=1 tr=0 ts=69966282 cx=c_pps a=+3WqYijBVYhDct2f5Fivkw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=NJT1t43cUZnzdZ1aRTsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=eYe2g0i6gJ5uXG_o6N4q:22 X-Proofpoint-ORIG-GUID: 3B7ByG7EWmN7XtpfnKbh1ElAcf2tHeAg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-18_05,2026-02-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602190007 Hi Bryan, On 2/18/2026 4:50 PM, Bryan O'Donoghue wrote: > On 20/01/2026 06:42, Hangxiang Ma wrote: >> +      - description: Registers for ICP (Imaging Control Processor) 0 >> +      - description: Registers for ICP 0 SYS >> +      - description: Registers for ICP 1 >> +      - description: Registers for ICP 1 SYS >> +      - description: Registers for IPE (Image Processing Engine) >> +      - description: Registers for JPEG DMA & Downscaler 0 >> +      - description: Registers for JPEG Encoder 0 >> +      - description: Registers for JPEG DMA & Downscaler 1 >> +      - description: Registers for JPEG Encoder 1 >> +      - description: Registers for OFE (Offline Front End) > > This is a weird map - it doesn't seem to have a BPS ? There is no BPS module on SM8750. > >> +      - description: Registers for RT CDM (Camera Data Mover) 0 >> +      - description: Registers for RT CDM 1 >> +      - description: Registers for RT CDM 2 >> +      - description: Registers for RT CDM 3 >> +      - description: Registers for RT CDM 4 > > I actually think these should be standalone nodes. > > I've done some prototyping work on Hamoa to bring up the BPS and IPE > using the ICP and the HFI protocol. > > An absolute torrent of TLAs there but one thing that pops out of that is > the current CAMSS bindings we have kind of match how camx works when > there is an ICP. > > Linux/HLOS programs up the PHYs, CSID, IFE, sensor and then the ICP is > tasked with owning the BPS, IPE and hiding away the complexity of the CDM. > > So to me that says we should keep CAMSS bindings as they are largely. > > I think its just messy to keep jamming registers into this map - it > really is an enormous list. > > Lets revert to the simpler version and add new nodes as we enable them > for OPE, IPE, BPS and ICP instead. > > OTOH I will publish the CSIPHY code you were asking for either tomorrow > Thursday or Friday and I'd be obliged if you could review and ideally > align with that. > > A humongous blob of a camera block seems like a legacy sin we should > just fix. I am not sure I followed this entirely. Firstly, you weren't referring to the RT CDM register blocks (although you added your comment there), are you? Secondly, I thought you wanted the complete HW description as it is supposed to be in the DT bindings, isn't it? I am not sure why you think it is based on how CAMX works, rather purely based on the HW blocks and registers available in the Camera sub system on SM8750 and it is up to the driver, whether or not to use the ICP for offline modules, although using ICP is generally advised for the stripe based processing. CSIPHY nodes - sure, if you advise that, we can. > > --- > bod Thanks, Vijay.