From: Chen Yu <chenyu56@huawei.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: <wangbinghui@hisilicon.com>, <mathias.nyman@intel.com>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<fanning4@hisilicon.com>, <lirui39@hisilicon.com>,
<yangdi10@hisilicon.com>, <groeck@google.com>,
<john.stultz@linaro.org>
Subject: Re: [PATCH] usb:xhci fix panic in xhci_free_virt_devices_depth_first
Date: Mon, 6 Nov 2017 16:07:55 +0800 [thread overview]
Message-ID: <1bb9152e-083c-a2ac-4b71-94b14454c012@huawei.com> (raw)
In-Reply-To: <20171106075944.GA19812@kroah.com>
On 2017/11/6 15:59, Greg KH wrote:
>>
>> diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
>> index 2a82c927ded2..295789d993b0 100644
>> --- a/drivers/usb/host/xhci-mem.c
>> +++ b/drivers/usb/host/xhci-mem.c
>> @@ -947,6 +947,11 @@ void xhci_free_virt_devices_depth_first(struct xhci_hcd *xhci, int slot_id)
>> if (!vdev)
>> return;
>>
>> + if (WARN_ON(!vdev->real_port)) {
>> + xhci_warn(xhci, "Bad vdev->real_port\n");
>
> Why warn twice? What will that help?
>
> thanks,
>
> greg k-h
>
> .
>
I will fix that and send patch V2. Thanks!
Best regards
Yu Chen
prev parent reply other threads:[~2017-11-06 8:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 3:28 Yu Chen
2017-11-06 7:59 ` Greg KH
2017-11-06 8:07 ` Chen Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bb9152e-083c-a2ac-4b71-94b14454c012@huawei.com \
--to=chenyu56@huawei.com \
--cc=fanning4@hisilicon.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@google.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lirui39@hisilicon.com \
--cc=mathias.nyman@intel.com \
--cc=wangbinghui@hisilicon.com \
--cc=yangdi10@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®