From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8756839DBFE for ; Wed, 11 Mar 2026 23:05:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773270352; cv=none; b=BsiaFgxifHPEWNt38cz9/CZ8/Q6nDex+XBuiBSdoBIpJAN5Hyi5gMMWYgaa+IV16wmu9hp5DVwHZ/mosfMaYCm774P63Z3hjOmYUpVh8ARu7ZPCR4/qaQ/3vARiOSc8eteUEVhpiw8seisprrGCsRDbHze2mbx9ZnagH7lnOFuI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773270352; c=relaxed/simple; bh=rfKuOzvHe5vBbX9keVb//BJgX5e9Vh2x9YeAvZCPoVM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nrIITfwaDnjzyhikrZXwEmGUi3o7IzUBtPHanbmmW6gA+ayZzaqUCDCha4JD5xNKORZuZgLHFAIwNCQSmHAWzxh/IQmnFUHXi4kQr09N22oqRNhi9LXxAYa61q5D0K98WwbMpyKT8/t6ITOH5zzyOQaB9tjYcFvwxUGjjjbwGa4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=D2xCPE0s; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="D2xCPE0s" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-6630858b4ceso467167a12.3 for ; Wed, 11 Mar 2026 16:05:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773270350; x=1773875150; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZNc95yBeQgjpi9QO4APmDLhPk0cXt4A6W6yy8C9WSLE=; b=D2xCPE0s5zyDyTGigNQ1MakKhNaOmsWBNhdiUDFHTgziagAYK6laDimkgs/DL5udfk JIiFK+Rys2O91h2E2DRflOHdsKhDT0PagNm7+it5sXbFAMxDLKLiJyY+wOZ8anieq1zg Nkbfzjr7qdV4/FSNKZP48EyQzxya3yroet99O3l5TVjo7ZytP1UuStM817+TU4lYJL5f +oD5b+K//UdKxzLpBSi3ovbE/4lIqWVrQWKooVqN913lMfQ1/UEzCUdCoifgYHdTUSHL dAlp3da+RKne9aN3/SrOS+7R8/rK1Ww8UrmkJmNEDstIyn4ZY03ciBeTEO58M9iq88NE DtMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773270350; x=1773875150; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZNc95yBeQgjpi9QO4APmDLhPk0cXt4A6W6yy8C9WSLE=; b=IUQgVEvTcT/ifqryfo5nl+M6fqJbvFgFrIRo4bP1KO8od761//WX76Uewx2RmbhpPB TzHNhqzn37j1T8b18JbYnA/iQz5kwvq5D4jG8hQvn25aOSlf2Ngxh/zuSSnBJJuNE4tq zE46BOKs2yVMv1GpVJpFif1rbf8SEroMyEU3tIzNh7nviDwT2cW5Zs0dUA/gLLd0GUcY KRZDwgkXc2Tscq+zuyH7hgJn/rGekMDBYhtsKtKKklpaDkE22SGwBjI2MygAOJVZArKG qap6SKdrQVHyEDKsw7CiLZSuvrXqMEipi0XDMOAwqjebl6ZOqr4iYZ+ooGwW0X9pJlcC 6+hQ== X-Forwarded-Encrypted: i=1; AJvYcCWnPCsjYepivmCoeN1t1aB31dQpXps9zvZ2jONBFZPch7IECYU8PG59m2vgybFvJnQNqj872qV5f45r594=@vger.kernel.org X-Gm-Message-State: AOJu0YyCEpILf+pygmsFd4VM1quyARIA2O05XWf0lTakpj/EAALXgfHX 8ZoTbO28Xet1JC0glb3GPyZhXNiBxTREzDf6CCU/7cxu66roiN3tyETGeUPaCU1yfCYSh9uNwfS LBSNf X-Gm-Gg: ATEYQzy/RR6E8v/n1hF55a2AL9W4ICEAD5b0tMNiTGszfsdf+Mdf4CASl2pnRn1agKf dTARO05MkOzGUwOwEgvX4NgPUzE91PQuDkyOnGxwd6vVnJsZfaIixKkpBcVnOUla2kc5Tg0xo/4 cvdeW5bs9ASLcl+X5k5Q202lPq+/isobspOSZzw4qdMk1GkzpliaM4Rq1gR+f+2CDy5Hbk55ybb Yr5HrFHzLVI55InSyRqT4QHBjKDTbJTGiRmOtGw0LMLS4Y+h3+Kmq9Vx9OPiK8BTb/KJtDdgi/C Wu2pOopK8QS91qsVvoSTKCRsURlRCBrcHmPN+AbvbK3OH5/6ozBtHpGO6fuqv/k0Or1BVN+AnMV drfqLHT473LJUoQSTAm5EXICy0ol/5urFPXujqG3o/VlPpefSZTFeX+hMp1l1GpTBg+2JYIyXfN Oq9C9pj8ja/M+W6ZW+RujwsXAhyKUv6hHatw== X-Received: by 2002:a05:6402:f24:b0:662:bd56:3ba3 with SMTP id 4fb4d7f45d1cf-66319ee4b53mr1755231a12.31.1773270349747; Wed, 11 Mar 2026 16:05:49 -0700 (PDT) Received: from [192.168.0.101] ([109.77.88.70]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6634ead9972sm279788a12.0.2026.03.11.16.05.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Mar 2026 16:05:49 -0700 (PDT) Message-ID: <1bc80b89-5b09-4042-a61d-698884febded@linaro.org> Date: Wed, 11 Mar 2026 23:05:47 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 2/2] usb: typec: qcom: Add support for shared USBIN VBUS detection To: Alexander Koskovich , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heikki Krogerus Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260308-qcom-typec-shared-vbus-v1-0-7d574b91052a@pm.me> <20260308-qcom-typec-shared-vbus-v1-2-7d574b91052a@pm.me> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20260308-qcom-typec-shared-vbus-v1-2-7d574b91052a@pm.me> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08/03/2026 23:20, Alexander Koskovich wrote: > + if (IS_ERR(pmic_typec_port->vbus_detect_gpio)) > + return dev_err_probe(dev, PTR_ERR(pmic_typec_port->vbus_detect_gpio), > + "failed to get vbus-detect GPIO\n"); > + I'd prefer if this was bracketed since it is over more than one line. Reviewed-by: Bryan O'Donoghue --- bod