From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BAB038DC65 for ; Thu, 30 Jul 2026 16:46:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785429986; cv=none; b=jP4ONrwi4T1e+ebOnBo9D28RT95XjULl52z++rU0AG2G/aAyH3C7hE6Jnclpd5a9tucRUx0cpmwUy4rdbFNShryZE5CRtpBL5wEz+MS+3l/uHaKwxgekT4d3XKlmtidUC5KIN7SOpCvbYwodpRpgiEt1Mqn91DAUMLWjEdLdtp0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785429986; c=relaxed/simple; bh=IAI5fPC8kUOmVOXpbjJOoXS/9005rgomTstYB1sbH1Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=setC0DAkm6D0ybRjgOn8S26ctIvLrhh2xkFfOkaxpXa0uOCxk41weskMsoI9fhh0iMN8Fq0rSYi9gxymZ1OvrMCTx1p/f9wbgMO9Pg2He/AX37B1+4ZDCsUjcKXG+OTeOXsgEpszPCk4A0NknFQ8v7Dv+zYZ8N0JAotSxL+7FOs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ipmUR5tl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=O/x4foCU; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ipmUR5tl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="O/x4foCU" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66UGXW4Z1571714 for ; Thu, 30 Jul 2026 16:46:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 41bv1bQPLiy8a8DyzT5YhAkpHkoFIBS2fv2LzdT9CjM=; b=ipmUR5tld1IyruPP gLTAvhy5UXbBEOd/bHHBUvy61Ek7rWw+V3LY4Tf3rWescP7bFORUy41PS7fj5Kep jtTqQOvktgowmxUHVdIF8PsuO+bLpk6EVfk5LQ++oVw/iWOGACKvRrvwM/tK89eS C8C4WVMXWyfjwh2vQ7rYxPXv1104hLdjN63CVIh+Z06zJrnKJSlQ+NJB09/PhNSm pe30Z9avESrmQzHn6rRTkohbdv/1VIr11gxjzmdeb9RW6W3oiKEwCsRFhwYyOym2 mkRNmta4Jspk0/Rm/I7P8D3UPUFL9PSMVY9FS9xqqPH7DkkNFwKU9UGQ0Fvo8NiK SHUyYg== Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fr891gtkp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Jul 2026 16:46:24 +0000 (GMT) Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-97752c2acb7so26920241.3 for ; Thu, 30 Jul 2026 09:46:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785429984; x=1786034784; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=41bv1bQPLiy8a8DyzT5YhAkpHkoFIBS2fv2LzdT9CjM=; b=O/x4foCUNwzA9OsePEbs81GnAhgUCyMnzwhHobTO2qihx5EVLXDmRQGGeZ6YeMCBG0 v23sW6M0bLMayc3YawO3pDDyKksK4EnzjTgYyq1o43chStgm4A5N/AgMEugqNr/KBt6z QIWxhgmeQWG5Tx7xOt2mZu/g2LgT83DGd+gALkVvk6AOZnpEQazBaejKh+iwa62QnKQk LqCJ8uF/FZUgZX6KlqvGGS/10yrPpAJvEc8/atpxA3ruLAUp6ixvUHK0azN+n0DXyM6X 1WXV31HSBTxQtLVGRbv+teHVdhvYaOfaZUSSeKGoRpMxjj4bui4rco2o5ucNqBEU0ICM IOzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785429984; x=1786034784; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=41bv1bQPLiy8a8DyzT5YhAkpHkoFIBS2fv2LzdT9CjM=; b=bgLBqt39zo6IDFAumwleKiKUXm93xaKxUvOr900ak67goOnVgupt2a9+O0xi4VfbBb h7R+XfnYT0uRC865Kem2/XgQJQcNd3KeaPdeuLiJaVB5yKqSyoc6O6B951eSuuJcnyzb QkdooX9T6lKit+tywki1CAOOTXWprKKD1m8fwmnG/PMQLKSGjNgZUM+F5wJkbyByZV/B Qbt83B8vB0GM9QSwPBYsx0dmtrNJBwBrzZh8fbF7s+fRYfQfnmvF7gxO6khENYFXRt8F IIxL7tsLnqer4wkIThnb4MN4SVx1UrMVjn1LoCbZReswA5oxrEfmo9ObzadPyQcHDXGL CceA== X-Forwarded-Encrypted: i=1; AHgh+RqvHqRSIHVWDoqkc1tJ+2DlKh8mV8Ta63TjehqFkQ95TAFZRYffaZ0Hheaj/Xil/CPZA3BKP4fkX9AFp0Q=@vger.kernel.org X-Gm-Message-State: AOJu0YxmF2TxOzRY8p4Wf0KR90mL+/hWIM0Jb5VxkMaDegGpuW4aYpo+ K7W7/dLQ3CoiT934+1wOCNVC8QhLXIuwgaOcK4hc4OA4InuO26XrV0Bo+allghXGkyH9LN9eBcV Te89+kwlSlZxJg2bDN5MPm1lgBeWkmag27TWAyvF2Km5c0ovUNgbk5soYdKi9t1nZHBI= X-Gm-Gg: AR+sD12ai5+U8nGyZIajoePS8sHtWTxFi+VFkukVGgwraapyYvIUjFoDLo1dVcL9qEF ZgxolgW8XrmR3l0Phdkftup5KAAkwydwqfPpNTLOlyNkkRWzxrciqLELMzwcnVObAiE4iRQ2Gbj r8lkYwus6j4W4rR/H+g+FxuG4t6wwBfoazQT/N2qjyc0DhittG+D3M4FB0ZgGjg901LvoBAVWxG rSUVLWXkbDj3v/eavQ1BHonKiP05wn2ngLVe1zyOjcnaBMS8oc5sKia2AxpY9PQ+Gx0InQQKLJz mEdYQRjMt/rAjEwvDJyTN2EmhgpLBRRuFHINVluDQaB6YIycPXvkPff6AoKWy2MQ3aAtasOWZcx 3rEKxoA8m8Ax12EbpXadG/khs X-Received: by 2002:a05:6102:8090:b0:756:32ba:1a83 with SMTP id ada2fe7eead31-758407c7a45mr602056137.2.1785429983596; Thu, 30 Jul 2026 09:46:23 -0700 (PDT) X-Received: by 2002:a05:6102:8090:b0:756:32ba:1a83 with SMTP id ada2fe7eead31-758407c7a45mr602044137.2.1785429983191; Thu, 30 Jul 2026 09:46:23 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fa851b322sm91019666b.7.2026.07.30.09.46.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2026 09:46:22 -0700 (PDT) Message-ID: <1bcd1a68-a1b8-4604-8a2d-ece01ccabc00@oss.qualcomm.com> Date: Thu, 30 Jul 2026 18:46:19 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] usb: typec: mux: ps883x: refactor DP altmode handling and support TYPEC_DP_STATE_F To: jens.glathe@oldschoolsolutions.biz, Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Abel Vesa , Heikki Krogerus , Bjorn Andersson , Konrad Dybcio Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, stable@vger.kernel.org, "Dr. David Alan Gilbert" References: <20260718-ps883x-disable-usb4-v1-0-cec86d0b909e@oldschoolsolutions.biz> <20260718-ps883x-disable-usb4-v1-3-cec86d0b909e@oldschoolsolutions.biz> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260718-ps883x-disable-usb4-v1-3-cec86d0b909e@oldschoolsolutions.biz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMwMDEyNSBTYWx0ZWRfX+Kk1PllLNJtU rMH5hsL1GhNZag1BOMU6E1fAqwS1fKZtTxJv+QCXOiLRJeeByxVYpyqU7bf1ZMMnMO7sajBysqI PvBVYVn0Lu0mbYv6TW0R/XGJuj7o0P4OP8zefNtZdv8EEktioc4Rptpze/gzWLFgODqHUcJGHuv YzhR0CwldvAN67ytib+orspfc9/Ay5/vD4Gxrcs6Puz/+y5EWtDoO/nhsA/VxvH1Mdc8JbNAbK2 wwhqfgokexA/Yc7Px6pSV1TS7priR863Qbi4qw2b6dQ+HWfx/3F4HZXtxoRMDw6VdGNTsFdBWuG PYzeNvMGp75yLsE62QMtCtqeVysGa5C86I/6Rpb4KvVGEz7ZY0kDGcZb2LHxNDUB4NGDWkDkDL6 f8JH0hPglfs/gI/kSLg00m0Km+vI4u0Iqe0GEWcM2O/Dz+WU+t+eGBMu1Lfd6Z0FWf9bii4S9oQ YRaTurxIRsTpQIYwjFg== X-Proofpoint-ORIG-GUID: 4NJIZqpOhrefoappIGpvT0Cq4R9EV-l5 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMwMDEyNSBTYWx0ZWRfX5Jz7BX+mOvlf o7pVWcJlaUOCHQJNUDqKg78+OeBJmnj6Soce/OBi7nNQJmDUXOwBhnCh2ipzFp6ZUN4VEatlfSf pK658uqExwCoLnTflAPuV6i2shitsAo= X-Authority-Analysis: v=2.4 cv=PdzPQChd c=1 sm=1 tr=0 ts=6a6b7fe0 cx=c_pps a=R6oCqFB+Yf/t2GF8e0/dFg==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=gxl3bz0cAAAA:8 a=Xqxl2qIfDM1Vn1vrR_wA:9 a=QEXdDO2ut3YA:10 a=TD8TdBvy0hsOASGTdmB-:22 a=kiRiLd-pWN9FGgpmzFdl:22 X-Proofpoint-GUID: 4NJIZqpOhrefoappIGpvT0Cq4R9EV-l5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-30_05,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 impostorscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607300125 On 7/18/26 7:06 PM, Jens Glathe via B4 Relay wrote: > From: Jens Glathe > > Several docks, including the Lenovo 40B0 and SSK SC220, still send the > legacy TYPEC_DP_STATE_F mode request (deprecated since DisplayPort Alt > Mode spec version 1.0b). Treat it as USB3 + DP altmode (same as > TYPEC_DP_STATE_D) so that DP altmode works correctly, especially on > the 40B0 in Type-C fallback mode. > > Extract the state handling into ps883x_apply_dp_altmode() (modelled > after qmp-combo-phy) for consistency. > > Assisted-by: Grok(xAI):4.3 > Signed-off-by: Jens Glathe > --- I'd say just add a oneliner `case STATE_F` here instead Konrad