From: <Conor.Dooley@microchip.com>
To: <yangyingliang@huawei.com>, <linux-kernel@vger.kernel.org>,
<linux-usb@vger.kernel.org>, <linux-riscv@lists.infradead.org>
Cc: <Conor.Dooley@microchip.com>,
<Valentina.FernandezAlanis@microchip.com>,
<gregkh@linuxfoundation.org>
Subject: Re: [PATCH -next] usb: musb: mpfs: add missing clk_disable_unprepare() in mpfs_remove()
Date: Tue, 28 Jun 2022 16:57:30 +0000 [thread overview]
Message-ID: <1bdbd6a6-2bd1-cd03-b710-ced9f44cbaff@microchip.com> (raw)
In-Reply-To: <20220628140527.1404439-1-yangyingliang@huawei.com>
On 28/06/2022 15:05, Yang Yingliang wrote:
> clock source is prepared and enabled by clk_prepare_enable()
> in probe function, but no disable or unprepare in remove.
>
> Fixes: 7a96b6ea90a4 ("usb: musb: Add support for PolarFire SoC's musb controller")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/usb/musb/mpfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/musb/mpfs.c b/drivers/usb/musb/mpfs.c
> index a69ca338eace..cea2e8108867 100644
> --- a/drivers/usb/musb/mpfs.c
> +++ b/drivers/usb/musb/mpfs.c
> @@ -239,6 +239,7 @@ static int mpfs_remove(struct platform_device *pdev)
> {
> struct mpfs_glue *glue = platform_get_drvdata(pdev);
>
> + clk_disable_unprepare(glue->clk);
> platform_device_unregister(glue->musb);
> usb_phy_generic_unregister(pdev);
>
I'll file this one under "obviously correct".
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks!
prev parent reply other threads:[~2022-06-28 16:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 14:05 Yang Yingliang
2022-06-28 16:57 ` Conor.Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bdbd6a6-2bd1-cd03-b710-ced9f44cbaff@microchip.com \
--to=conor.dooley@microchip.com \
--cc=Valentina.FernandezAlanis@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®