From: "Christian König" <christian.koenig@amd.com>
To: Jeff Johnson <quic_jjohnson@quicinc.com>,
Huang Rui <ray.huang@amd.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] drm/ttm/tests: add missing MODULE_DESCRIPTION() macros
Date: Tue, 25 Jun 2024 10:00:24 +0200 [thread overview]
Message-ID: <1bea3fc8-1c29-4951-b077-d442257c93e5@amd.com> (raw)
In-Reply-To: <20240624-md-drivers-gpu-drm-ttm-tests-v2-1-76bb765e19c9@quicinc.com>
Am 25.06.24 um 03:24 schrieb Jeff Johnson:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_device_test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_pool_test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_resource_test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_tt_test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_bo_test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_mock_manager.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.o
>
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Acked and pushed to drm-misc-next.
Thanks,
Christian.
> ---
> Changes in v2:
> - Rebased on top of linux-next/master to resolve conflict with commit
> "drm/ttm/tests: Correct modules' licenses" as well as add descriptions
> for two new modules recently added.
> - Link to v1: https://lore.kernel.org/r/20240609-md-drivers-gpu-drm-ttm-tests-v1-1-d94123d95b4c@quicinc.com
> ---
> drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 1 +
> drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c | 1 +
> drivers/gpu/drm/ttm/tests/ttm_device_test.c | 1 +
> drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 1 +
> drivers/gpu/drm/ttm/tests/ttm_mock_manager.c | 1 +
> drivers/gpu/drm/ttm/tests/ttm_pool_test.c | 1 +
> drivers/gpu/drm/ttm/tests/ttm_resource_test.c | 1 +
> drivers/gpu/drm/ttm/tests/ttm_tt_test.c | 1 +
> 8 files changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c
> index 407c31b21872..d1b32303d051 100644
> --- a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c
> +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c
> @@ -633,4 +633,5 @@ static struct kunit_suite ttm_bo_test_suite = {
>
> kunit_test_suites(&ttm_bo_test_suite);
>
> +MODULE_DESCRIPTION("KUnit tests for ttm_bo APIs");
> MODULE_LICENSE("GPL and additional rights");
> diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c b/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c
> index bc8281c03420..1adf18481ea0 100644
> --- a/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c
> +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c
> @@ -1221,4 +1221,5 @@ static struct kunit_suite ttm_bo_validate_test_suite = {
>
> kunit_test_suites(&ttm_bo_validate_test_suite);
>
> +MODULE_DESCRIPTION("KUnit tests for ttm_bo APIs");
> MODULE_LICENSE("GPL and additional rights");
> diff --git a/drivers/gpu/drm/ttm/tests/ttm_device_test.c b/drivers/gpu/drm/ttm/tests/ttm_device_test.c
> index 0f235a834ede..1621903818e5 100644
> --- a/drivers/gpu/drm/ttm/tests/ttm_device_test.c
> +++ b/drivers/gpu/drm/ttm/tests/ttm_device_test.c
> @@ -209,4 +209,5 @@ static struct kunit_suite ttm_device_test_suite = {
>
> kunit_test_suites(&ttm_device_test_suite);
>
> +MODULE_DESCRIPTION("KUnit tests for ttm_device APIs");
> MODULE_LICENSE("GPL and additional rights");
> diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c
> index 70f40814b26a..b91c13f46225 100644
> --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c
> +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c
> @@ -301,4 +301,5 @@ void ttm_test_devices_fini(struct kunit *test)
> }
> EXPORT_SYMBOL_GPL(ttm_test_devices_fini);
>
> +MODULE_DESCRIPTION("TTM KUnit test helper functions");
> MODULE_LICENSE("GPL and additional rights");
> diff --git a/drivers/gpu/drm/ttm/tests/ttm_mock_manager.c b/drivers/gpu/drm/ttm/tests/ttm_mock_manager.c
> index 7f34fecd3fef..f6d1c8a2845d 100644
> --- a/drivers/gpu/drm/ttm/tests/ttm_mock_manager.c
> +++ b/drivers/gpu/drm/ttm/tests/ttm_mock_manager.c
> @@ -230,4 +230,5 @@ void ttm_bad_manager_fini(struct ttm_device *bdev, uint32_t mem_type)
> }
> EXPORT_SYMBOL_GPL(ttm_bad_manager_fini);
>
> +MODULE_DESCRIPTION("KUnit tests for ttm with mock resource managers");
> MODULE_LICENSE("GPL and additional rights");
> diff --git a/drivers/gpu/drm/ttm/tests/ttm_pool_test.c b/drivers/gpu/drm/ttm/tests/ttm_pool_test.c
> index 5d4dc5b1c6d7..8ade53371f72 100644
> --- a/drivers/gpu/drm/ttm/tests/ttm_pool_test.c
> +++ b/drivers/gpu/drm/ttm/tests/ttm_pool_test.c
> @@ -433,4 +433,5 @@ static struct kunit_suite ttm_pool_test_suite = {
>
> kunit_test_suites(&ttm_pool_test_suite);
>
> +MODULE_DESCRIPTION("KUnit tests for ttm_pool APIs");
> MODULE_LICENSE("GPL and additional rights");
> diff --git a/drivers/gpu/drm/ttm/tests/ttm_resource_test.c b/drivers/gpu/drm/ttm/tests/ttm_resource_test.c
> index 77be0942ab62..9c2f13e53162 100644
> --- a/drivers/gpu/drm/ttm/tests/ttm_resource_test.c
> +++ b/drivers/gpu/drm/ttm/tests/ttm_resource_test.c
> @@ -332,4 +332,5 @@ static struct kunit_suite ttm_resource_test_suite = {
>
> kunit_test_suites(&ttm_resource_test_suite);
>
> +MODULE_DESCRIPTION("KUnit tests for ttm_resource and ttm_sys_man APIs");
> MODULE_LICENSE("GPL and additional rights");
> diff --git a/drivers/gpu/drm/ttm/tests/ttm_tt_test.c b/drivers/gpu/drm/ttm/tests/ttm_tt_test.c
> index a8c76dbd6913..61ec6f580b62 100644
> --- a/drivers/gpu/drm/ttm/tests/ttm_tt_test.c
> +++ b/drivers/gpu/drm/ttm/tests/ttm_tt_test.c
> @@ -398,4 +398,5 @@ static struct kunit_suite ttm_tt_test_suite = {
>
> kunit_test_suites(&ttm_tt_test_suite);
>
> +MODULE_DESCRIPTION("KUnit tests for ttm_tt APIs");
> MODULE_LICENSE("GPL and additional rights");
>
> ---
> base-commit: 62c97045b8f720c2eac807a5f38e26c9ed512371
> change-id: 20240609-md-drivers-gpu-drm-ttm-tests-f7b63f46eb3c
>
prev parent reply other threads:[~2024-06-25 8:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 1:24 Jeff Johnson
2024-06-25 8:00 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bea3fc8-1c29-4951-b077-d442257c93e5@amd.com \
--to=christian.koenig@amd.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=ray.huang@amd.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®