From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0202DC46CA1 for ; Mon, 18 Sep 2023 16:27:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229875AbjIRQ1E convert rfc822-to-8bit (ORCPT ); Mon, 18 Sep 2023 12:27:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbjIRQ0a (ORCPT ); Mon, 18 Sep 2023 12:26:30 -0400 Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9227226685 for ; Mon, 18 Sep 2023 09:22:53 -0700 (PDT) Received: from omf04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CF3051C9E44; Mon, 18 Sep 2023 16:22:51 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf04.hostedemail.com (Postfix) with ESMTPA id 383CB2002B; Mon, 18 Sep 2023 16:22:48 +0000 (UTC) Message-ID: <1bed972eb2fb1dc305e5da9a75542558bbe6e13e.camel@perches.com> Subject: Re: [PATCH v2] platform/x86: think-lmi: Add bulk save feature From: Joe Perches To: Andy Shevchenko , Hans de Goede Cc: Mark Pearson , markgross@kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 18 Sep 2023 09:22:47 -0700 In-Reply-To: References: <20230906121328.50437-1-mpearson-lenovo@squebb.ca> <878da778-e183-6ef5-61ce-3a3d059f1a1e@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Stat-Signature: zdejjwn5y5o7datxjjyyqneonna6xmfa X-Rspamd-Server: rspamout04 X-Rspamd-Queue-Id: 383CB2002B X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX18IIPdAe/d0R+ZzEM+uijFVzoWhM8KY5sM= X-HE-Tag: 1695054168-795019 X-HE-Meta: U2FsdGVkX19KwzESdQyEVfr0h4yR2WFVwjXCedSSF4nzJW6icAqQ8Shw1ThHdgG+wjzVK2KL/ZymjMsWkDjdwQ+YHjNsw/nB/IwwMTgEzG0gZVNz09x4STXBIyePH7ZXIzME96RXunNzAc54qx8rVGq1IfUs8cn3aZwn3FM3ZLUyQ41im+6SOwGD4svfD2A5oLxA1Ya4RdW8rTM8f/kLGGysev6w6TBJbnzFcT53CbneMp+SgLqcihEw+CB8pmPG1iF1NCOp0DEuT6vvX2aFWxwH9e0HZy3i/4HIfn0uVIdN5YnfyLbvXMWHxTh/PYAv Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2023-09-18 at 17:38 +0300, Andy Shevchenko wrote: > On Mon, Sep 18, 2023 at 04:07:53PM +0200, Hans de Goede wrote: > > On 9/18/23 15:57, Andy Shevchenko wrote: > > > On Wed, Sep 06, 2023 at 08:13:14AM -0400, Mark Pearson wrote: > > ... > > > > > +/* There are a limit on the number of WMI operations you can do if you use > > > > + * the default implementation of saving on every set. This is due to a > > > > + * limitation in EFI variable space used. > > > > + * Have a 'bulk save' mode where you can manually trigger the save, and can > > > > + * therefore set unlimited variables - for users that need it. > > > > + */ > > > > > > /* > > > * This is wrong multi-line comment style. This one > > > * is used solely in net subsystem. > > > */ > > > > Good catch, Mark can you fix this one too please ? > > > > Also I thought that checkpatch.pl used to catch this ? > > I don't think it recognizes "net style is only for net related files". It doesn't as there are just too many of them.