From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta-65-225.siemens.flowmailer.net (mta-65-225.siemens.flowmailer.net [185.136.65.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCAC01FBCA1 for ; Tue, 25 Mar 2025 17:19:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.136.65.225 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742923147; cv=none; b=Xk3MExM3NJBOP/O6t8Y7RrAku3ADpqsQgjOy+j3c/05FIg8sZfmhIIASNFAR1A2qhjekiq2bfGlWrh06m+aFwo+GsrqXqBFqdYI+N/PGXam49mG2o3hs0VG4Gi76+Jhyy2MjSB1VoJBuYW+q/eZB/krSd9oO5Sv9EbcuXxVOl3A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742923147; c=relaxed/simple; bh=89snBsB9hv5wlyxcY5446+E9mav+e9ltF9Zpa/H/XPg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GCovE1O/PZL4o4Wrlhb5VU/K6a0HBksph48jy8dIuC2OG2Lb2ZsNsdksJ7aqTkilhirml5Nw8wCZZgKaAD8uEdc9tj1nqIUg6yrLvA+lVilsVhZdNe3J1f5k57m0M4eDuLCX1Nzi1dxU9JH3gTeQJ+FtP0uefaP5aL2U4+m/kwc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=siemens.com; spf=pass smtp.mailfrom=rts-flowmailer.siemens.com; dkim=pass (2048-bit key) header.d=siemens.com header.i=diogo.ivo@siemens.com header.b=FohdKXo1; arc=none smtp.client-ip=185.136.65.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=siemens.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rts-flowmailer.siemens.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=siemens.com header.i=diogo.ivo@siemens.com header.b="FohdKXo1" Received: by mta-65-225.siemens.flowmailer.net with ESMTPSA id 20250325171855fbf2bbfae7eda9b655 for ; Tue, 25 Mar 2025 18:18:55 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm2; d=siemens.com; i=diogo.ivo@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc:References:In-Reply-To; bh=QjB4n1CG5EJajMUvXPSpBjvTs6+Sq6WL3daydtuzFKg=; b=FohdKXo1wbpag0EuxImEwOgHoN3ANC9mC3AjpYk3r6eCB3TXgUt1AaNnHSe14b+QINXieV Hxj/LOWVtl4PF/1qjNe/wnRF2MS26XvXAzNAv6uP0vr9R/Xiz8CPGKWLGVSNoyIGo6KGNHyI DKSJqeIMN55rKf0Kq6jnfbcNTTf56Cx8JPPD6b1TuCniNn0k2NtwdPxBLMQpOhdMNg33Hnzn 4SIZ1SuWlwhYxKfQo231Ci+OLxplf4pBgqSlQUr8QgG1HUFBEN18uAqysm3xIE5Ye4oynq/5 OPMa2Z3hUqrkFS4JgDlNhEUxx82ciCDq1jDWovbxcDhGF8sagia3gJeQ==; Message-ID: <1beeb77c-83d6-4634-ba39-2b40efbb8437@siemens.com> Date: Tue, 25 Mar 2025 17:18:52 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v3 2/2] ACPI: PNP: Add Intel OC Watchdog IDs to non-PNP device list To: "Rafael J. Wysocki" , Len Brown , Wim Van Sebroeck , Guenter Roeck Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-watchdog@vger.kernel.org, jan.kiszka@siemens.com, benedikt.niedermayr@siemens.com References: <20250317-ivo-intel_oc_wdt-v3-0-32c396f4eefd@siemens.com> <20250317-ivo-intel_oc_wdt-v3-2-32c396f4eefd@siemens.com> Content-Language: en-US From: Diogo Ivo In-Reply-To: <20250317-ivo-intel_oc_wdt-v3-2-32c396f4eefd@siemens.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1328357:519-21489:flowmailer Hello, On 3/17/25 10:55 AM, Diogo Ivo wrote: > Intel Over-Clocking Watchdogs are described in ACPI tables by both the > generic PNP0C02 _CID and their ACPI _HID. The presence of the _CID then > causes the PNP scan handler to attach to the watchdog, preventing the > actual watchdog driver from binding. Address this by adding the ACPI > _HIDs to the list of non-PNP devices, so that the PNP scan handler is > bypassed. > > Note that these watchdogs can be described by multiple _HIDs for what > seems to be identical hardware. This commit is not a complete list of > all the possible watchdog ACPI _HIDs. > > Signed-off-by: Diogo Ivo > --- > v2->v3: > - Reword the commit message to clarify purpose of patch > --- > --- > drivers/acpi/acpi_pnp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/acpi/acpi_pnp.c b/drivers/acpi/acpi_pnp.c > index 01abf26764b00c86f938dea2ed138424f041f880..3f5a1840f573303c71f5d579e32963a5b29d2587 100644 > --- a/drivers/acpi/acpi_pnp.c > +++ b/drivers/acpi/acpi_pnp.c > @@ -355,8 +355,10 @@ static bool acpi_pnp_match(const char *idstr, const struct acpi_device_id **matc > * device represented by it. > */ > static const struct acpi_device_id acpi_nonpnp_device_ids[] = { > + {"INT3F0D"}, > {"INTC1080"}, > {"INTC1081"}, > + {"INTC1099"}, > {""}, > }; > > Gentle ping on this patch. Best regards, Diogo