From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4451FC433E1 for ; Fri, 21 Aug 2020 13:21:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22DEE20724 for ; Fri, 21 Aug 2020 13:21:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=agner.ch header.i=@agner.ch header.b="mKcMiFnb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728595AbgHUNVL (ORCPT ); Fri, 21 Aug 2020 09:21:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726975AbgHUNVJ (ORCPT ); Fri, 21 Aug 2020 09:21:09 -0400 Received: from mail.kmu-office.ch (mail.kmu-office.ch [IPv6:2a02:418:6a02::a2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A0CBC061573; Fri, 21 Aug 2020 06:21:09 -0700 (PDT) Received: from webmail.kmu-office.ch (unknown [IPv6:2a02:418:6a02::a3]) by mail.kmu-office.ch (Postfix) with ESMTPSA id 449775C0160; Fri, 21 Aug 2020 15:21:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1598016060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jAmn351OrHHZYEgU6zTRjzq0M49ckKbBSek16/Foebc=; b=mKcMiFnbPzsC8l9AFLdkncUV9EmSxcMITYQK9r8Mbook20kfNTEZhAmXrE/rB2GmTuYNog 4opHaOqUBdcKd5HT9d65OES7IknI6F77qRH604l5v04B6LM8tDr9Jedh5GgCk7i1F6n9Mn eXKlbEnYBy2ozI6ebEvEx28pmLwTem4= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Fri, 21 Aug 2020 15:20:59 +0200 From: Stefan Agner To: Chris Healy Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, robh+dt@kernel.org, andrew.smirnov@gmail.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, festevam@gmail.com, stable@vger.kernel.org Subject: Re: [PATCH v2] ARM: dts: vfxxx: Add syscon compatible with ocotp In-Reply-To: <20200820041055.75848-1-cphealy@gmail.com> References: <20200820041055.75848-1-cphealy@gmail.com> User-Agent: Roundcube Webmail/1.4.1 Message-ID: <1bf1c9664d8c376c87dc55aeb27da6e4@agner.ch> X-Sender: stefan@agner.ch Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-08-20 06:10, Chris Healy wrote: > From: Chris Healy > > Add syscon compatibility with Vybrid ocotp node. This is required to > access the UID. Hm, it seems today the SoC driver uses the specific compatible. It also should expose the UID as soc_id, see drivers/soc/imx/soc-imx.c. Maybe it does make sense exposing it as syscon, but then we should probably also adjust Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt. -- Stefan > > Fixes: fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP") > Cc: stable@vger.kernel.org > Signed-off-by: Chris Healy > --- > Changes in v2: > - Add Fixes line to commit message > > arch/arm/boot/dts/vfxxx.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi > index 0fe03aa0367f..2259d11af721 100644 > --- a/arch/arm/boot/dts/vfxxx.dtsi > +++ b/arch/arm/boot/dts/vfxxx.dtsi > @@ -495,7 +495,7 @@ edma1: dma-controller@40098000 { > }; > > ocotp: ocotp@400a5000 { > - compatible = "fsl,vf610-ocotp"; > + compatible = "fsl,vf610-ocotp", "syscon"; > reg = <0x400a5000 0x1000>; > clocks = <&clks VF610_CLK_OCOTP>; > };