From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753708AbdBIPb7 convert rfc822-to-8bit (ORCPT ); Thu, 9 Feb 2017 10:31:59 -0500 Received: from smtp.eu.citrix.com ([185.25.65.24]:25350 "EHLO SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751852AbdBIPbg (ORCPT ); Thu, 9 Feb 2017 10:31:36 -0500 X-IronPort-AV: E=Sophos;i="5.35,349,1484006400"; d="scan'208";a="40483590" From: Paul Durrant To: "'Boris Ostrovsky'" , Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Juergen Gross" , "linux-kernel@vger.kernel.org" Subject: RE: [Xen-devel] [PATCH 1/3] xen/privcmd: return -ENOSYS for unimplemented IOCTLs Thread-Topic: [Xen-devel] [PATCH 1/3] xen/privcmd: return -ENOSYS for unimplemented IOCTLs Thread-Index: AQHSgt9MYs/7vHIJ/km00S336FTY+6FgrlqAgAAM3ICAABDrAA== Date: Thu, 9 Feb 2017 15:28:54 +0000 Message-ID: <1bf3a822caf94d7a9e9afee86d5ec1b5@AMSPEX02CL03.citrite.net> References: <1486649866-4869-1-git-send-email-paul.durrant@citrix.com> <1486649866-4869-2-git-send-email-paul.durrant@citrix.com> <589C8D610200007800138429@prv-mh.provo.novell.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Boris Ostrovsky [mailto:boris.ostrovsky@oracle.com] > Sent: 09 February 2017 15:26 > To: Jan Beulich ; Paul Durrant > > Cc: xen-devel@lists.xenproject.org; Juergen Gross ; > linux-kernel@vger.kernel.org > Subject: Re: [Xen-devel] [PATCH 1/3] xen/privcmd: return -ENOSYS for > unimplemented IOCTLs > > > > On 02/09/2017 09:40 AM, Jan Beulich wrote: > >>>> On 09.02.17 at 15:17, wrote: > >> The code goes so far as to set the default return code to -ENOSYS but > >> then overrides this to -EINVAL in the switch() statement's default > >> case. > > > > If you already change this, isn't -ENOTTY the traditional way of > > indicating unsupported ioctls? > > In fact, a while ago David submitted a patch to do just that: > > https://lists.xenproject.org/archives/html/xen-devel/2016- > 08/msg00744.html > > but it never went anywhere. > > My question is whether anyone might be relying on current error return > behavior. I doubt it. It's certainly not a safe thing to do anyway. I'll change to -ENOTTY in v2 of the patch. Paul > > > -boris