From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752374AbdBOSun (ORCPT ); Wed, 15 Feb 2017 13:50:43 -0500 Received: from goliath.siemens.de ([192.35.17.28]:46883 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752043AbdBOSum (ORCPT ); Wed, 15 Feb 2017 13:50:42 -0500 Subject: Re: [PATCH 0/2] efi: Enhance capsule loader to support signed Quark images To: Andy Shevchenko References: Cc: Matt Fleming , Ard Biesheuvel , linux-efi@vger.kernel.org, Linux Kernel Mailing List From: Jan Kiszka Message-ID: <1bf3c9d8-56aa-818b-350f-deb62ad14e08@siemens.com> Date: Wed, 15 Feb 2017 19:50:38 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-02-15 19:46, Andy Shevchenko wrote: > On Wed, Feb 15, 2017 at 8:14 PM, Jan Kiszka wrote: >> See patch 2 for the background. >> >> Series has been tested on the Galileo Gen2, to exclude regressions, with >> a firmware.cap without security header and the SIMATIC IOT2040 which >> requires the header because of its mandatory secure boot. > > Briefly looking to the code it looks like a real hack. > Sorry, but it would be carefully (re-)designed. The interface that the firmware provides us? That should have been done differently, I agree, but I'm not too much into those firmware details, specifically when it comes to signatures. The Linux code was designed around that suboptimal situation. If there are better ideas, I'm all ears. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux