From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59651356772 for ; Mon, 24 Aug 2026 14:58:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787583530; cv=none; b=NudLtk+gIJ1VSxvlTRlLIuS5iUZ+tDXFsV5iSY1C9Xg7xZvAAlgIXJge6wgp/edLhznZ6f/FGxskml6ka/ZLKhxpFv0qfDhyuzBKTv1CrnT5+fKSoL+WuoQIfgE16CORXwU7z0amMDEitJNjPON3zrKERL06aE5e5I/luRBXn2Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787583530; c=relaxed/simple; bh=NCPpP0PSy+yn7AsopOYr6zL63Fogw6eZBkjtUu0ajkQ=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=p5NgOYqvYjuG5tObVkGYHtyzzF+F0iMUsuj7G6qzff2zdJVMW8aiPymIMs+tPubH1qga2iOMK3hX0RkMA8AnvCFirkfEao6TdV8K1oybAdF+HfhXm6Al38T7llyliDy8pUMLpLr4s9ZMJttG7ArDP0F9uneCroLQn9D0UAQp/iw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eHIsnj/y; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MdFSK9rC; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eHIsnj/y"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MdFSK9rC" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67OCvFro2579541 for ; Mon, 24 Aug 2026 14:58:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JFxHaff8GjmyQ0vJusoYBKz8T8A+c6M4ZjObeJKGagM=; b=eHIsnj/yq5JMQ2R+ dNhTfIz13oV7n3oaDZKdBTdgJbgt7jSIMcsWGDWO/D2aoncgB6DrtEz43kHfdB8E IFL9ar0NnPKdT9aSnhppfTJK+ajptnbjmouPYeDgNbJrysQQISoeM95kkTHZCJZo 8BNwjOxT3RtaJUbVe74MevZ3LHysqf1H/vnGjVqCMpBOZ74allL+uBGsjFJluz29 MSm0ps+P9Un3rtN4/BiZiqDg78n/LQS7UbwJWR/RgLYU57lpgJqcOdMzHXeX8U1x qKU/Cqo8sux73oofpWTscX8fY6CVv20KyevS7oYmtbZwYUIta853r3iCFVa+eROZ jxEt8Q== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g8gdsj8ed-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 24 Aug 2026 14:58:46 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-5283df62d68so47394661cf.0 for ; Mon, 24 Aug 2026 07:58:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787583526; x=1788188326; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=JFxHaff8GjmyQ0vJusoYBKz8T8A+c6M4ZjObeJKGagM=; b=MdFSK9rCDwYFPx+YtGIoYhgmehpv8JItkQ64hecTHY9iIZczI/sTtzshYAceuSWDVS vDGAMb5/gDICKpXj6euRuZe4gMK3ueW+5e8Sdk22pwNIZoGCJtBemiipRKYt3KlB6c6l KPA6bYnuf4W575YgnZxqcBqYsmCiUXHQPZ1sHLVR7YTKt2qqCR1r5fjwcxMQkRlnOwIe Yx6S/wA6SUWDHNb3L2j6eM6CAkCRBW4tum1jH3KpGyoqkwyqokEVD2kl7NKLRZapiD4c s2y0Q/cOa8NPaRdYh6vd3llqTct3ywty4DB/uirhi0CjhbXxu9zlaa8k6lytIULmZXlw FWFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787583526; x=1788188326; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JFxHaff8GjmyQ0vJusoYBKz8T8A+c6M4ZjObeJKGagM=; b=K9rps5ZL24dAGwmzLX2r9Flb5BZ7aJ3/KNQG0hUkb5/KdMGhdz2zy/Rn6gticDrMjs xe8L83ESITZ4CtakewD1CbsfoCsXapbt964d5YfHbch3RoNtmhEnD6uI2/pF4jSva8sR 3YYDZkWg8yNE1GP9zlr3o9h1+hkI9CqaV1QWqEICpPteTrhQYYD0BeXA5AJ4E2ikhhxz KzIjySo7zR8kD3eMk/DzM/m3BfMvggTM6MEx244DiJduDnekCuIUvLsgwBbXtQc9fMbH 21ZXDXwtRW8N+8gcsOKo8QeW3j0uLXBkfqHabO9+fri26Klpymf2aC6RZmnHQijVD3R/ m7AQ== X-Forwarded-Encrypted: i=1; AHgh+Rpu8vnQiwuB4fWOT9EUlFwSNt7chh8kdUQPRYp9vsdy0qi3WakR2i9Dx5jTOVhunXXBYItZQKYo4m/8364=@vger.kernel.org X-Gm-Message-State: AFuF++mL9KzashPeOBY4S9ngpMAP6ReBjL8uQNCat/DzJD3cez54qlkH byjq4GD1D9ThJJv/tq+s0hp/EBEC1zXKUEPdRYhzKRsBlLl9Hmw0Rmh9FgWXjAGC5gIsGHUB4Vf mmj3f1xY49uw5qJbe/0h/X5ObJWlYOiaRFwi3ByP9iQkNZxacDwm+r22NvY9UVIZ5e7E= X-Gm-Gg: AR+sD126TrSpqRbn4LXZcEYJF/10m1j+1ob31IxS3XBo6Ymu0JR5tBvTDFnsmW20eXW 2fAmS3u+7EwnBWfeZ5MGDOlUQWYoRmWKAFLJI17ZGGJDoRgS0Iqbdvkl46lLuVPMF+7fM0tD0DI 5Pk/JKAylOKMqfuoLV7NHxyiNituH/e6X3snibEgvq0YIuvboDgFYjJevU/SZuIf6ZKB/fcrJ46 a2y1g7WWC4gPp0zsdgTC1jTaWKCyh3gc+xrK5Q1O+yC3VPfSKobsn52bhEnYhGCY/KRHHuw9FLu KLxn+mPsQ+o8jhP22WbsCY9ew9pB3+AO+Yn5mXi1JZ3OUAz8d83dCYT/6fwEXRQ1SjtlaLqILL0 DaPU9fekWtNKWRV7YhvmeEZrVHggFF7ttytRaEUB7i7f/dRNI/qJ1UNTQuYAtc5SesUBI/AjI/3 amaM0Tn+GxrHFXzYjOBZFFyXUQMNQVYRuHX7SesZh735K3kKyVWCLl0XW/BV3I9x3srKQ= X-Received: by 2002:a05:622a:c85:b0:527:f4d0:4bb8 with SMTP id d75a77b69052e-52df5a3285cmr289911521cf.22.1787583526030; Mon, 24 Aug 2026 07:58:46 -0700 (PDT) X-Received: by 2002:a05:622a:c85:b0:527:f4d0:4bb8 with SMTP id d75a77b69052e-52df5a3285cmr289910721cf.22.1787583525431; Mon, 24 Aug 2026 07:58:45 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2496295627sm1253359466b.15.2026.08.24.07.58.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2026 07:58:44 -0700 (PDT) Message-ID: <1bf5984a-d1d2-4763-bb4c-b17ae8360192@oss.qualcomm.com> Date: Mon, 24 Aug 2026 16:58:43 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Hans de Goede Subject: Re: [PATCH v3 1/3] module: add SCMI device table alias support To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= Cc: Bjorn Andersson , Cristian Marussi , Sudeep Holla , Daniel Lezcano , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, Bjorn Andersson References: <20260820194850.459739-1-johannes.goede@oss.qualcomm.com> <20260820194850.459739-2-johannes.goede@oss.qualcomm.com> Content-Language: en-US, nl In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: i8VrbgY1R5Id6zMyy2O651pAjDIV2W6i X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI0MDEyNiBTYWx0ZWRfX0qSmq00A1sUl c6xCbg9zNV8g4VceM01kV33IXx4Uaj1P9qla9IEqwvun6ws+Z0ZJEDr9pi4yeJ0Cu5RCb9dhakv SoGu9tedgzOW7uktHyK9h5EZyGhx7KWssGF6PfMgbVMJ5yTRjSApi9otmVLcFwT5qhqzjWFCQMh DQB2MTr1WcUNQpvxxM2BE8NvMnuxJqwUkidJWBljw4pLVlfW3yDumVS2XhjlsDdgdSKZEH6lyIv +PrTf7S2bWxDJ4dGb7C2tVziiJbf+Psh0IyubMHrHe4EzGl84dgFIx0kkBFRRtk3wjODgOFJeRh 2aI2s14cJYvykh26/7Mp8WFc5Hu2iRbn5Bl/byyZyW8S3OIrpqZdWG+Qu4HdcdyxYfTqE3KbmIY Ew8nl09e8w5cMZWxQNbSN7K7kt7xQTTAmkT9AXpie+K10Xxj5oWn9Cna3Sh1tYLvyI46i5hc/0D qYtZdVvOEVhGGYMn4wA== X-Authority-Analysis: v=2.4 cv=Fqo1OWrq c=1 sm=1 tr=0 ts=6a8c5c26 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=IpJZQVW2AAAA:8 a=OCaCXozdqvtwCLTCMOQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=IawgGOuG5U0WyFbmm1f5:22 X-Proofpoint-ORIG-GUID: i8VrbgY1R5Id6zMyy2O651pAjDIV2W6i X-Proofpoint-Spam-Info: AW1haW4tMjYwODI0MDEyNiBTYWx0ZWRfX+vn57LNrN9lB aGmUuKlJfhgGHuH7LGIRoU7W7U1Fxf7PxtE/du91TJPKNu7qk32NMCIHOZ3OOUCPVXDTMauVuvN JOTbjQJlUIyLzRERgoM8XW/qB9pi78s= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-24_04,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 phishscore=0 spamscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608240126 Hi Uwe, On 24-Aug-26 14:22, Uwe Kleine-König wrote: > Hello, > > I just replied to v2 and only then found out there is a v3 already. > There is something wrong with my mail filtering, sorry. Not sure if it is your filtering, v2 is somewhat old and I only just revived this series. I'll add you to the Cc list for v4. > I'm forwarding my review comments to here (the part that still applies). > > On Thu, Aug 20, 2026 at 09:48:48PM +0200, Hans de Goede wrote: >> diff --git a/include/linux/device-id/scmi.h b/include/linux/device-id/scmi.h >> new file mode 100644 >> index 000000000000..4150481524d4 >> --- /dev/null >> +++ b/include/linux/device-id/scmi.h >> @@ -0,0 +1,19 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +#ifndef LINUX_DEVICE_ID_SCMI_H >> +#define LINUX_DEVICE_ID_SCMI_H >> + >> +#ifdef __KERNEL__ >> +#include >> +typedef unsigned long kernel_ulong_t; >> +#endif >> + >> +#define SCMI_NAME_SIZE 32 >> +#define SCMI_MODULE_PREFIX "scmi:" >> + >> +struct scmi_device_id { >> + __u8 protocol_id; >> + char name[SCMI_NAME_SIZE]; >> + kernel_ulong_t driver_data; > > Please use > > union { > kernel_ulong_t driver_data; > const void *driver_data_ptr; > }; > > here instead of the plain driver_data member (or don't add driver_data > at all if not needed). This yields better type-safety, see e.g. > https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylibre.com > for an extended explanation. Ack, I'll check if driver_data is used at all. > >> +}; >> + >> +#endif /* ifndef LINUX_DEVICE_ID_SCMI_H */ >> diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h >> index a397213bedac..d241421c36aa 100644 >> --- a/include/linux/mod_devicetable.h >> +++ b/include/linux/mod_devicetable.h >> @@ -49,6 +49,7 @@ >> #include "device-id/pnp.h" >> #include "device-id/rio.h" >> #include "device-id/rpmsg.h" >> +#include "device-id/scmi.h" > > Please don't add new includes to mod_devicetable.h. That header is ugly > and each include makes it worse. Just add to > the modpost source. Hmm, I did that at first, but that is quite ugly also because file2alias.c, does: #include "../../include/linux/mod_devicetable.h" So I ended up needing to change that to: #include "../../include/linux/device-id/scmi.h" #include "../../include/linux/mod_devicetable.h" my thinking was that the purpose would be to move other consumers of mod_devicetable.h to directly include linux/device-id/*.h" And keep mod_devicetable.h as a file which includes all of them for use in devicetable-offsets.c + file2alias.c But I can see how actually getting there will be a long time in the making and in the mean time this will cause longer compile times. So if you're saying the somewhat ugly thing of adding linux/device-id/scmi.h directly to devicetable-offsets.c + file2alias.c is the right thing to do, then I'm happy to do that for v4. If I'm reading your comment correctly, that is what you want me to do, right ? Regards, Hans