mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: guoren@kernel.org
Cc: linux-csky@vger.kernel.org, linux-kernel@vger.kernel.org,
	arnd@arndb.de, linux-arch@vger.kernel.org
Subject: Re: [PATCH] csky: Remove compile warning for CONFIG_SMP
Date: Sun, 19 Oct 2025 14:59:41 -0700	[thread overview]
Message-ID: <1bf734c8-ca29-4ed6-a10a-9595b2c844b8@infradead.org> (raw)
In-Reply-To: <20251019110214.3392011-1-guoren@kernel.org>



On 10/19/25 4:02 AM, guoren@kernel.org wrote:
> From: "Guo Ren (Alibaba DAMO Academy)" <guoren@kernel.org>
> 
> When CONFIG_SMP is enabled, there is a compile warning:
> 
> arch/csky/kernel/smp.c:242:6: warning: no previous prototype for
> 'csky_start_secondary' [-Wmissing-prototypes]
>   242 | void csky_start_secondary(void)
>       |      ^~~~~~~~~~~~~~~~~~~~
> 
> Add a similar prototype with csky_start in sections.h.
> 
> Signed-off-by: Guo Ren (Alibaba DAMO Academy) <guoren@kernel.org>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  arch/csky/include/asm/sections.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/csky/include/asm/sections.h b/arch/csky/include/asm/sections.h
> index 83e82b7c0f6c..ee5cdf226a9b 100644
> --- a/arch/csky/include/asm/sections.h
> +++ b/arch/csky/include/asm/sections.h
> @@ -8,5 +8,6 @@
>  extern char _start[];
>  
>  asmlinkage void csky_start(unsigned int unused, void *dtb_start);
> +asmlinkage void csky_start_secondary(void);
>  
>  #endif /* __ASM_SECTIONS_H */

-- 
~Randy

      reply	other threads:[~2025-10-19 21:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-19 11:02 guoren
2025-10-19 21:59 ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1bf734c8-ca29-4ed6-a10a-9595b2c844b8@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=arnd@arndb.de \
    --cc=guoren@kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-csky@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®