From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938645AbdEYPxg (ORCPT ); Thu, 25 May 2017 11:53:36 -0400 Received: from ale.deltatee.com ([207.54.116.67]:39706 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750979AbdEYPxd (ORCPT ); Thu, 25 May 2017 11:53:33 -0400 To: Richard Weinberger , linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net References: <1495726955-27497-1-git-send-email-logang@deltatee.com> <3c36765c-9e23-7947-b6d9-29ca892bd348@nod.at> Cc: Stephen Bates , Jeff Dike , Al Viro , Arnd Bergmann From: Logan Gunthorpe Message-ID: <1bffdbbd-a317-d9a3-88d2-d02501d2fae1@deltatee.com> Date: Thu, 25 May 2017 09:53:17 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <3c36765c-9e23-7947-b6d9-29ca892bd348@nod.at> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.111 X-SA-Exim-Rcpt-To: arnd@arndb.de, viro@ZenIV.linux.org.uk, jdike@addtoit.com, sbates@raithlin.com, user-mode-linux-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, richard@nod.at X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v2] um: add dummy ioremap and iounmap functions X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/05/17 09:48 AM, Richard Weinberger wrote: > Which ones are failing? > I thought we killed the problem by making CONFIG_COMPILE_TEST depend on !UML. None, at the moment. My work is trying to add iomem support to scatter lists and thus I want to call ioremap in scatterlist.c. That's when things fail to build. We could put an '#ifdef HAS_IOMEM' around only the uses, but I thought this approach was cleaner. However, if people would rather I do that, let me know and I will. > I was never a fan of that approach because in my opinion drivers should have > proper dependencies, including a dependency on HAS_IOMEM. This doesn't really work when we try to use it in a core library which can't depend on HAS_IOMEM. Thanks, Logan