From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 679C23A2561 for ; Tue, 7 Apr 2026 07:44:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775547875; cv=none; b=eL6vRtXGKTL4lye8GhfqcRnr4jR4AQhLc0Pq9LZTP1b5kbE0Hz/GHZSZGrKmPBWWToEpU4HIBq+Ip/9Cr8XlZerF5RG9YWKVtTdbfoZOa4Ku05ImA5NZfwUuE1gkVtNQdyYYyZ63W7F0CdOqFZLQb1x7GJ9wdDIm1suOA+D5MtE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775547875; c=relaxed/simple; bh=TtQ2MoFhsj1eMx8EKga1m16wlCou6PY4GB4O5Mf8/p8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cNWE3iGo9goJULUYdCcVQN6hccmeNBMPvJH/MCn0L7uJmAYMy6Hd3chDz2DfEdCnF3iTAIdd/i/rRyy4nknYu2OakFFIGlnFTiSl4HdNXTPgyrGQDyGpbOIOCL6rHr70e/OIYa3u9otzWH4ARi+I0+ghGbpPsC3FodrWKO9sA3s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=etlklusU; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=gNro/QxG; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Vo3DPtSp; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=+uieejM3; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="etlklusU"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="gNro/QxG"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Vo3DPtSp"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="+uieejM3" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C46274E33A; Tue, 7 Apr 2026 07:44:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775547871; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yqD5BNJKSzz2RDsjvgTodDbBgNJ9N74Q6xZe9G5Xpmg=; b=etlklusU3PcsRKEDccOlvFzorLJ0Y/QTs/9pJdvohAvluwbiww6r63SYpqnJ3RcrN0DqFM S+vOY25BbogqlWJjpQXRDSK5kmvcloj72xhKn3fm1cm3VQt9wDgZbPy4RC7CBfUOX2t9kD 9yN59U9h3/76P1ApjMYhX8ufRlcjAfc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775547871; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yqD5BNJKSzz2RDsjvgTodDbBgNJ9N74Q6xZe9G5Xpmg=; b=gNro/QxGbPJaKyq7DQlTYJ41So1TLeqGEh1rEYMW0a8HQQ0b7Z5Q1+haolvreBG+R3bnH3 tqnqSTLmk5maCwDg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Vo3DPtSp; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=+uieejM3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775547870; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yqD5BNJKSzz2RDsjvgTodDbBgNJ9N74Q6xZe9G5Xpmg=; b=Vo3DPtSp65FwT3LporU/SF2Q871balqNkmCzR5i1aLSmtXbP8z6njIOb+cOwjqp+gj57bN X1gPxjDfMSnvZ+AkXhDmO2lTCZkhUbqb/k97FHgTXQF/U/1nT4y1BND06ZqW1l8alw1o4v 88tIWQrEb0jgF8JE7Hcja27Xu/+Cr5U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775547870; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yqD5BNJKSzz2RDsjvgTodDbBgNJ9N74Q6xZe9G5Xpmg=; b=+uieejM3T4fIOmunpyRdVbcA1yuNLMf08imJiP9TKFHkPNwUc7XZtBR3Pjj8BYVQWp0BqJ StREsAGja/jDNNAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 85F834A0B0; Tue, 7 Apr 2026 07:44:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id LnZ8H9611Gn0aQAAD6G6ig (envelope-from ); Tue, 07 Apr 2026 07:44:30 +0000 Message-ID: <1c03e4d8-0eac-4863-a18d-1ea750c853fb@suse.de> Date: Tue, 7 Apr 2026 09:44:30 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/fb-helper: Fix a locking bug in an error path To: Bart Van Assche , Maarten Lankhorst Cc: Maxime Ripard , linux-kernel@vger.kernel.org, =?UTF-8?Q?Christian_K=C3=B6nig?= , Dmitry Baryshkov , Javier Martinez Canillas , David Airlie , Simona Vetter , Nathan Chancellor References: <20260403205355.1181984-1-bvanassche@acm.org> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20260403205355.1181984-1-bvanassche@acm.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[kernel.org,vger.kernel.org,amd.com,oss.qualcomm.com,redhat.com,gmail.com,ffwll.ch]; RCPT_COUNT_SEVEN(0.00)[10]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,suse.com:url,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: C46274E33A X-Spam-Flag: NO X-Spam-Score: -4.51 X-Spam-Level: Hi Am 03.04.26 um 22:53 schrieb Bart Van Assche: > The name of the function __drm_fb_helper_initial_config_and_unlock() and > also the comment above that function make it clear that all code paths > in this function should unlock fb_helper->lock before returning. Add a > mutex_unlock() call in the only code path where it is missing. This has > been detected by the Clang thread-safety analyzer. > > Cc: Thomas Zimmermann > Cc: Christian König # radeon > Cc: Dmitry Baryshkov # msm > Cc: Javier Martinez Canillas > Fixes: 63c971af4036 ("drm/fb-helper: Allocate and release fb_info in single place") > Signed-off-by: Bart Van Assche Reviewed-by: Thomas Zimmermann Thanks a lot. Best regards Thomas > --- > drivers/gpu/drm/drm_fb_helper.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > index 05803169bed5..16bfbfb0af16 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -1641,8 +1641,10 @@ __drm_fb_helper_initial_config_and_unlock(struct drm_fb_helper *fb_helper) > drm_client_modeset_probe(&fb_helper->client, width, height); > > info = drm_fb_helper_alloc_info(fb_helper); > - if (IS_ERR(info)) > + if (IS_ERR(info)) { > + mutex_unlock(&fb_helper->lock); > return PTR_ERR(info); > + } > > ret = drm_fb_helper_single_fb_probe(fb_helper); > if (ret < 0) { -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)