From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0041E2F7F0F for ; Tue, 19 May 2026 04:04:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779163474; cv=none; b=VyJtetijYzPib7FGqsjk2pPCW0s1jR460Kub5C8JFa6BA33eHPBFl+xx7/vOZT2Lyc7iHGYL1SqlaZiD3cGozfni1joHrkkpc3xxM3UaJYthUflkl4qoW3GZA5aKXdqEYA22pSCZijDK6RZ3OjeNIm8kv3+RnsuqGVRnlDkBF8w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779163474; c=relaxed/simple; bh=3r0KXIvqch/qW3DQWjqE3BQuHzdblo4BIE5pGliJ9ls=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z8x8mGWlDc1OGqHJGCCZSJCr9OvcFQ04MTPHLCRImlZV1jfB4eqLHBlsRBcYdrJm8TrHCXQ98tnJkFSo380v93E2+J9yFDbdXU9ct0/pVg83EyXBN3Fz0Xv1T7TldhI9/T+8CuB9MVpRut2s4nZ2qnqCxNC9jamH6+T3uVJpkag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IC7Pgm1J; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jJBRaieD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IC7Pgm1J"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jJBRaieD" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64IIvT4c2482391 for ; Tue, 19 May 2026 04:04:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xS9AYhs6BDbjLLGh5V14QRqWR+Wq85qVhy1t5hgItDs=; b=IC7Pgm1JUgS9jXP/ 8f9VWCI2RJ701EscmlDPM/6Q2kHZTk8CImVS3tyRyvEi6A6bFriq3Ufyqqa3yJ+E /vUdWplIeQ8h0NI6aluja2uG0vGhgIreQ0rJHxDVQ/kSmpcTWk5bv//J1KBetI64 fdpRh4tLLBNTY2lQ+GCE3AAR+QA26RY5ujA520t4D8cR/MYV+y20j944cLQ0yw2s MLU17Fkm3snvJjVeRwyKR4M4lEnE7HzV6/rsIhpHMO1unW0BcMyhrxH8E4QzcVPd Bwj00QScAUnNAVb+y4KWiYsmAzM0N6QZis77+2wc7zTsuxNKaFTRkkYcB7iozbS3 TtXPBA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e81rvk8v1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 19 May 2026 04:04:31 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-368f2d76b04so2870399a91.3 for ; Mon, 18 May 2026 21:04:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779163471; x=1779768271; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xS9AYhs6BDbjLLGh5V14QRqWR+Wq85qVhy1t5hgItDs=; b=jJBRaieD5OVgvQZcF/6WWSFKvxEg3tjyqdolfCxewDmNuVRhY9nkqqu7Vhc4CjY/V1 ewmjBRrGCv/jCowX9WhITIT7jyEXZnAuHCpn8Go/Bu2JdgYgSiBmBxnVu2L5jgBaOA5W uLaezOTFQyajCoTiwc9zMLLjCHR33mW5zuCUDeKCPQ9Q8VK4bHfbuipalDRd5ELqPXn2 uLU+Is1/WINGLKlzONhucsJSohiUf3DNOiJ+NBY41SdnmcqKZ5GEE3Bg5dJPr+lW/Pv3 /dX08RetBlK2CmA6o2cdpD9dvO6NaUQ2S/gDyZKdBx0SdXy7myoN0mdqv/7r4VUvIwO0 pHZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779163471; x=1779768271; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xS9AYhs6BDbjLLGh5V14QRqWR+Wq85qVhy1t5hgItDs=; b=Vi7uWByz1roh8VeTg1lWgJ5EVo8FGGtJfThmhlrxgUQTox1ChStyMh6aX/pEkJk6WA 73AWGJVqac+WLH/YAOWM2m1w+KCcxnyG8oWHjONXdS9UqXDZkmP3S/jT/7k4KRCv5pYr g0/AuBghzVSF5xmG+UtDpU7PUP0PCw68CsUriuhbezi6DavE3Eu0QlT9z28yJFFTwm4l sa0YyM1xAc6WhNuGSX4KagjxTKydbfkUfmwBLsahilvX8nAo7uuoccThYzxpXz1WKu7e YklawMkikADZIJsVFSAwetv+oOW09sbAMDOH8EBeDerpV3CR9TyOlS7yWI8EtNCFeSXS iBoQ== X-Forwarded-Encrypted: i=1; AFNElJ+ImQ0l05KYURy1M00ICHh9TH6nZqcLQ2qGuuoNFJ7O8x9ap+Nym6Mv5pCcu6tUvMocYesT+bm4EetGenY=@vger.kernel.org X-Gm-Message-State: AOJu0YwQ2xYqEX6Hksy02ueicNyv1Wpy/5Z8OXdT1tB+nTI34vdtSUpN 5S8wz9846HgmhFbzK8keUCMad4P7i/TPhYE/mpRXsAh9hWD/hGjg6c7uWnctVlrppqD1di7dq3q ebmclwRN1QdDX4IQXtr+KEKnnM22YWPuMUC5Udcs3Drrjrs6QK7tI0tvJPfwV9H1+p3w= X-Gm-Gg: Acq92OFv+J3wtFtfKArY7NS9trvt5u2rk1xQockoo2T6+kRQGam/EQ3psw91FhfivtQ VNlcOxQbebcMdKFnPgIEoTjDX+0Uw8B48+cUQZt9O0t26FDfH1KHW18vUjVq17VQ3T9PZkBqPN4 /TxyfQ5ItABvSEFT//p++mNdnwvHT74ahIZqG9CgEHQs4XUDGmYwZeW1HGyiZoKTrpIVKkz8I/Q yShDuDUaO6YVijNd2LCfFJpCFe05tA4I2VeXnOSZyAyLU7TSzg3Z23K3kkPBdsTbztonhDPRG3g 5fVKDUIxlyhsQvty46PXBjB5GnYMXYaZqj2asdW4ZaYtAAL6teFkgngHBKsc7fVkKW+Y7n6H8c0 kbjPltXOHknlTrUmnCNrvSUNEUQm6gLlMJyueeQIZPxau2Zov X-Received: by 2002:a17:90b:314a:b0:366:3517:1a95 with SMTP id 98e67ed59e1d1-3695173c0cfmr16415389a91.0.1779163470848; Mon, 18 May 2026 21:04:30 -0700 (PDT) X-Received: by 2002:a17:90b:314a:b0:366:3517:1a95 with SMTP id 98e67ed59e1d1-3695173c0cfmr16415358a91.0.1779163470352; Mon, 18 May 2026 21:04:30 -0700 (PDT) Received: from [10.218.5.114] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-369703bcc91sm4924387a91.3.2026.05.18.21.04.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 21:04:29 -0700 (PDT) Message-ID: <1c0bb8ff-eaca-4779-9b2f-4d564abd8670@oss.qualcomm.com> Date: Tue, 19 May 2026 09:34:09 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] clk: qcom: Add support for Display Clock Controller on Shikra To: Dmitry Baryshkov , Konrad Dybcio Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Ajit Pandey , Taniya Das , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260513-shikra-dispcc-gpucc-v1-0-5fd673146ab2@oss.qualcomm.com> <20260513-shikra-dispcc-gpucc-v1-3-5fd673146ab2@oss.qualcomm.com> <1cf064d0-14b9-489f-964f-614aeed4fcbd@oss.qualcomm.com> Content-Language: en-US From: Imran Shaik In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE5MDAzNSBTYWx0ZWRfXzsVmn7932DqQ LunGyc/105aJh+IIqFe2aW9MDUo6gm9DBly6QX0rmKhbAr718xCSD7nWX6aqWezPut5tEkXB2M/ Fv6csFk53eJT16ybufOdcU+4afJx4ddxeZnXRKpQwfF4pmPS1JSxs/9pifbiU8m9lAoI07lhWaU /o4qjRJXJ9tmhCSKvG1OtyExFEiwWeYZvIM7OEe0UoD5dsQq6hevuuHHdHxf523vHaO0qkAHBGG xOOD2P9NqANCA6AL63HtqIFgzyed5fulQXHrnn7AwrqNzUluLBxv12g7JtGqxp1+Ad+xfh6940j +dqp2oPNKQx0vPOJfdsnmqVLHct4umN2RIun2z5XLk1N9lDcr09AUE7WkHdFyU4XWb4IuMZ43fT JSfgvS83fDe8NZpX0ZEmwxypYhutXR6vHUl536xIi40nP7KfiW2gQo7YmQdNMUNcK0cDVIBCl1K 5iFqoclajfoe0hs/XeA== X-Proofpoint-GUID: CWTrSn0wIbTh-cvzYVMKblB5guPauNQV X-Proofpoint-ORIG-GUID: CWTrSn0wIbTh-cvzYVMKblB5guPauNQV X-Authority-Analysis: v=2.4 cv=Lf0MLDfi c=1 sm=1 tr=0 ts=6a0be14f cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=LhgfjC5gSqSb7UNhMDMA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-19_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 adultscore=0 clxscore=1015 impostorscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605190035 On 13-05-2026 08:38 pm, Dmitry Baryshkov wrote: > On Wed, May 13, 2026 at 04:51:03PM +0200, Konrad Dybcio wrote: >> On 5/13/26 4:06 PM, Dmitry Baryshkov wrote: >>> On Wed, May 13, 2026 at 05:01:16PM +0300, Dmitry Baryshkov wrote: >>>> On Wed, May 13, 2026 at 07:10:38PM +0530, Imran Shaik wrote: >>>>> Add a driver for the Display clock controller on Qualcomm Shikra SoC. >>>>> >>>>> Signed-off-by: Imran Shaik >>>>> --- >>>>> drivers/clk/qcom/Kconfig | 10 + >>>>> drivers/clk/qcom/Makefile | 1 + >>>>> drivers/clk/qcom/dispcc-shikra.c | 565 +++++++++++++++++++++++++++++++++++++++ >>>>> 3 files changed, 576 insertions(+) >>>>> >>>> >>>> Reviewed-by: Dmitry Baryshkov >>> >>> After comparing the files... >>> >>> Can we use dispcc-qcm2290.c instead? It uses clock-names instead of >>> clock-indices, but I think it should be fine to use clock-names as a >>> one-off. >> >> Or we can convert it to use indices, since those are stable for agatti >> too - the names would remain in the binding, just unused by the driver > > Either is fine for me. > Hi, In Agatti, apart from the clock-names difference, I see that the AHB/XO clocks are not handled as always-on via the probe and instead rely on pm_clk style handling, whereas Shikra follows the newer pattern by marking required CBCRs as critical during probe. I think that attempting to modify this approach into Agatti may introduce unnecessary complexity. And the Agatti DISPCC doesn't have the DT_DSI1 bindings exposed, and updating this might break the ABI with respect to bindings, and DT. Given these and considering that Agatti is already stable, keeping the Shikra as separate GPUCC/DISPCC drivers is better to avoid the risk of regressions and complexity. Please let know your thoughts on this. Thanks, Imran