From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40918C4363D for ; Thu, 24 Sep 2020 13:04:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0D702220D for ; Thu, 24 Sep 2020 13:04:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727876AbgIXNEz convert rfc822-to-8bit (ORCPT ); Thu, 24 Sep 2020 09:04:55 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:3530 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727704AbgIXNEz (ORCPT ); Thu, 24 Sep 2020 09:04:55 -0400 Received: from dggeme701-chm.china.huawei.com (unknown [172.30.72.56]) by Forcepoint Email with ESMTP id E7CCCB2F1CEAC7D79E4E; Thu, 24 Sep 2020 21:04:52 +0800 (CST) Received: from dggeme753-chm.china.huawei.com (10.3.19.99) by dggeme701-chm.china.huawei.com (10.1.199.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Thu, 24 Sep 2020 21:04:52 +0800 Received: from dggeme753-chm.china.huawei.com ([10.7.64.70]) by dggeme753-chm.china.huawei.com ([10.7.64.70]) with mapi id 15.01.1913.007; Thu, 24 Sep 2020 21:04:52 +0800 From: linmiaohe To: "mingo@redhat.com" , "peterz@infradead.org" , "juri.lelli@redhat.com" , "vincent.guittot@linaro.org" , "dietmar.eggemann@arm.com" , "rostedt@goodmis.org" , "bsegall@google.com" , "mgorman@suse.de" CC: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] sched: Fix some comments Thread-Topic: [PATCH] sched: Fix some comments Thread-Index: AdaScyyy92CiHjWDS6iDdISEJA8IGw== Date: Thu, 24 Sep 2020 13:04:52 +0000 Message-ID: <1c13c996946449f58d607e7a94c54a93@huawei.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.176.109] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Friendly ping. :) > Since commit dfa50b605c2a ("sched: Make finish_task_switch() return 'struct rq *'"), prev == current is incorrect in finish_task_switch(). Also fix a typo in the comment of struct dl_bandwidth. > > Signed-off-by: Miaohe Lin > --- > kernel/sched/core.c | 4 ++-- > kernel/sched/sched.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 8471a0f7eb32..725ccab230da 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -3571,8 +3571,8 @@ prepare_task_switch(struct rq *rq, struct task_struct *prev, > * > * The context switch have flipped the stack from under us and restored the > * local variables which were saved when this task called schedule() in the > - * past. prev == current is still correct but we need to recalculate this_rq > - * because prev may have moved to another CPU. > + * past. We need to recalculate this_rq because prev may have moved to > + * another CPU. > */ > static struct rq *finish_task_switch(struct task_struct *prev) > __releases(rq->lock) > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 28709f6b0975..1d7e45f7fbb9 100644 > --- a/kernel/sched/sched.h > +++ b/kernel/sched/sched.h > @@ -278,7 +278,7 @@ void __dl_clear_params(struct task_struct *p); > * consume bandwidth on the CPU they're running on. > * Finally, dl_total_bw_cpu is used to cache the index of dl_total_bw > * that will be shown the next time the proc or cgroup controls will > - * be red. It on its turn can be changed by writing on its own > + * be read. It on its turn can be changed by writing on its own > * control. > */ > struct dl_bandwidth { > -- > 2.19.1 >