From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B399C33F58D for ; Wed, 22 Apr 2026 09:19:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776849593; cv=none; b=OExd7roayeHGAxDotyaNy+9vczv063PMippPSprpgwh8To4n/a5N/az2VJuixnfmdEyDrgXOkQvulqqO8su2cTG/pxIF6LwkCCejbhMT+uVeKuAktPUMeLgVN+Y+9i5QcrF0zNJROinnQv6z2SLBMl2ug7c3AmD6vQvJor4bSf8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776849593; c=relaxed/simple; bh=OU16C1HTkym3IfdB5lCI8qt7OkcoXSWAACgHpoU/kWk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Xr0+9PjFAaEnyCx8IN12jiwFMUxqI6N+lFq2hGuZ9Q9W36FKUHVwvxGDI0RZfACXJEYG5dK00z9MkULSXjZ1A5Pbz3qsBeDNg8T3gR5oZd4gmr2/1EK+H29BhCJlHaaj1Qt3m1Q4J54acHh2h/neeq08cafXzFKVZxqllnyJNS4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Y9OyY0gT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WSSlt8Ft; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Y9OyY0gT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WSSlt8Ft" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63M4glpt4051048 for ; Wed, 22 Apr 2026 09:19:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4E0FN1Yk5HSKpQZofTPLB9G3h9HECmMhC7Z9bAGYFWM=; b=Y9OyY0gT0qLZT926 6Mq7+swrv0pW3UgK0IgYfWrKclYYHIC9DkmXzjWSYpo4fP+aIWMY75tB5ZXPQ8oK ESIOhmRaorj1ygbFhf6Xd5eHE5A/gdXAdfxwbAvsHjh2om9UHfPa810wc/n2Q/T0 CQny4oxGtiMxflD16R2l9yxxISIKkgGK3atWlY3/ttr+uPfiMeA7Unzn3FlnjLe1 zYxSsazuMJKA+LWJSLYcRa9TfZzmM/7R4dq+pTy5BPYF7BDB4qUjBYJmLxr6Lf9C C7761YjCMLlKd9cpsYE2bV8CRgG4uBZGixOhKuHTDpWmxP3GPipcid4pMo1CFt26 m2ieGg== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpenfjrwu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Apr 2026 09:19:49 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c76b69fb9d6so3472511a12.1 for ; Wed, 22 Apr 2026 02:19:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776849589; x=1777454389; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4E0FN1Yk5HSKpQZofTPLB9G3h9HECmMhC7Z9bAGYFWM=; b=WSSlt8Ft6hQo/98wHyW7kHtMFtdAHTTX3ILUW9tYznMMk8wD+nf63ceV7jcMvw7p+K bch+0iZkWLS5tuE0q2Iq0P8F5OTy5tslVIW86YdYeIwQauLGEwuYgMoPdfVgOhoo5U8U B/+92/aOWnJdUZmGOkm1InHVWX1pi65Txc1Xg1gj1JlmqPJViwME8oiAmZpl3ynQUbXL SQU29T3TtE0Knl3P7N+LjhxkgF/0ZewstWEaPIZ+dOWFk11YlJBubSeRyc7SfYM94NyG fUI6e9O+AYZdUTak4nyteUMETaIivvmMJA9IteYrEcKz0ve14gXA9/shCVNlDvr1LXm2 IevQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776849589; x=1777454389; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4E0FN1Yk5HSKpQZofTPLB9G3h9HECmMhC7Z9bAGYFWM=; b=USIRhCKlddMM8T0p/+2esapmuw72gNM/lq6iEVOWQN1eO5QzzBU5jazJnX0BPn3IR3 V4QEYDHkMEIWXU9mQZLc1pq31FwnJ7nv6RpcrzqZGEmfFUWV1nPxgkLIx1EGCHhuJ/yv 3ltalEA6RcFXb9KD9+t5gPgcMSni+yLe48rjkBtZoopDGGdfnlsR3RHUr4BTGTaDoMx8 5igEUpoAVhH0TPDXpaKU7cwrUwUUqvsgPrzIzfTZr8TMDXS47wq88o06KsuYnkwYDQIJ +8Za46t84FBUQcBZ/D2KowgBtiWrGwqXC01BnBJS2dbsQBKYWN8fuB4FOJpnd1suMsQn Xv4w== X-Forwarded-Encrypted: i=1; AFNElJ9SEggugJsVmBuiPM9rJJ+zeU1cqPOGgitPb65v1UsTc5d7M9fePTU6MAS4b01Da9nUMLlTM6QUdzhLnfo=@vger.kernel.org X-Gm-Message-State: AOJu0YxHXxQ+NGNq5y8zOudiHg//ayxb7QgYABCiP/mzxpXhsYYkEPXz ukbzHW2R4tfba2myhUu1fppihzLyAcxARKy00ZLNMOHx8WJagGfFf+pHjJk8m+H8eMjdzwsJCPz seMW4JRbdwQCOqr6BUhFIZNgHugHGothQacdR0f1Hkg7vB/yx5TgebE/qmneb6NmlKz0= X-Gm-Gg: AeBDiesnv3G4Xtdu0aFdXrFIm6TJP1BZpjZlEfuSXsTGQi5Kc0M2582rzR0jKMZ8jV7 sZxnLx0iD6ekDdLSAgTzHxN6u/vLf3mVCXDBZhf37obl5kiolfNOkaDEAa3y13clvCMZT4ItlQQ BjHNDUXDalgIAVvFMp3zaAMJUb3PlZ5w50npXM/VX8oKOyWnCNB43+RqNk6NeTHKq9xBFrF8d4t F3e3TbdhQylqyy5YVRs/AqloU80jSSSNlR7dHV7jAb/4RnKpNp3Xh/mEs2cLe1HCAGrhpD3LsGw lhy1GvHvPmlia7mO3er2El8iTs0v5OQToTyHn4qF6fnv9CUdHYzi2k82SRiiqkjAdYJ9CRFF06s LNSJqC8cf7KdpV7bBhILXoxvpgjNMPeCeaXtH4DPyPfGib1AvWynyQpOqI0ytRGai X-Received: by 2002:a05:6a00:230c:b0:81f:5acb:55fc with SMTP id d2e1a72fcca58-82f8b38a39bmr18780302b3a.10.1776849589254; Wed, 22 Apr 2026 02:19:49 -0700 (PDT) X-Received: by 2002:a05:6a00:230c:b0:81f:5acb:55fc with SMTP id d2e1a72fcca58-82f8b38a39bmr18780278b3a.10.1776849588754; Wed, 22 Apr 2026 02:19:48 -0700 (PDT) Received: from [10.0.0.4] ([106.222.228.209]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8e9cbb1dsm17981983b3a.14.2026.04.22.02.19.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Apr 2026 02:19:48 -0700 (PDT) Message-ID: <1c15d57c-d4b3-bf0e-0afe-17573eb41a1f@oss.qualcomm.com> Date: Wed, 22 Apr 2026 14:49:44 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 1/6] media: qcom: iris: add helpers for 8bit and 10bit formats Content-Language: en-US To: Neil Armstrong , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260417-topic-sm8x50-iris-10bit-decoding-v2-0-c987b65a31d5@linaro.org> <20260417-topic-sm8x50-iris-10bit-decoding-v2-1-c987b65a31d5@linaro.org> From: Dikshita Agarwal In-Reply-To: <20260417-topic-sm8x50-iris-10bit-decoding-v2-1-c987b65a31d5@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIyMDA4NCBTYWx0ZWRfX/X8JUbJ4Uajx KuKW9CWfr6C00xtsl6VyGFeIg5JfY0zrb53TLP7YcvX2er+PA8zC+G+1Qumtfk4cQLtKEJtvGP5 d2kJvMq2e4j2N14sRvzhjKmzF1f9lvw4LEM9njVFVFDtzWSgh/Q+JqFLhWTEg+1ENKvTJsjbZWI NjLZaEP7PbjjY7+kpoSD/oHxO7Ov7G/GuOU4EBRgjTlZL3wat+GdwMs3hKlipubJM0MjJG5ZT5E ansVvaF8iB4b5lteDV2y6yORgo/13rT1+Yxo9jQpzP44olwXzNA4T1bhtt8OQdq2C0fJ2wfFwSW PIr/Uu7fGsWQblxkRfN8Rv21uD0N9cNU2I9GjtX/qcSs8sY+Jrnx5m5+tZzB9bDTTQIOn/iHU48 OXHsCV6Ve96j5PFMRWEmntNa8S85MO96vgHw75e/VBcpI/iMh31TW36nXKnbbhxeWqHe6LK5Ksq 85EpKyWEire+pKaQhJA== X-Authority-Analysis: v=2.4 cv=VMrtWdPX c=1 sm=1 tr=0 ts=69e892b5 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=rP2ZPG2H70Gfrv7XvIldxw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=1v4LsqrUVehaW6lpU9YA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: NsmT24M6jrj1OEYpFzRUqUfuPhiHooIa X-Proofpoint-ORIG-GUID: NsmT24M6jrj1OEYpFzRUqUfuPhiHooIa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-22_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 bulkscore=0 malwarescore=0 spamscore=0 phishscore=0 priorityscore=1501 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220084 On 4/17/2026 3:07 PM, Neil Armstrong wrote: > To simplify code checking for pixel formats, add helpers to > check for 8bit and 10bit formats. > > Signed-off-by: Neil Armstrong > --- > drivers/media/platform/qcom/iris/iris_utils.c | 12 ++++++++++++ > drivers/media/platform/qcom/iris/iris_utils.h | 2 ++ > 2 files changed, 14 insertions(+) > > diff --git a/drivers/media/platform/qcom/iris/iris_utils.c b/drivers/media/platform/qcom/iris/iris_utils.c > index cfc5b576ec56..bdedd6bfa87a 100644 > --- a/drivers/media/platform/qcom/iris/iris_utils.c > +++ b/drivers/media/platform/qcom/iris/iris_utils.c > @@ -38,6 +38,18 @@ bool iris_split_mode_enabled(struct iris_inst *inst) > inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC08C; > } > > +bool iris_fmt_is_8bit(__u32 pixelformat) > +{ > + return pixelformat == V4L2_PIX_FMT_NV12 || > + pixelformat == V4L2_PIX_FMT_QC08C; > +} > + > +bool iris_fmt_is_10bit(__u32 pixelformat) > +{ > + return pixelformat == V4L2_PIX_FMT_P010 || > + pixelformat == V4L2_PIX_FMT_QC10C; > +} > + > void iris_helper_buffers_done(struct iris_inst *inst, unsigned int type, > enum vb2_buffer_state state) > { > diff --git a/drivers/media/platform/qcom/iris/iris_utils.h b/drivers/media/platform/qcom/iris/iris_utils.h > index b5705d156431..35337c5da005 100644 > --- a/drivers/media/platform/qcom/iris/iris_utils.h > +++ b/drivers/media/platform/qcom/iris/iris_utils.h > @@ -45,6 +45,8 @@ bool iris_res_is_less_than(u32 width, u32 height, > u32 ref_width, u32 ref_height); > int iris_get_mbpf(struct iris_inst *inst); > bool iris_split_mode_enabled(struct iris_inst *inst); > +bool iris_fmt_is_8bit(__u32 pixelformat); > +bool iris_fmt_is_10bit(__u32 pixelformat); > struct iris_inst *iris_get_instance(struct iris_core *core, u32 session_id); > void iris_helper_buffers_done(struct iris_inst *inst, unsigned int type, > enum vb2_buffer_state state); > Reviewed-by: Dikshita Agarwal Thanks, Dikshita