From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73556C33C9B for ; Tue, 7 Jan 2020 13:52:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 499C72072A for ; Tue, 7 Jan 2020 13:52:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KoYkzOsR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728176AbgAGNwt (ORCPT ); Tue, 7 Jan 2020 08:52:49 -0500 Received: from mail-ed1-f65.google.com ([209.85.208.65]:36348 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727880AbgAGNws (ORCPT ); Tue, 7 Jan 2020 08:52:48 -0500 Received: by mail-ed1-f65.google.com with SMTP id j17so50398821edp.3 for ; Tue, 07 Jan 2020 05:52:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bG+/1PcaYqZQBXDRaZsbBfE0HShIPerq3LuqbmfLMrM=; b=KoYkzOsRd1NBtQrZUhWDsTYrUj7e88YP8/eHmxy63i6qlc/jG8PaeBTLdPNAeo4xG1 N/IhU1MyR4lRBtgTJbou2o+AsCBxkpPLYr5VWRQpAHIeWGQVsIdfrsMvx4gdD5Yhgd9L d27/jwKLoX6843jUsKgh2hgAkYXpkoMBvQOnSVJzhT2+eLPmrw0OHJxwne0jfcw9CLkF Gs22qZ1iEHfqKZqt31NqssUp/tvRJGi8G9650dr+fIcHZbuclPaCsqUGdOLBzyC7Ij1+ Jroe3z6qKgu/MadWgt7dD/5bMDaqotfm/2RIY29/BLk7wC9lz3E9o0JKW+Gwz5FMPdyH wvzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bG+/1PcaYqZQBXDRaZsbBfE0HShIPerq3LuqbmfLMrM=; b=E7w8Mo+tvf5ydvhj1OkqRGSM6GYZD3eedNZifx8yU5pIUFxTGAszZ2Vgvz58g9qxf5 FxxVjZFI8cKcA/g8K7bvbuumwBeoXSM7lL7BCDsI4DTwDpGfATjo+ANuiY+Cn4eLleYi PaD4Om2xYYOjXFUWp+MbvWpgHmAI1si3YXkvXdlodXoDKEVZntojSaUNVXdBmXZ185Tw V6+7yaVsU5gi4AnOOFkjlpI4xLnfJuuBqp2VqDxL98lVAOiUh2JVpcN2CvQ5vJdXP2Rn hPmDnmIK7871Ip6bv4MhaQH+v220Phc3s/+MJOGq+/aAeHQ43KxBzXtEX/SNQTZBdpKM WdMw== X-Gm-Message-State: APjAAAVRnTxkuy7HMsY5DZ5BfNz9oGqoUfuK4T/DfJ8n8xpWQ+GWt4e2 x7ZViCgXDQjGc9gO4UVG3e8N+A== X-Google-Smtp-Source: APXvYqw9e1ufgH2PKoKl9+B8lQurlIoa2G1RMu/704C5stL4PV36JciZ4WegbOKIg0O1d1qNJkAUcw== X-Received: by 2002:a05:6402:17cf:: with SMTP id s15mr111855185edy.189.1578405167119; Tue, 07 Jan 2020 05:52:47 -0800 (PST) Received: from [192.168.27.209] ([37.157.136.193]) by smtp.googlemail.com with ESMTPSA id w10sm7465183eds.69.2020.01.07.05.52.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2020 05:52:46 -0800 (PST) Subject: Re: [PATCH V3 1/4] arm64: dts: sc7180: Add Venus video codec DT node To: Dikshita Agarwal , linux-media@vger.kernel.org, stanimir.varbanov@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, vgarodia@codeaurora.org References: <1577971501-3732-1-git-send-email-dikshita@codeaurora.org> <1577971501-3732-2-git-send-email-dikshita@codeaurora.org> From: Stanimir Varbanov Message-ID: <1c1686da-6fd4-ffa5-4118-4e6fe1c7f064@linaro.org> Date: Tue, 7 Jan 2020 15:52:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <1577971501-3732-2-git-send-email-dikshita@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 1/2/20 3:24 PM, Dikshita Agarwal wrote: > This adds Venus video codec DT node for sc7180. > > Signed-off-by: Dikshita Agarwal > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 36 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 3676bfd..fa849de 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > > / { > interrupt-parent = <&intc>; > @@ -66,6 +67,11 @@ > compatible = "qcom,cmd-db"; > no-map; > }; > + > + venus_mem: memory@8f600000 { > + reg = <0 0x8f600000 0 0x500000>; > + no-map; > + }; > }; > > cpus { > @@ -1043,6 +1049,36 @@ > }; > }; > > + venus: video-codec@aa00000 { > + compatible = "qcom,sc7180-venus"; > + reg = <0 0x0aa00000 0 0xff000>; > + interrupts = ; > + power-domains = <&videocc VENUS_GDSC>, > + <&videocc VCODEC0_GDSC>; > + power-domain-names = "venus", "vcodec0"; > + clocks = <&videocc VIDEO_CC_VENUS_CTL_CORE_CLK>, > + <&videocc VIDEO_CC_VENUS_AHB_CLK>, > + <&videocc VIDEO_CC_VENUS_CTL_AXI_CLK>, > + <&videocc VIDEO_CC_VCODEC0_CORE_CLK>, > + <&videocc VIDEO_CC_VCODEC0_AXI_CLK>; > + clock-names = "core", "iface", "bus", > + "vcodec0_core", "vcodec0_bus"; Please, align this as you made it for clocks. > + iommus = <&apps_smmu 0x0c00 0x60>; > + memory-region = <&venus_mem>; > + > + interconnects = <&mmss_noc MASTER_VIDEO_P0 &mc_virt SLAVE_EBI1>, > + <&gem_noc MASTER_APPSS_PROC &config_noc SLAVE_VENUS_CFG>; > + interconnect-names = "video-mem", "cpu-cfg"; > + > + video-core0 { The subnode name isn't correct because we have only one core. Could you rename it to video-decoder. > + compatible = "venus-decoder"; > + }; > + > + video-core1 { rename to video-encoder > + compatible = "venus-encoder"; > + }; > + }; > + > pdc: interrupt-controller@b220000 { > compatible = "qcom,sc7180-pdc", "qcom,pdc"; > reg = <0 0x0b220000 0 0x30000>; > -- regards, Stan