From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCCA737F00B for ; Thu, 12 Mar 2026 08:43:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773305025; cv=none; b=p4hPCmRxG1nRgUAqAkrHLq95CvYQVQ7WQvPWY2ygTuCHtZLopKfZRlpfm9+ktvbD7Hm1FWOR7NZi8YA9Uvs5gQ1AiczOUk6IsN55ueXSXGZYPivc8n6UDSfIWKZo8N1WMDnpnCoI5jcbge/Dx2Rt9CC8uWhIB92FahjnRU5RzxA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773305025; c=relaxed/simple; bh=gluiqefPJyMporu2NQvn2jJmiuBvJFcIQ/S0YY/bh10=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OTFUviLBYnO9vDUC9NMLn9kB1cdilCzPbGYO3oTFLNrZYPoPC1KqOxCLxorvLSOSdLQF26cstTm6/gmwwHREuEAi/TZaB2kLK0AZK9jCWRztmgvS3lEhBue68olJ2Att/+2mLAzaStNhelpd4tDvuhhCehcciRx69Pd/B+96Rp8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=EP7IorNP; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="EP7IorNP" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-48540d21f7dso8573815e9.0 for ; Thu, 12 Mar 2026 01:43:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1773305022; x=1773909822; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PHAsiAoMs+rl29pl1btSfTev7d4G7XkQ7qF+4yVEfes=; b=EP7IorNPJ0x8DfP9ZvU5mxZPfnk+u37VOKIvdj3Q4ZsdmTqr2XL28RF/zpnfTJhSJZ cp/lj6bgr51HLB3ZfEjSa+cn+plNiXfPDeWXi2ywxYYuUcYtiDe8lsrZaDhbt/uFJCgQ g4h8d+1abwJKwu7nwXcaM1/1hs7Li1i3Z8NiLcAuVPgdsMhG7C54DUj7pz/eg+zfxDjY h9yJDQOHQELvmRR685JOgfWgeVxlYc0EZiucT69ya0IoYHg8EF3GdcTjdE6N2QV9ejr9 2kMnfnwxkclrwPAmImNulkIE5f9Rrlbr/QLKGrzhdV7gWGHLY2TOxZNyMoi0ZPEpQucm RtTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773305022; x=1773909822; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PHAsiAoMs+rl29pl1btSfTev7d4G7XkQ7qF+4yVEfes=; b=fY0vwIBET6dsbObMHC3Yondfrjnh00D/XvZU5VhxGgDj452upVtyJLuY/4tQ1o6Y8F 75DoIGs1pxix+WIzbN8Sh3LmEA8fLMk17CN5cNkKEHJCj14t9eQtO0Oq+L0uMLkrK9g+ 1yDPMBlZoKfZ4MZDbCENne4caUUchxaSnyhbZi6XDJu+QBq2+h5H7+Esv8/lkWCFFXNC sOelO4/BV+O1+CHbh6GBtsOWSC1Kriu4aeRtZHTjH3Y6LqzzRsPc2geZhIUCc3ikFOpH /+O+bvfjEQSKAJO+NrMg2sYuQyUNk+0uD2frWPpTaXHRzOW86pdXO4Yn4PqEJfQ4ypG7 rAvg== X-Forwarded-Encrypted: i=1; AJvYcCVwGUIsOoxlccojYcXm5U07Zj2eL5XxMXULzOpSP6K2ZGw0pf/pu9tYqFy2HC5F3sjoWUqN3qxclVwhmuE=@vger.kernel.org X-Gm-Message-State: AOJu0YyvbEbVSDyspqxZGUVrr3hDJcitLzvol88WRSjtXdpnhL5vY9Ve 2xKDvgmTku/mDrg01zhoo70d5nUC2fhfEEBNPWa6NNV0AN4rQTHhNUnnyMHXrHzLXQw= X-Gm-Gg: ATEYQzzEvFPV+1kVc5VlUKaLa+/5NOJ3tDOqnZpxCJncxn0m1aH5Gaw7QlKExTm3mTo JOSaUpevR97opcKcm6RIswmx+lqDd7zRHp1vSrht9fdYxLnQXtLSLQzCLrb1y5PNq2Z4wA5DLsS Uyc6/Gy6kxQaOwHBG5Ro/nIcu3p+Pfg+/tTD4IBk8HjpgvO0WcGJS0gO8lmZ40rvk5T0eO0gyl/ pyvfKpjLUEyhvto3x4ltKzmT8lXlogzGo8CGn/AiqC4q2LfhOLelp8PggP9ZeVdWS24VwcWFaR3 2jgib+gOvBmxtH4YrIH22ftElEifNt76be8TMr2JNHDZeuzuOPLqlD2BcMbmibblO/D764OQaBf oqwH+TqHU/5aCetokTRxALyGTAhFmhWdOnAgNH/eFOVdq1hEiv73J6S/DtaWQy/fU1S+j6EBdvm J+NeEREC4X9RGKjAAFmn/tdbvD0FXfMXTnkcTVUuZNuF8Vn2112CE4q3erJe0L5yo1b4Q= X-Received: by 2002:a05:600c:3114:b0:485:4526:ee06 with SMTP id 5b1f17b1804b1-4854b0bb7dbmr89414645e9.11.1773305022375; Thu, 12 Mar 2026 01:43:42 -0700 (PDT) Received: from ?IPV6:2001:a61:13b5:4001:781c:5386:18e2:cda0? ([2001:a61:13b5:4001:781c:5386:18e2:cda0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854b66ffe2sm108681755e9.13.2026.03.12.01.43.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Mar 2026 01:43:42 -0700 (PDT) Message-ID: <1c1bb25e-10e0-4199-900f-c89554e71db6@suse.com> Date: Thu, 12 Mar 2026 09:43:41 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1 net-next] net: usb: cdc-ether: unify error handling in probe To: Andrew Lunn , Oliver Neukum Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260311112919.678686-1-oneukum@suse.com> <5db41b5a-c53f-4441-bf4e-a12add3e33b4@lunn.ch> Content-Language: en-US From: Oliver Neukum In-Reply-To: <5db41b5a-c53f-4441-bf4e-a12add3e33b4@lunn.ch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11.03.26 20:15, Andrew Lunn wrote: > It might be better to change the dev_dbg()s to dev_err()s, and drop > the dev_info() here. You can then add additional dev_err() before the > goto's you are adding. Excellent suggestion. Regards Oliver