From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 213D0C00140 for ; Fri, 12 Aug 2022 15:30:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239086AbiHLPaw (ORCPT ); Fri, 12 Aug 2022 11:30:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238259AbiHLPau (ORCPT ); Fri, 12 Aug 2022 11:30:50 -0400 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD184E019 for ; Fri, 12 Aug 2022 08:30:49 -0700 (PDT) Received: by mail-pg1-x533.google.com with SMTP id 73so1065502pgb.9 for ; Fri, 12 Aug 2022 08:30:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id:sender :from:to:cc; bh=9rQM1/BORK4sGy5Cwj1d1mPdoYhgdZ1Ue14VRkIr/3c=; b=VYd2zME2kVQ3dNi1AM8RbXHQrvVLNoxksuBzD4pzX37xqHjpeyvwxPsmkJ9FKwn1IG cJ/8VUCHCfyvSk+cJTNEbXu7PHu5KkKEmCAP8mrHH1P8WyWbd6WVLcbOxkEAtAdYJA3a 7Tmp2hfHoE3PGO9t4Ta96W/mgA3JGonyYYQ6cD5pDg/TXoS97BhV1Q2JCGoGfNH7312m MJCcvIKHOg0Et1cAIChVWMqUhDzbG4YzRoAb2ST6Vfi2JZ/KOLjCbN5LGHGD+F8tkNMr vwYEnxzJFcgb4BoZV8nLDm1BgAAzN6eCQvTjzLprJvotF4odTOdwxdw1p5qSNhIigGTy aHKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id:sender :x-gm-message-state:from:to:cc; bh=9rQM1/BORK4sGy5Cwj1d1mPdoYhgdZ1Ue14VRkIr/3c=; b=bHjRbSekoh2tHMJfCD+mDNlAj5vGhEsume0MxnD+u5t4kci2Me85dfV5gHFfCdOlja ZvUNMQPTXm9JBT6hWHJ5hcJQC0Kdqbt/TnwyCsAxJeDh5xwXdQMTuTvqsQAQSgEh7sAy Ecu+hR314O4ZU6pcBMTxjm5ETRH9Pla/3LC0NLGoJA4Rsb6vC4rCtkfEXUpy8xnVgQ2Q 0cCFbCHq+bJIMVYkCEOfjzhRunftndczyYcseLTQ2wQMQbinK95ViLmzv05AaytSXc3i +gtm4xfk8PxN0I2DfyGKwOPjb9B0pI7hVQafaCwSv4vEhz8sIB8lBdLHIGgBm3KoI56u PUrA== X-Gm-Message-State: ACgBeo28IDHhFskNQYBo19rjHpfxS/o/MLkuu4xAIF2GJH3MXFdQapFY 4vzUo3SHwGkKQxqeTtFpN8j7bFPRxBk= X-Google-Smtp-Source: AA6agR5Nwc2R9qV7nE+WqYc4U9XTi7JmxYjbIeFAGH6+BzdeNIXk8Jb/NDaAu0cW2w0bRFWPGzHCVw== X-Received: by 2002:aa7:8253:0:b0:52b:f4f7:bc55 with SMTP id e19-20020aa78253000000b0052bf4f7bc55mr4475911pfn.4.1660318249199; Fri, 12 Aug 2022 08:30:49 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id j125-20020a625583000000b0052e987c64efsm1799185pfb.174.2022.08.12.08.30.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Aug 2022 08:30:48 -0700 (PDT) Sender: Guenter Roeck Message-ID: <1c20eedf-4fa9-9cb1-b232-3bc490c1be7c@roeck-us.net> Date: Fri, 12 Aug 2022 08:30:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Isaac Manjarres Cc: Saravana Kannan , Russell King , Philipp Zabel , Rob Herring , Ulf Hansson , Linus Walleij , Sudeep Holla , Nicolas Saenz Julienne , Geert Uytterhoeven , Marek Szyprowski , Kefeng Wang , Greg Kroah-Hartman , patches@armlinux.org.uk, kernel-team@android.com, linux-kernel@vger.kernel.org References: <0c6ef9a3-bbb1-9f1c-7f00-ceb05589594e@roeck-us.net> <1196e002-c07d-44fd-b07a-aa5ae446ea0b@roeck-us.net> <225747de-4348-58b3-19be-8b14356ab3a0@roeck-us.net> <971799be-8c15-fc81-ec71-bbca6483207d@roeck-us.net> <20220811195234.GA4018948@roeck-us.net> From: Guenter Roeck Subject: Re: [PATCH v6] amba: Remove deferred device addition In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/11/22 22:12, Isaac Manjarres wrote: > On Thu, Aug 11, 2022 at 12:55:08PM -0700, Guenter Roeck wrote: >> >> Ah, it must be triggered by one of the configuration options I have enabled >> on top of versatile_defconfig. Sorry, I should have checked. Please try >> with the configuration below. >> >> Guenter > > Thanks for sharing your config options; I was able to reproduce the > crash after copying your config options to my repository :) The > following changes fixed the problem for me. Can you please give them a > try on your end to see if they work for you too? > > diff --git a/drivers/base/dd.c b/drivers/base/dd.c > index 90b31fb141a5..0315bc2853ef 100644 > --- a/drivers/base/dd.c > +++ b/drivers/base/dd.c > @@ -1117,7 +1117,9 @@ static int __driver_attach(struct device *dev, void *data) > * is an error. > */ > > + device_lock(dev); > ret = driver_match_device(drv, dev); > + device_unlock(dev); > if (ret == 0) { > /* no match */ > return 0; > After more testing: the changes above result in qemu sx1 boot failures. There is no crash, boot just hangs. qemu command line: qemu-system-arm -M sx1 -kernel arch/arm/boot/zImage -no-reboot \ -initrd rootfs-armv4.cpio \ --append "rdinit=/sbin/init console=ttyS0,115200 earlycon=uart8250,mmio32,0xfffb0000,115200n8" \ -nographic -monitor null -serial stdio with configuration from https://github.com/groeck/linux-build-test/blob/master/rootfs/arm/qemu_sx1_defconfig and root file system from https://github.com/groeck/linux-build-test/blob/master/rootfs/arm/rootfs-armv4.cpio.gz This is with your other patch applied. Guenter