From: Dan Murphy <dmurphy@ti.com>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, <linux-leds@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] leds: lm3692x: Allow to set ovp and brigthness mode
Date: Tue, 17 Dec 2019 11:01:49 -0600 [thread overview]
Message-ID: <1c233937-5d99-bd9d-b8ac-290fca8305d5@ti.com> (raw)
In-Reply-To: <20191217154059.GA3929@bogon.m.sigxcpu.org>
Guido
On 12/17/19 9:40 AM, Guido Günther wrote:
> Hi Dan,
> On Tue, Dec 17, 2019 at 06:53:45AM -0600, Dan Murphy wrote:
>> Guido
>>
>> On 12/16/19 6:28 AM, Guido Günther wrote:
>>> Overvoltage protection and brightness mode are currently hardcoded
>>> as disabled in the driver. Make these configurable via DT.
>> Can we split these up to two separate patch series?
> Sure, should the binding doc updates be split as well?
Yes.
<snip>
>> extra debug statement
> They're not extra but meant to ease debugging the driver long therm but
> i can drop these if that's not wanted. The rest makes a lot of sense.
> Thanks a lot for having a look so promptly!
Yes please remove those we don't need extra noise in the log.
If someone wants to debug this then they can add the statements themselves
Dan
next prev parent reply other threads:[~2019-12-17 17:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 12:28 [PATCH 0/2] " Guido Günther
2019-12-16 12:28 ` [PATCH 1/2] dt: bindings: lm3692x: Document new properties Guido Günther
2019-12-17 12:41 ` Dan Murphy
2019-12-21 19:15 ` Pavel Machek
2019-12-24 11:45 ` Guido Günther
2019-12-26 19:19 ` Rob Herring
2019-12-27 10:16 ` Guido Günther
2019-12-16 12:28 ` [PATCH 2/2] leds: lm3692x: Allow to set ovp and brigthness mode Guido Günther
2019-12-17 12:53 ` Dan Murphy
2019-12-17 15:40 ` Guido Günther
2019-12-17 17:01 ` Dan Murphy [this message]
2019-12-21 19:17 ` Pavel Machek
2019-12-24 11:30 ` Guido Günther
2019-12-21 19:18 ` Pavel Machek
2019-12-24 11:26 ` Guido Günther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c233937-5d99-bd9d-b8ac-290fca8305d5@ti.com \
--to=dmurphy@ti.com \
--cc=agx@sigxcpu.org \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®