From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lelvem-ot01.ext.ti.com (lelvem-ot01.ext.ti.com [198.47.23.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11CBF1487C1; Fri, 31 Jan 2025 23:41:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.23.234 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738366865; cv=none; b=RnBRk875QWJnbsbDRjEXuXbWuDz7kBsDcW2x3sMTk8qMYwf5wnWv8rG+hW1Ej5Pqc1efievHo/8ayAS0l6esGDqXTx81dnZ4rTdweagr05C3vUWYa1lmVVYkS7IoRGPac1svphllWhXTKLsFOdUC8JixDUnFt5XKL1tE4lUFh/0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738366865; c=relaxed/simple; bh=uKwvk3KMuFPC/JlSa0m1mvGvWUngrmBgCkTgHBBycX0=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=ElEHDj9PwWCUazrTxpsjMZh3gT2IG22M2HqXaPKS2zOcfWnw0V38NIPcxG3bMVc3hOyReUtndCTifpQkLpLxRv+djOgIIhfmgpZfFves2k4VWTLYFW9/enzcs7mH7Exs3+0eAwf95gdKxaZGGBqlry1C3OLja7XnpFm7hvWgtTg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=mZPgsRek; arc=none smtp.client-ip=198.47.23.234 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="mZPgsRek" Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelvem-ot01.ext.ti.com (8.15.2/8.15.2) with ESMTPS id 50VNeuaM2615028 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 31 Jan 2025 17:40:56 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1738366856; bh=WoabQOIO7BqEmHMvwAU48qnHgarITzPKF9dEIQzwpHk=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=mZPgsRekWBzNXLMw+JsvJpCz5v0TSd1PYzWlRTr/TKLZ0sEhUAMnKzRW3m2ZFJeQ2 RKk4FPIGfWAbathUmvIZxTIPJvtxV4zLyHqlHeY2yA+PFZwB9Ja6mnfSKDzfxIrbQI XtQn1juIjNYMoilIpP57maVjWZohktF411vM13wM= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 50VNeu0D090728 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 31 Jan 2025 17:40:56 -0600 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 31 Jan 2025 17:40:55 -0600 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 31 Jan 2025 17:40:56 -0600 Received: from [10.249.42.149] ([10.249.42.149]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 50VNee8d052831; Fri, 31 Jan 2025 17:40:40 -0600 Message-ID: <1c2c67b7-987e-4b92-b0be-c0b2f25adae6@ti.com> Date: Fri, 31 Jan 2025 17:40:40 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/9] arm64: dts: ti: k3-am62-wakeup: Add wakeup r5f node To: Judith Mendez , Nishanth Menon , Vignesh Raghavendra CC: Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , Hari Nagalla References: <20250131214611.3288742-1-jm@ti.com> <20250131214611.3288742-2-jm@ti.com> Content-Language: en-US From: Andrew Davis In-Reply-To: <20250131214611.3288742-2-jm@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea On 1/31/25 3:46 PM, Judith Mendez wrote: > From: Hari Nagalla > Subject should capitalize R5F > AM62 SoC devices have a single core R5F processor in wakeup domain. > The R5F processor in wakeup domain is used as a device manager > for the SoC. > > Signed-off-by: Devarsh Thakkar > Signed-off-by: Hari Nagalla > Signed-off-by: Judith Mendez > --- > Changes since v1: > - disable each device node in the voltage domain files and > enable at the board level file > - fix firmware names > --- > arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 25 ++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi > index 9b8a1f85aa15c..12b1520974ade 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi > @@ -106,6 +106,31 @@ wkup_rti0: watchdog@2b000000 { > status = "reserved"; > }; > > + wkup_r5fss0: r5fss@78000000 { > + compatible = "ti,am62-r5fss"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x78000000 0x00 0x78000000 0x8000>, > + <0x78100000 0x00 0x78100000 0x8000>; Odd alignment, looks like you have an extra tab on the above line Andrew > + power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>; > + status = "disabled"; > + > + wkup_r5fss0_core0: r5f@78000000 { > + compatible = "ti,am62-r5f"; > + reg = <0x78000000 0x00008000>, > + <0x78100000 0x00008000>; > + reg-names = "atcm", "btcm"; > + ti,sci = <&dmsc>; > + ti,sci-dev-id = <121>; > + ti,sci-proc-ids = <0x01 0xff>; > + resets = <&k3_reset 121 1>; > + firmware-name = "am62-wkup-r5f0_0-fw"; > + ti,atcm-enable = <1>; > + ti,btcm-enable = <1>; > + ti,loczrama = <1>; > + }; > + }; > + > wkup_vtm0: temperature-sensor@b00000 { > compatible = "ti,j7200-vtm"; > reg = <0x00 0xb00000 0x00 0x400>,