From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 505DCC4743D for ; Fri, 4 Jun 2021 21:35:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 38C30611CA for ; Fri, 4 Jun 2021 21:35:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231325AbhFDVhH (ORCPT ); Fri, 4 Jun 2021 17:37:07 -0400 Received: from mail-ot1-f45.google.com ([209.85.210.45]:46755 "EHLO mail-ot1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229916AbhFDVhF (ORCPT ); Fri, 4 Jun 2021 17:37:05 -0400 Received: by mail-ot1-f45.google.com with SMTP id 66-20020a9d02c80000b02903615edf7c1aso10405368otl.13 for ; Fri, 04 Jun 2021 14:35:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=janzFmwZwQn6MiazfcV23K2Rys/KSeJAT5SN2x0frTo=; b=bcQtEHquS30yyvQ1kaHKFd0tJs1enDS2ZJKgq5iUoQtEm6r0yiMZiw/9nmFtMJNiNZ stEiJqpVzujWqqEYCXu2byslnfJgFdzX7Xj6qMO1hXyOHrZDMV2BljucQcgOtDjpIJmv AFcNQ8o7aPfAkwgc/F3Db8ElR57G6hwgPtRWo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=janzFmwZwQn6MiazfcV23K2Rys/KSeJAT5SN2x0frTo=; b=IPxeFNnG6UFwoyS4Q5CMvJ125wdIH+nqMWqW4uGoKu1nZfAONAb+C56YF9vyu3zQmY WEhYS7fWNpT7vN8qpDn90FyA8pgFZuUNUdPbhgVz8u3/1Mw7sm4nUCLqO1LWpxC4qEQ2 IZPhrQ0sbu86YmiHy3XmVI7olH70A/UhhzgcV18ab95p5b/5Kj7PSfYeVmJBu56dwbG/ neXZt/Q1+dAzGBYGTsCkyCQw+sMQ0YgBBI9YQrMqnPmNWQMgGmF6hkmn/q7cBFXuf82i lAjeqhHal9FPEgK0jSeSWFF4zBTizQSv7+lB0fk0ZylJuI4K3jVp991aJEK8F4hILswB oJnw== X-Gm-Message-State: AOAM530yJRRS+ho9ZRVzTjEZ7VrKPAIVpKCMOkKDcy+eGHw21EuWvzJg YS+WxIZHaqh+WSbc97MEtzrWPw== X-Google-Smtp-Source: ABdhPJx8D1/TaC5pTiA1cnV7ygPBTV4NHHVAq024vEq925p4hG2T8oj2kwVnvQNCBXNvuAcH13uL8g== X-Received: by 2002:a9d:4f18:: with SMTP id d24mr5147979otl.16.1622842442990; Fri, 04 Jun 2021 14:34:02 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id l7sm714950otu.76.2021.06.04.14.34.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jun 2021 14:34:02 -0700 (PDT) Subject: Re: [PATCH] selftests/tls: Add {} to avoid static checker warning To: Kees Cook , Shuah Khan Cc: Dan Carpenter , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20210527032718.3730773-1-keescook@chromium.org> From: Shuah Khan Message-ID: <1c391e24-15d1-9be4-c32f-4677912359f9@linuxfoundation.org> Date: Fri, 4 Jun 2021 15:34:01 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210527032718.3730773-1-keescook@chromium.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/26/21 9:27 PM, Kees Cook wrote: > This silences a static checker warning due to the unusual macro > construction of EXPECT_*() by adding explicit {}s around the enclosing > while loop. > > Reported-by: Dan Carpenter > Fixes: 7f657d5bf507 ("selftests: tls: add selftests for TLS sockets") > Signed-off-by: Kees Cook > --- > tools/testing/selftests/net/tls.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/net/tls.c b/tools/testing/selftests/net/tls.c > index 426d07875a48..7119f8eb823b 100644 > --- a/tools/testing/selftests/net/tls.c > +++ b/tools/testing/selftests/net/tls.c > @@ -418,8 +418,9 @@ TEST_F(tls, sendmsg_large) > EXPECT_EQ(sendmsg(self->cfd, &msg, 0), send_len); > } > > - while (recvs++ < sends) > + while (recvs++ < sends) { > EXPECT_NE(recv(self->fd, mem, send_len, 0), -1); > + } > > free(mem); > } > Will pick this up for 5.14 thanks, -- Shuah