mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Hariprasad Kelam <hkelam@marvell.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	pabeni@redhat.com, kuba@kernel.org, edumazet@google.com,
	davem@davemloft.net, sbhatta@marvell.com, gakula@marvell.com,
	sgoutham@marvell.com
Subject: Re: [net-next PATCH] octeontx2-pf: Add support to read eeprom information
Date: Fri, 26 Jan 2024 03:38:08 +0100	[thread overview]
Message-ID: <1c39b3eb-0616-4214-bcfa-aaba1bd4e4a4@lunn.ch> (raw)
In-Reply-To: <20240125112133.8483-1-hkelam@marvell.com>

On Thu, Jan 25, 2024 at 04:51:33PM +0530, Hariprasad Kelam wrote:
> Add support to read/decode EEPROM module information using ethtool.

It looks like you have a very primitive firmware here, which can only
return the first page of the SFPs EEPROM. What are your plans to make
this fully featured? Ideally you should not be using this API, but the
newer API which indicates what page you would like to read.

> Signed-off-by: Christina Jacob <cjacob@marvell.com>
> Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> Signed-off-by: Sunil Goutham <sgoutham@marvell.com>

These seem to be in the wrong order.

      Andrew

  reply	other threads:[~2024-01-26  2:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25 11:21 Hariprasad Kelam
2024-01-26  2:38 ` Andrew Lunn [this message]
2024-01-31 11:37   ` Hariprasad Kelam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c39b3eb-0616-4214-bcfa-aaba1bd4e4a4@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gakula@marvell.com \
    --cc=hkelam@marvell.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sbhatta@marvell.com \
    --cc=sgoutham@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®