mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonas Jelonek <jelonek.jonas@gmail.com>
To: shao.mingyin@zte.com.cn
Cc: linusw@kernel.org, brgl@kernel.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] gpio: line-mux: fix unsigned truncation of property count error
Date: Wed, 11 Nov 2026 16:02:24 +0100	[thread overview]
Message-ID: <1c42a9d1-643b-47bb-8f69-0ff0eebe5d47@gmail.com> (raw)
In-Reply-To: <20261111173546439alUdLx-iD6-ISoa9jqS5H@zte.com.cn>

Hi Shao,

On 11.11.26 10:35, shao.mingyin@zte.com.cn wrote:
> --------------------------------------------------------------------------------
> Hi Jonas,
>
> On 10.11.26 17:07, Jonas Jelonek wrote:
>> I think you still need to move it up where 'unsigned int ngpio' was
>> before for RCT.
> I read RCT as ordering by decreasing declaration length, in which case

I understood it as plain line length. Not sure what declaration length really means.

> `int ngpio, ret` after `size_t size` already complies.  But if you want

with 'int ngpio, ret' being longer than 'size_t size'.

> it in ngpio's old slot (right after `glm`), that's a one-line move --
> say the word and I'll fold it into the next revision (v2 already has
> your Reviewed-by, so I'd rather not respin just for this).
>
> Thanks,
> Shao
> --------------------------------------------------------------------------------

But probably not worth to respin unless something else in the series needs
a change.

Best,
Jonas

      reply	other threads:[~2026-11-11 15:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 14:57 shao.mingyin
2026-11-10 15:17 ` Bartosz Golaszewski
2026-11-10 15:28   ` shao.mingyin
2026-11-10 16:07 ` Jonas Jelonek
2026-11-11  9:35   ` shao.mingyin
2026-11-11 15:02     ` Jonas Jelonek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c42a9d1-643b-47bb-8f69-0ff0eebe5d47@gmail.com \
    --to=jelonek.jonas@gmail.com \
    --cc=brgl@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shao.mingyin@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®