From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53B6F353888 for ; Tue, 18 Nov 2025 17:32:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763487179; cv=none; b=t1g+vRRfoWzn2yitlwuBSmwX/boYwE6incrNgNtUfwPe46rPrgQ1pxD/FAPjgGIQlrHTvgaQ3bgjSV1knID8aa/WaTdmYmEXdJiwGic5St61pgMYjpDJSmmwoKLVe9msvpin5Mx3gEsuXYlxbaf2Ab+1Qw0sBN7CAqdacuEH3yE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763487179; c=relaxed/simple; bh=KKOBsYgKv97w/HfACS/VyWtNlPlmasWAsfEKqO5aXf0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OKeLO3O1+gJQM1Lmge9yvfvVetinm1LjCkEp8Rfxo4Eg9nbZGbbhg5DeJuBaIUG0/FFF/adbvh82YLVfqMiC4TNcdAJmcd7/6D+0VEvr1Ib/DgGbPzK21v/Eayz9JWkf5TRfAejDZKK9I3gKNkqyc8I2Yp8Ej6roE0bQG11c6ys= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=fuAv3bXD; arc=none smtp.client-ip=209.85.166.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="fuAv3bXD" Received: by mail-il1-f174.google.com with SMTP id e9e14a558f8ab-43380a6fe8cso38531205ab.0 for ; Tue, 18 Nov 2025 09:32:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1763487176; x=1764091976; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ec5izO6qQ1oFETz1h93VLus1xZ8qz7zlXuLKIwfS2RQ=; b=fuAv3bXDmO4MuqV0voLegMa+Bx+0NlJDk1lUO1uUnZi7JSBXjDbn7atT5ZZy4Io+8g Ook9ImfauapPIAiqdTU4Jv9GuEQoryssQc8k+7geaUQ1zIIFtVYqtzXtZo/dxV5kuqnS H3G9bp39w1UPwi29fw3HB2cc6xalm5crz10BEf8ECyfvnVIjHBfvydGiV9zYBT9ipw6Z E6huhdytjJii0wuM8xl6WpXpuD3eXCow54pMDXTYaOXvS+lX7H7ElxDC+9afzkTLHZ2D 0J5f4Skl95kDYiWTBDiwuc9Po7uMv+ShKeVEDr9S+YShgCeLBwbYG6Fb4PaHPuPmNQ0b /qmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763487176; x=1764091976; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ec5izO6qQ1oFETz1h93VLus1xZ8qz7zlXuLKIwfS2RQ=; b=SecEMxJKQOwZMfo5700oivm24uJDUn9eRiOlJ/MZsKynmGpo7JA1AYwdSQInlSfrSA oketSlNQtPhJAllKyydtQvGRN8UvCDoSMfIwJi+EUIKukJ+xNC4pj1CKtczGiX9FbAtZ rXiCZVd7IeDfr2AZvoQTWmEnzwO9sW9scRK+VuGSdJDhzgPbGw0spCPSo/7qeDvEtxVe ReAE3h4YPJe6zjy08Vak2WQ0gEA5ev4/eDwTcX2KsHUKSRI10MwI1Gx8EtPBhc4T8EPz Nu/r59svSisH1eHKa34lgFKPhpodMij6uZ1Rj4LPHj9Y7FGlKsIKb06gsaNBfHF9a7tf VRkA== X-Gm-Message-State: AOJu0YzufzJ/SP+5o7h0EIHZK8VwIYPM13Ud9aGp8wWAcw2mgckaTkIW 6WZ3jFcH0WCzp7R4bnBaDwnSa2aYQyJ8i0AFRrqMZNjO94rRR8vP29FoWZdrXbR0nw0= X-Gm-Gg: ASbGncsqqSGuydr6wm+1WIcPJRDGwKhnURm8J8lbLC7EPDvSGMFdOlX1BjFJOV4yjRC 05TVH8dwQXgecFgyZZ7UKZF06Z8CKBvc3OLwujQYk1fjXwH3Io31UhxbkDjDzOszS2TQoXcZreT HlWD1ftsSBCgMgft3WYZdqTzzklkIFe3iJCWjFMgDHK6DQFO+aLFZcTlLK7ZrE9IkbT10hx1Z9e 4yFXXbDf0oWrmwwZfYVXRNTB6s1Vt4B5mO+2llJXNX98jsS9S/zIWpGoYm5Wmi2Ok0n3zzdqNCN yfMHnN9LNIrSOJWESLWcHFiQ0916usYG9uxx1DZ2eR2n1pLwmnSC1bSIfLcaMq8au0NyyzBg/AM 8i3WpS01BSYS0hzW02jDgpa5bdU7mo4vFNXlS6iEhh1DODcln4KY1WpTNpB7+598wmbMi4hauvn DWmW4S93UFJ2Ys5fmu6hUSzFPozYf7HkoiLRzAbZe/Ek0Zu03K1w== X-Google-Smtp-Source: AGHT+IEZShSd2XdlTL6LQuL0eb9ZcN2CQs/Oju6iDycMXlqVGOaJYIbCBR4ngQaAmXBLuKdLttDx0g== X-Received: by 2002:a92:c213:0:b0:434:a7c1:6b91 with SMTP id e9e14a558f8ab-434a7c16c2emr61797275ab.18.1763487176112; Tue, 18 Nov 2025 09:32:56 -0800 (PST) Received: from [172.22.22.28] (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-43483990056sm82570475ab.19.2025.11.18.09.32.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 09:32:55 -0800 (PST) Message-ID: <1c43aa3d-a5e6-4260-9079-fdc2e05c533c@riscstar.com> Date: Tue, 18 Nov 2025 11:32:54 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/4] mfd: simple-mfd-i2c: add default value To: Troy Mitchell , Lee Jones , Yixun Lan , Andi Shyti , Alexandre Belloni , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-i2c@vger.kernel.org, linux-rtc@vger.kernel.org References: <20251118-p1-kconfig-fix-v3-0-8839c5ac5db3@linux.spacemit.com> <20251118-p1-kconfig-fix-v3-4-8839c5ac5db3@linux.spacemit.com> Content-Language: en-US From: Alex Elder In-Reply-To: <20251118-p1-kconfig-fix-v3-4-8839c5ac5db3@linux.spacemit.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/18/25 12:08 AM, Troy Mitchell wrote: > The default value of the P1 sub-device depends on the value > of P1, so P1 should have a default value here. > > Signed-off-by: Troy Mitchell > --- > drivers/mfd/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 6cec1858947bf7ab5ee78beb730c95dabcb43a98..b0f109b3acc40b074e4d0178e123437495853496 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -1260,6 +1260,7 @@ config MFD_SPACEMIT_P1 > depends on I2C > select I2C_K1 > select MFD_SIMPLE_MFD_I2C > + default ARCH_SPACEMIT > help > This option supports the I2C-based SpacemiT P1 PMIC, which > contains regulators, a power switch, GPIOs, an RTC, and more. > I agree with Emil on making this be default m if possible. Acked-by: Alex Elder Thank you for these fixes.