From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D89EAC433F5 for ; Sat, 26 Feb 2022 16:58:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232387AbiBZQ6j (ORCPT ); Sat, 26 Feb 2022 11:58:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231722AbiBZQ6h (ORCPT ); Sat, 26 Feb 2022 11:58:37 -0500 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD41F49F14 for ; Sat, 26 Feb 2022 08:58:01 -0800 (PST) Received: by mail-lj1-x229.google.com with SMTP id u7so11545665ljk.13 for ; Sat, 26 Feb 2022 08:58:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=owTm5fqCrovwZsSeFyT0SWgn+isvTSMUFwaRZEzOpTg=; b=Fw6F2RVeaLHd4OcyWKFCNWbxG59qs8S5e5ppQ7b/fAmmhBaNwAzqoPn5FqurgRD/UP 4kNMqK8/iAw5tXqy8+SKwwagzwBK4r13GtfI8di1uSxXHmwOVj4nCezKW3oEY72dYotj hxVlwrYqNlHbjZj6/Rxz1Fz4jvaADcWGFTUOeHJYnUJKiUk8GxVsSFmxrcMk3EgkLOuc r/2UDFiULKIrVAO768vm6gXm/qSHQWjc1R4K8u2FvGxdNUlMjr+iioWtvpv50HYPOHcY n6yHYcFeLLs87ATwhTrEl/EGglY8rlyjj3g8c3+/ASibXypzBIvcVryqfXQj6KaOZJeo ixKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=owTm5fqCrovwZsSeFyT0SWgn+isvTSMUFwaRZEzOpTg=; b=CecRDwlrzrDok0fO4YW98r1xaytb4Mo+fKUSdn4ujqX0HY/sUAIrj5Q95LvuHTfh3V yuyMZjdqv9sr0Du/Uj+J+payzLU8m6tuMHyCzn6udbqUbMEKrpoN4MV2XhULgjoSr5R2 XUoaZ4lTcAiI/BpP1J6nhnUYUbZAkK8CZ+p3UKsfHzuKpbK4myDvbkm8tLT/0ZCHhtGg AiYV+BcqIqPjh2RkL9MexwVRBQko8mAtOTykinhIV+/iR1171QOtAF5DHv7MqfVTITBD 3IAROMCTRwTnbpAm4ScVJ/mZ6+oiug9NZx0G9a5WZC9doT24qJKYecMbsbA+ZDFx+GZs Uv/g== X-Gm-Message-State: AOAM531BXDZdrZzwLpwe6uLXNII9s22OfAxVjKVjODbQae79iLQkbCXa ChIt3flDFyVvIeGGeZPk8hk= X-Google-Smtp-Source: ABdhPJxfFuunKLuYEM0yR1kHFngwA+u3ljU4hHA2rRC2yknzPx4+HY108YRLQnqv4A73w3xJwOxzfw== X-Received: by 2002:a2e:808b:0:b0:243:f7ef:fbb6 with SMTP id i11-20020a2e808b000000b00243f7effbb6mr8841775ljg.30.1645894679320; Sat, 26 Feb 2022 08:57:59 -0800 (PST) Received: from [192.168.1.11] ([94.103.229.64]) by smtp.gmail.com with ESMTPSA id g41-20020a0565123ba900b004437f6677e6sm491579lfv.245.2022.02.26.08.57.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Feb 2022 08:57:58 -0800 (PST) Message-ID: <1c44c931-5b90-03d8-94bd-5e68682c4787@gmail.com> Date: Sat, 26 Feb 2022 19:57:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH 3/6] staging: r8188eu: cnt is set but not used Content-Language: en-US To: Martin Kaiser , Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20220226144843.1118951-1-martin@kaiser.cx> <20220226144843.1118951-4-martin@kaiser.cx> From: Pavel Skripkin In-Reply-To: <20220226144843.1118951-4-martin@kaiser.cx> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Martin, On 2/26/22 17:48, Martin Kaiser wrote: > In function recv_func, the cnt variable is set but not used. > It can be removed. > > Signed-off-by: Martin Kaiser > --- > drivers/staging/r8188eu/core/rtw_recv.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c > index 0144c4642911..9a2e2bc2e294 100644 > --- a/drivers/staging/r8188eu/core/rtw_recv.c > +++ b/drivers/staging/r8188eu/core/rtw_recv.c > @@ -1798,11 +1798,9 @@ static int recv_func(struct adapter *padapter, struct recv_frame *rframe) > if (check_fwstate(mlmepriv, WIFI_STATION_STATE) && > psecuritypriv->busetkipkey) { > struct recv_frame *pending_frame; > - int cnt = 0; > > pending_frame = rtw_alloc_recvframe(&padapter->recvpriv.uc_swdec_pending_queue); > while (pending_frame) { Just out of curiosity: is this thing infinity loop? > - cnt++; > recv_func_posthandle(padapter, pending_frame); > } Nit: bracers can be removed > } With regards, Pavel Skripkin