From: Andrew Lunn <andrew@lunn.ch>
To: Jakub Kicinski <kuba@kernel.org>
Cc: kyle.switch@motor-comm.com, Frank.Sae@motor-comm.com,
hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ming.xu@motor-comm.com,
xiaolin.xu@motor-comm.com, jianmin.wang@motor-comm.com,
jie.han@motor-comm.com
Subject: Re: [PATCH net-next v9] net: phy: Add driver for Motorcomm Quad 2.5GbE phy
Date: Tue, 11 Aug 2026 23:38:42 +0200 [thread overview]
Message-ID: <1c494ee1-4b57-4dfa-b99e-0870a74f6efd@lunn.ch> (raw)
In-Reply-To: <20260810222616.906676-2-kuba@kernel.org>
> [Severity: High]
> Does swapping the global register space and then releasing the mdio bus lock
> expose other generic phylib operations to silent data corruption?
I would suggest you look at how EEE is handled. phylib often goes
direct to the hardware and accesses the registers, without calling
into the driver first. So it is missing the lock you just added.
I would suggest you audit phylib and see if there are other cases
where it calls genphy_ functions, e.g if the driver does not provide a
method in phy_driver.
Andrew
prev parent reply other threads:[~2026-08-11 21:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 11:44 Kyle Switch
2026-08-10 22:26 ` Jakub Kicinski
2026-08-11 21:38 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c494ee1-4b57-4dfa-b99e-0870a74f6efd@lunn.ch \
--to=andrew@lunn.ch \
--cc=Frank.Sae@motor-comm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jianmin.wang@motor-comm.com \
--cc=jie.han@motor-comm.com \
--cc=kuba@kernel.org \
--cc=kyle.switch@motor-comm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ming.xu@motor-comm.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiaolin.xu@motor-comm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®