From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753795AbcGYTST (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Jul 2016 15:18:19 -0400
Received: from mout.gmx.net ([212.227.15.18]:60125 "EHLO mout.gmx.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752867AbcGYTSQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Jul 2016 15:18:16 -0400
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        linux-wireless@vger.kernel.org
In-Reply-To: 702302e0-0056-9fff-7bb4-f54d4a0b0afc@users.sourceforge.net
From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Subject: Re: [PATCH 3/3] staging: wilc1000: Reduce scope for a few variables
 in mac_ioctl()
Message-ID: <1c4cac35-dded-ea88-45aa-3f8ac098289d@gmx.de>
Date: Mon, 25 Jul 2016 21:17:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:N4A4FQx1dPjY+DmbU9sXKuXR0K3m2ysAoQcrcwCScniiSgl4VHT
 kA6nqBjBV5s40ymBwbgmA6v3zB1y88jwdLpZD3mH6caFr9Af2d/Kz3PbK+gakFlnNVNxRD1
 yaB2hF5pILtjT7cdIeCy00cY2P7Nbfv6LmH1RFXSkkObBzRrqWimK2FGJu67vVm2nuqaQ2X
 YYFbASr6OEiwU07c1VrTA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:PWZaeR1bAGE=:oSyXiA8Ae9jec1EIn4KU2p
 BxBXLm2U7CqYIIHGkKuORgR/AXAmiNv0YLUwv1h+UiBdkhxOYS41TLhnQ4vuA6O0yFXHXwavp
 qFoT3Kd91RzDV4bpWMm/Fb9fN4f18z7qHY2g9+ZQhGNBrRw63WT5Vv4GZ2GyjvtiTn7IBb7o9
 rO3uiXpIxkIekDV0A+Z6+xETPAGOHz1j/pQunLGRHT/pHPhY2Tz/EzP/ik2TmPcogBlTayynY
 C7cWx2scoSjbdMXehwpBSRhxCLb3zTyDnLEvOSiC/PsJ3PNOK4bbNs/rJPTfJtCdbSGZnCP6J
 RvZE5SrmdM2Al8t9wk95y6t8JogIMjcDYUfLBZ6vgyuYF3R1IeN0sSljvIoI6oRgUHDUIjtAk
 zObIh6tVL7ScAyVbQH0vuE+8PcQXWIioWieEAEjqzzYo0LmnpuAv3AJzAVPtlMlmGKF7QqICg
 GayMXz+81/lsT8zvX78mJGD91N7BkkWb2fr/CjyAIOWaAxa2BIFCXmXBB62EkxcYXB4Abmv6C
 qOQDcJrFpkNhRgXIE69Wfm0WdmMQ1fBasNcPz2f6Uy/C9ivqc+cQgL2eL/KKqtwzRD+EITSGd
 RO7hlCfSWdgGgkKGq7Io+WpGBJzpqczfOtYYHUw4AsCYCoNWp9O2tkHtJpf5/hkKXf/a6RyI2
 tLcFEcBg/PGjsG/SQx52Pa83DJlkOEv2vBPfBAz6QCwVtLkz0FHvoglhMAwMMDMDEAyaAPspj
 C3rx0VIAOguzhcUhhp08zqsiyj1ViE6sYGgsyMV8+UJmP+bFQLkiDzgFJ+SBDXix4dKujucqY
 QqGYK4M
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>  
> -			if (strncasecmp(buff, "RSSI", length) == 0) {
> +			if (strncasecmp(buff, "RSSI", 0) == 0) {
> +				s8 rssi;
> +

Um, please think a second about if it makes any sense at all to compare 
zero chars of two strings.

Lino