From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F372214EC55 for ; Thu, 21 Nov 2024 07:50:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732175426; cv=none; b=sRklfPLatgM1Y2zGl4L7sDp4n+SzCmWuL7J1kHuIiDurc30Vb9/YIo6RX4FaIgeiw0paF/0cga42ElnjOpYtCJ2QESXTHtG9JpNzkpp9CV3VpkRiZGk48zhMnesa/Np5TzJR5E8XndtGgb/Ip2Aa1bhNghsxTyeU12XohFgZnig= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732175426; c=relaxed/simple; bh=wM1iOQ6QD63YeR1jXPE90LoDUMaLyTJ5BbHjBNMp3YE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PfKfbet666JTL5OwwCUaUKTrNOl0zoKOYMgaaUwz++EBlqjWl6ZhgSpm9/wkDQzdVBldqBSavGxreBgvileBgNAoxtOvoqMbuZ3KsF3ODbRHj15XrpJed27q3OeC3FVHU8+5hyyUBKVjx7jOJyXPRfYXrxdG/eeofqCWVNOF+BI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ld4yVYJ6; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ld4yVYJ6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732175424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0S+T9jzGoJUnwkGSTavJ+CCZs4lI12ayfbKOcBesSfA=; b=Ld4yVYJ6YAdFJLyHDDWnwGiCzDDqEe2Prlf0FQBZAugoFIejfySKpUq0L2ZaixnMmjyGGO 0DgT2NtMag9AOtGEm7zFcTq3H6kqy/MiotqtrSxAmVVKTykJtZNYy5GUHC/42EYonAca7a qb+nDKW2PN7suZStRWqIPP4JfF/TjuI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-523-toYjwMVxO4KUH0G1-AoaZg-1; Thu, 21 Nov 2024 02:50:22 -0500 X-MC-Unique: toYjwMVxO4KUH0G1-AoaZg-1 X-Mimecast-MFC-AGG-ID: toYjwMVxO4KUH0G1-AoaZg Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4314c6ca114so3945095e9.1 for ; Wed, 20 Nov 2024 23:50:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732175421; x=1732780221; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0S+T9jzGoJUnwkGSTavJ+CCZs4lI12ayfbKOcBesSfA=; b=p58gsNtwGE8DX7imim+ITbYPOWdFrl3L4M36vgPXyOscztglrZBXsShE+Xx6XZxIdB 9btqv7BvSfpR3MNvDz1C9w26fdNca8bgY/qxPW6Na4ea6+X3XV501fduY4OzDgGvzRLT zi/DELYa53Y3IDSXUsDstInI2I4XL6tNiems+wGPUM7Qm91MFMs3dIcK5KE4WHDZFR+w NrK0cTlQ2yolo6SKH5dF+Cgc6iqgrs66Ugz7OUkbbu/8K7f6AFiXCTpxUkbLsxHb/9UQ dhNsWxTp0pzXy0Io8dPafiRWmcHzRnUmrgstY1XXynR0QQmXy//v7MylSiTt1EtYQSgu sDEw== X-Forwarded-Encrypted: i=1; AJvYcCVFOD3lUzdhpyxKrDwRCtPVkY00bpoRPBRxw7WO/8+PxrYAdFDk9G7/btKd/YKae5LCHaoCHBRGnCZvwcE=@vger.kernel.org X-Gm-Message-State: AOJu0YyCoxytnu0hd35eJWi93Bh+FIO/xn0Sx2UOd8Ji8FwE1MYHDZe6 FBCRkhNIyMzig4hgXEaVgIa7eS5WAqGdZCf8+3zp1lzrJn3nVY8c8QqAZO1EmaPu7LNlykhQARK S0gHGWx1sm/eo/c0RV7tlm1/64Rmub5F3fEhOwyBym4Wde8m2h66PsTdfkhFPAA== X-Received: by 2002:a05:600c:5125:b0:430:582f:3a9d with SMTP id 5b1f17b1804b1-4334f01f731mr44704295e9.26.1732175421284; Wed, 20 Nov 2024 23:50:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IHhYF/d2fapOg1q5yG0D1rBPToLlrBhF2TIDsM+dmIvzhgUy6ZfNWGyrQrrlZIRDBN2+NP6UA== X-Received: by 2002:a05:600c:5125:b0:430:582f:3a9d with SMTP id 5b1f17b1804b1-4334f01f731mr44704215e9.26.1732175421004; Wed, 20 Nov 2024 23:50:21 -0800 (PST) Received: from [192.168.88.24] (146-241-6-75.dyn.eolo.it. [146.241.6.75]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38254910e77sm4075444f8f.59.2024.11.20.23.50.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Nov 2024 23:50:19 -0800 (PST) Message-ID: <1c5d7ea9-ba80-483b-aa30-02ed7fb110d9@redhat.com> Date: Thu, 21 Nov 2024 08:50:18 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH][next] octeontx2-pf: remove redundant assignment to variable target To: Colin Ian King , Sunil Goutham , Linu Cherian , Geetha sowjanya , Jerin Jacob , hariprasad , Subbaraya Sundeep , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241119175236.2433366-1-colin.i.king@gmail.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20241119175236.2433366-1-colin.i.king@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/19/24 18:52, Colin Ian King wrote: > The variable target is being assigned a value that is never read, it > is being re-assigned a new value in both paths of a following if > statement. The assignment is redundant and can be removed. > > Signed-off-by: Colin Ian King ## Form letter - net-next-closed The merge window for v6.13 has begun and net-next is closed for new drivers, features, code refactoring and optimizations. We are currently accepting bug fixes only. Please repost when net-next reopens after Dec 2nd. RFC patches sent for review only are welcome at any time. See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle