From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8327C433DF for ; Sun, 24 May 2020 19:27:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 945082075F for ; Sun, 24 May 2020 19:27:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590348445; bh=FzOHq6c7QFOy1Q1Z7apPD+mOvKHo4MaeuHH98f8ZlGY=; h=Subject:From:To:Cc:References:Date:In-Reply-To:List-ID:From; b=JTiqdIGPP88TPPAeSgrLab1VACVa5oUUNqilb4h3hXvqmjOd+1qNOZ4Hr2zgR4zO0 Ibmn0qSukwV5qtYvpRJSI/ov4p2UMqaJqE6DYThtGxzApEpQ8NwEXvGvc3Xzh8wo2h EExu9mDlOTAV0DmVBH3UlueTu8QcyAQGVa7Ui870= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388446AbgEXT1Z (ORCPT ); Sun, 24 May 2020 15:27:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:55946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387992AbgEXT1Y (ORCPT ); Sun, 24 May 2020 15:27:24 -0400 Received: from [192.168.0.50] (89-70-52-201.dynamic.chello.pl [89.70.52.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1FEDD2075F; Sun, 24 May 2020 19:27:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590348444; bh=FzOHq6c7QFOy1Q1Z7apPD+mOvKHo4MaeuHH98f8ZlGY=; h=Subject:From:To:Cc:References:Date:In-Reply-To:From; b=idep3C1p3bUspKEkJE9ZaG/Iyyx+xA2laeDujyI4XQGgtI/65qg8R1KQuPagXDGdP miAPl5OSeZrcqJK0V1wZtER5GGrnQefy/1rZIzU1QqY0xfimi2aJNCpulZschSvS8x OMvyuMEbgZiOcPc3swiHqO2vbjkNxKraXLiLwLGM= Subject: Re: [PATCH V2] media: s3c-camif: fix missing disable in tegra_adma_probe(). From: Sylwester Nawrocki To: wu000273@umn.edu Cc: mchehab@kernel.org, linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, kjlu@umn.edu References: <20200524034616.31625-1-wu000273@umn.edu> <9b1cdd76-1fbf-c66b-a8e1-929ce2aba791@kernel.org> Message-ID: <1c635607-b3b1-decc-a395-5d0464a59e17@kernel.org> Date: Sun, 24 May 2020 21:27:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <9b1cdd76-1fbf-c66b-a8e1-929ce2aba791@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/24/20 21:03, Sylwester Nawrocki wrote: > On 5/24/20 05:46, wu000273@umn.edu wrote: >> From: Qiushi Wu >> >> "pm_runtime_enable()" was not handled by "pm_runtime_disable()" >> after a call of the function “pm_runtime_get_sync()” failed. >> Thus move the jump target “err_pm” before calling function >> "calling pm_runtime_disable()". >> >> Fixes: babde1c243b2 ("[media] V4L: Add driver for S3C24XX/S3C64XX SoC >> series camera interface") >> Signed-off-by: Qiushi Wu >> --- >> >> V2: improving commit messages. > > Thanks for the patch. It seems you have got typo in the subject line. > With tegra_adma_probe changed to s3c_camif_probe feel free to add: > > Reviewed-by: Sylwester Nawrocki I just noticed this patch https://patchwork.linuxtv.org/patch/63976 which includes your fix and handles one more issue. Thus it might be better to apply the patch from Dinghao Liu instead.