From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D433C04AA8 for ; Wed, 1 May 2019 22:01:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D89F821734 for ; Wed, 1 May 2019 22:01:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726343AbfEAWBz (ORCPT ); Wed, 1 May 2019 18:01:55 -0400 Received: from mga05.intel.com ([192.55.52.43]:31714 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726137AbfEAWBy (ORCPT ); Wed, 1 May 2019 18:01:54 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 May 2019 15:01:53 -0700 X-ExtLoop1: 1 Received: from yyu32-desk1.sc.intel.com ([143.183.136.147]) by orsmga002.jf.intel.com with ESMTP; 01 May 2019 15:01:49 -0700 Message-ID: <1c69263279be0b2f6582e58a0bf28bc213d94693.camel@intel.com> Subject: Re: [PATCH] binfmt_elf: Extract .note.gnu.property from an ELF file From: Yu-cheng Yu To: Matthew Wilcox Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin Date: Wed, 01 May 2019 14:54:23 -0700 In-Reply-To: <20190501213709.GD28500@bombadil.infradead.org> References: <20190501211217.5039-1-yu-cheng.yu@intel.com> <20190501213709.GD28500@bombadil.infradead.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.1-2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2019-05-01 at 14:37 -0700, Matthew Wilcox wrote: > On Wed, May 01, 2019 at 02:12:17PM -0700, Yu-cheng Yu wrote: > > +++ b/fs/Kconfig.binfmt > > @@ -35,6 +35,10 @@ config COMPAT_BINFMT_ELF > > config ARCH_BINFMT_ELF_STATE > > bool > > > > +config ARCH_USE_GNU_PROPERTY > > + bool > > + depends on 64BIT > > I don't think this is right. I think you should get rid of the depends line > and instead select the symbol from each of argh64 and x86 Kconfig files. That makes sense. Thanks! Yu-cheng