From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85B1AC5DF63 for ; Wed, 6 Nov 2019 16:21:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 583DB2067B for ; Wed, 6 Nov 2019 16:21:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="C+qMW4kV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732200AbfKFQVP (ORCPT ); Wed, 6 Nov 2019 11:21:15 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:55772 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727244AbfKFQVO (ORCPT ); Wed, 6 Nov 2019 11:21:14 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA6GJ4nO093660; Wed, 6 Nov 2019 16:19:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=BHF9V2BMWD9Pr0Y6kWZezyM7R00JEGZI1MLT3+/esck=; b=C+qMW4kV6AiiID3zRA4eFEh1iX0V0jb92IUfDGDnvp08JPssVjd22upG/uurPQLSzCRK sEqo02HI/+QUjqWU+BQlQJjYOrSivMJoo9YxcZoR1hezK42jfyOUcEwZd9BF23XvwDxQ EzJMjEHQIJcavsnqqvlcYLjRuWb7vDMf1v2+3tw0m3pGB2rEymZ/WtqpYhzJJYWhd8CF w7UkfPdGvZ2hc5TnypS8JMJ3DOHneEDuQ3GWcO09wHdZ22sSh5UeKSqQ0wqokcDJdXry HUQntv52EIQZQyQXrhRSiujZyEJnMzwH1/MnaNjYs2+15VSVRRbfUdVI/kvq/eY8R2KP +Q== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 2w12erfqqj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 06 Nov 2019 16:19:50 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA6GItWC111870; Wed, 6 Nov 2019 16:19:49 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 2w35prbnqq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 06 Nov 2019 16:19:49 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id xA6GJmvd024109; Wed, 6 Nov 2019 16:19:48 GMT Received: from [10.39.238.145] (/10.39.238.145) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 06 Nov 2019 08:19:47 -0800 Subject: Re: [patch V2 05/17] x86/traps: Make interrupt enable/disable symmetric in C code To: Thomas Gleixner , LKML Cc: x86@kernel.org, Peter Zijlstra , Andy Lutomirski , Will Deacon , Paolo Bonzini , kvm@vger.kernel.org, linux-arch@vger.kernel.org, Mike Rapoport , Josh Poimboeuf , Miroslav Benes References: <20191023122705.198339581@linutronix.de> <20191023123118.084086112@linutronix.de> From: Alexandre Chartre Organization: Oracle Corporation Message-ID: <1c6ad81c-9518-909a-03d2-e2a2cf53240d@oracle.com> Date: Wed, 6 Nov 2019 17:19:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20191023123118.084086112@linutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9433 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=776 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1911060157 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9433 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=856 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1911060157 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/23/19 2:27 PM, Thomas Gleixner wrote: > Traps enable interrupts conditionally but rely on the ASM return code to > disable them again. That results in redundant interrupt disable and trace > calls. > > Make the trap handlers disable interrupts before returning to avoid that, > which allows simplification of the ASM entry code. > > Originally-by: Peter Zijlstra > Signed-off-by: Thomas Gleixner > --- > arch/x86/kernel/traps.c | 32 +++++++++++++++++++++----------- > arch/x86/mm/fault.c | 7 +++++-- > 2 files changed, 26 insertions(+), 13 deletions(-) > Reviewed-by: Alexandre Chartre alex.