From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCF40198A06 for ; Wed, 10 Jul 2024 16:37:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720629422; cv=none; b=ay9t6F1j9XhlcHTZH0RR+0qtfCEub6G6uAa3jCmLYSvSQFxkc3hP2aueuwjArBp18T0JxHey5ryF1/GFWJ3nQbWJGoK7h9YctDZ0Jxhd+DvlCDtdqykLQKoXETdrYBsk4IWlnIZK37SCdCpwkij1vttIjkaCsA/Lgxu0YvzihPw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720629422; c=relaxed/simple; bh=+9WXWxoYOKWamD+vE5uwNUduTJzyXrMb8PWgNp0n1rI=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=banJNbojIotz+iHi2lm90wvhB1FORA22Ahzml0VFb8AEsgUbO0EXjpp6slnjlDDdiZu9NQo7TyH0l5XGD7E65qbJHbpxWwn/xqU95lZ7Nj27jLhWxBZyBjCBPaSYOV81Q1i5MgdVAvwERh1OJDnly+GachxwhQODIhGPx7JfFBo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=BSkFg4V5; arc=none smtp.client-ip=209.85.219.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BSkFg4V5" Received: by mail-yb1-f177.google.com with SMTP id 3f1490d57ef6-e04196b7603so2684148276.0 for ; Wed, 10 Jul 2024 09:37:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1720629420; x=1721234220; darn=vger.kernel.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=JdEk/xS42cer+nsNbr3GxVg6aR55CredoMdTWrvWjPQ=; b=BSkFg4V5bFLsMqmzBCoWeyfGKxM4GEjv10v0uDp7Xpz0Htq7tTZMJSqJwFKL0nOaEU z6hAlWW9F5YivMz50UtlcQLQ4Lxmhv+Kk83Y2528Aazpp/JdYaVPQJpcYSb8r2Wvo4wM rMO1vWqhxGHFeRRvoNXj7QiSCMlBYFVClfx1szf0QwAkxhB1tTLTvEeN9svb6/PIHgEK +eM7TfZk9bY4qoS9ZYqeN3N7VX/yUpO1MAAvDtb2JzLaNdCW2BcFBPmMbB7C6lIq3Qb2 pQiK3KzAfJUhsV1Aqk2cO5ZNwFmBVRIFQx0GjwTC9p3pWLsUKy35kHf+qEs9UN4VyK+a hS1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720629420; x=1721234220; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JdEk/xS42cer+nsNbr3GxVg6aR55CredoMdTWrvWjPQ=; b=pUCwNmRGPX6oWazfFhESvMzoIYaM5sDfWUe/PWPXymq4M2Tn8eBloJBHXtmyHZDN9P IDJNfo7IZp0aTPXLhPGwFO7nQQwhwjJefzOKNbDoXwnVLdbLAUZnqtTnhMO8aZUlsM5M iFZnBmG7k8p3eoS05lTVhgX9dy8ON07AEvn4QI4YiNfKze8whJWXsruRL7xsxKrcM+bM 7mVusj4UCmkd2+oH5gVJS/yMjbPurXQwzmevQvAwQxGgfcAnJpxgP1nsefCvFfjyx++z O3rho7XIcGT2umdat9Onr5enRO4c1UO/j/49AjPXNUu7S3DU+uHrXpZOrN/hRELy9leB j9+Q== X-Forwarded-Encrypted: i=1; AJvYcCUOc1qn63SKNBbf0Y9OQPOaciyL+zdHVTDIuYjdeuaw8BevF0vCuFA/0KjYW9zGN7YXFk0waLfZ2I9ymjmm/tyVcmgMUjtHJ2DHeBtL X-Gm-Message-State: AOJu0YxSjcDjmcnFqp85TZHbCSIXyP1emg4FAzbEX8nu9KWtsf+NJGQy fMu72kiGeHOR7JyNHW9n7ezIESP9rg6j49vwUMaUfqo84LdOH4heh2zfNxd/+g== X-Google-Smtp-Source: AGHT+IHmlzxMBt1I02mYgCVVFfyZwoIJo3cnM1aEwxkR/fsMcy2EzuwB+V0Pzq8JtvZgB7eiWJDgSg== X-Received: by 2002:a25:6808:0:b0:df7:8dca:1ef2 with SMTP id 3f1490d57ef6-e041b0788b3mr7334664276.34.1720629419734; Wed, 10 Jul 2024 09:36:59 -0700 (PDT) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e041a99e948sm655418276.63.2024.07.10.09.36.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 09:36:59 -0700 (PDT) Date: Wed, 10 Jul 2024 09:36:48 -0700 (PDT) From: Hugh Dickins To: Paolo Abeni cc: Hugh Dickins , Sagi Grimberg , Jakub Kicinski , Eric Dumazet , Thorsten Leemhuis , regressions@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds Subject: Re: [PATCH v3] net: fix rc7's __skb_datagram_iter() In-Reply-To: <934ac0b8491ec56dd35b9f0ab7422daa1926c4df.camel@redhat.com> Message-ID: <1c72ac52-9830-c2f9-5a14-d1487da8fabf@google.com> References: <58ad4867-6178-54bd-7e49-e35875d012f9@google.com> <51b9cb9c-cf7d-47b3-ab08-c9efbdb1b883@grimberg.me> <66e53f14-bfca-6b1a-d9db-9b1c0786d07a@google.com> <934ac0b8491ec56dd35b9f0ab7422daa1926c4df.camel@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 10 Jul 2024, Paolo Abeni wrote: > On Wed, 2024-07-10 at 08:36 -0700, Hugh Dickins wrote: > > X would not start in my old 32-bit partition (and the "n"-handling looks > > just as wrong on 64-bit, but for whatever reason did not show up there): > > "n" must be accumulated over all pages before it's added to "offset" and > > compared with "copy", immediately after the skb_frag_foreach_page() loop. > > > > Fixes: d2d30a376d9c ("net: allow skb_datagram_iter to be called from any context") > > Signed-off-by: Hugh Dickins > > Reviewed-by: Sagi Grimberg > > --- > > v3: added reviewed-by Sagi, try sending direct to Linus > > V2 is already applied to the 'net' tree and will be included in our > next 'net' PR, coming tomorrow. > > It looks like the netdev bot decided it needed an holiday (or was > fooled by the threaded submission for v2), so no notification landed on > the ML. > > @Hugh: next time please check the current tree status or patchwork > before submitting a new revision. And please avoid submitting the new > version in reply to a previous one, it makes things difficult for our > CI. Ah, great, thanks. Yes, I'd heard only silence (and was worried because, although I only saw the effect of this on 32-bit, suspect it could cause lots of obscure trouble more generally). Hugh