From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751404AbdHFTUc (ORCPT ); Sun, 6 Aug 2017 15:20:32 -0400 Received: from mout.web.de ([212.227.17.11]:54746 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751333AbdHFTUa (ORCPT ); Sun, 6 Aug 2017 15:20:30 -0400 Subject: [PATCH 2/5] mtip32xx: Improve a size determination in two functions From: SF Markus Elfring To: Bart Van Assche , Jens Axboe , Johannes Thumshirn , Ming Lei , Sagi Grimberg Cc: LKML , kernel-janitors@vger.kernel.org References: <524db5d1-1411-a839-6461-7c33403c1843@users.sourceforge.net> Message-ID: <1c74be0c-6457-2f59-54b2-5e4fe1a70ace@users.sourceforge.net> Date: Sun, 6 Aug 2017 21:20:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <524db5d1-1411-a839-6461-7c33403c1843@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:0/rrfrL+hvmznVWP1jaNaaVLXWEQ4Vk3PZLl34QepMCPIuBrz1D euyVOkgd34bhTMogo+KviC1/g79i4pCDQYTW9PJGxukFWuUvWXwKsMVRX0TOHkqx1LEUb3i Y2FGCbJm4+CElywmLtctt2Bhf0700WiCwZswia67WJeapkdYAxVVOyaTJqFXp3nJwcSnJtG j8/FYPU1hZIKO+Y7nI5PA== X-UI-Out-Filterresults: notjunk:1;V01:K0:olaLVV4bPGo=:QtmpcyXwjc45lXCuT8Cki3 h7tWuHwio5WfKODhBXO+XjgDMf4YvG4GsSLEBCIsvTgbQzkkwy94qUfIAM5En8ex0tS9reuU4 K5SNoWqGY6mh16da/iE6zWlHyw3Owybb73zFd7iCs69VY3yeYXI/lIoms6TWoiDi+cAwcqSk2 m43WPJIgUb4REen4v4t9xD773hSGJLdC/M2SiC4uIyLinF92Jm0gD+oEyII7x4OQiTQ9XmVjk Jz2H3tMyohpQZsfJMgpunu5saf+XEznrzjr/DxiqYkKeF5P93itqR8/P8bhWxhsLorrlSHH2w ei2EfiwBZU0bj0458WEq5RFOk668sfCBOXlAdaJoMHFZRVAXRQTUC4Rpi5AvcvFDj3bw7Ury3 pb5rsRYvQTygjkeGLHnf2EWWxb3P0yZWMY5U3ML1nGMF300PyKASeod1NGReyhQtgURZdXlbz p1c89CJ7yBE3aIl9FSNS+ozEk4uBakCSMEeN6Nq12Ga8vkLDXr+CsjVPzSwOLDYQF3lC3I1b1 Mt4+PNStmh2VmrfDRiYXEQEv9EVOaE+XY6KnzCLH0wj46aEZCMdlwemFvNNZW2Hfa0deyZp/T oed6gtx8LmtuluupD0HtjqybQRlIgefh9qjBvSKhMpoboylFs607T0a2D4V3Qa0Vnu1Uyj2NU p8uCwVyaleiiRM7sD/x+T2da4KYvtqFA9SuRncZiH29CN4BgXe9sCPx4F5p712IOcqkb0sxnd hyfPzdJQhvv7a9NAqYD8ZnmQVCYVxybsJqY0agN0iBtTo3O3M8gHsaADoO5v+qJJHfkO0CcWg gQE4BaPdh986msqQF3CQVeO8CM1z5ewLMuf8WgpYPMvlNQUk6I= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 6 Aug 2017 19:54:49 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/block/mtip32xx/mtip32xx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c index 5ccbab619e57..97cbf39b4273 100644 --- a/drivers/block/mtip32xx/mtip32xx.c +++ b/drivers/block/mtip32xx/mtip32xx.c @@ -3019,9 +3019,7 @@ static int mtip_hw_init(struct driver_data *dd) num_command_slots = dd->slot_groups * 32; hba_setup(dd); - - dd->port = kzalloc_node(sizeof(struct mtip_port), GFP_KERNEL, - dd->numa_node); + dd->port = kzalloc_node(sizeof(*dd->port), GFP_KERNEL, dd->numa_node); if (!dd->port) return -ENOMEM; @@ -4215,7 +4213,7 @@ static int mtip_pci_probe(struct pci_dev *pdev, my_node, pcibus_to_node(pdev->bus), dev_to_node(&pdev->dev), cpu_to_node(raw_smp_processor_id()), raw_smp_processor_id()); - dd = kzalloc_node(sizeof(struct driver_data), GFP_KERNEL, my_node); + dd = kzalloc_node(sizeof(*dd), GFP_KERNEL, my_node); if (!dd) return -ENOMEM; -- 2.13.4