From: Cheng Jiang <quic_chejiang@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
"Rob Herring" <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
Balakrishna Godavarthi <quic_bgodavar@quicinc.com>,
Rocky Liao <quic_rjliao@quicinc.com>
Cc: <linux-bluetooth@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] dt-bindings: bluetooth: Add qca6698 compatible string
Date: Wed, 30 Oct 2024 17:44:55 +0800 [thread overview]
Message-ID: <1c7fb392-101e-4c28-be4c-dc8534a5b28a@quicinc.com> (raw)
In-Reply-To: <1e7d2b10-f170-4996-9ac5-3104cfff21d5@kernel.org>
Hi Krzysztof,
Sorry, I miss the compatibility part and will submit a new version.
On 10/30/2024 5:26 PM, Krzysztof Kozlowski wrote:
> On 30/10/2024 09:57, Cheng Jiang wrote:
>> Add QCA6698 qcom,qca6698-bt compatible strings.
>>
>> Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com>
>> ---
>> .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>> index 7bb68311c609..8ae1827e6a70 100644
>> --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>> +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>> @@ -24,6 +24,7 @@ properties:
>> - qcom,wcn3991-bt
>> - qcom,wcn3998-bt
>> - qcom,qca6390-bt
>> + - qcom,qca6698-bt
>
> This looks incomplete. Does this device has really all these supplies?
> Look at the binding.
>
> Best regards,
> Krzysztof
>
prev parent reply other threads:[~2024-10-30 9:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 8:57 Cheng Jiang
2024-10-30 9:26 ` Krzysztof Kozlowski
2024-10-30 9:44 ` Cheng Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c7fb392-101e-4c28-be4c-dc8534a5b28a@quicinc.com \
--to=quic_chejiang@quicinc.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=quic_bgodavar@quicinc.com \
--cc=quic_rjliao@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®