mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Yang Siyuan <hsyysy@163.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH RESEND] reset: core: honour optional resets when the GPIO fallback is unusable
Date: Tue, 17 Nov 2026 10:49:55 +0100	[thread overview]
Message-ID: <1c82364fad5948bc1154ce92f029324cc3cddf26.camel@pengutronix.de> (raw)
In-Reply-To: <20261117092008.12130-1-hsyysy@163.com>

On Di, 2026-11-17 at 17:20 +0800, Yang Siyuan wrote:
> __fwnode_reset_control_get() honours RESET_CONTROL_FLAGS_BIT_OPTIONAL for
> every failure source except the reset-gpio fallback: when
> __reset_add_reset_gpio_device() fails, the error is returned even for an
> optional reset.

RESET_CONTROL_FLAGS_BIT_OPTIONAL is only meant to replace -ENOENT with
NULL, not other error codes. See the kerneldoc of
reset_control_get_optional_exclusive():

  "If the requested reset is not specified in the device tree, this
   function returns NULL instead of an error."

> This is reachable on Allwinner SoCs, whose pinctrl uses three-cell GPIO
> specifiers. The reset-gpio fallback only supports two cells, so it
> returns -ENOENT and a consumer asking for an optional reset fails to
> probe instead of falling back to its own GPIO handling. mmc-pwrseq-simple
> on the Anbernic RG35XX family hits this: its wifi_pwrseq node has
> reset-gpios but no resets, so the SDIO WiFi adapter never probes.
> 
> Keep propagating -EPROBE_DEFER, since the GPIO provider may be available
> later, but treat any other failure as "no reset" when the request is
> optional.
> 
> Fixes: c721f189e89c ("reset: Instantiate reset GPIO controller for shared reset-gpios")
> Cc: stable@vger.kernel.org
> Signed-off-by: Yang Siyuan <hsyysy@163.com>
> ---
>  drivers/reset/core.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/reset/core.c b/drivers/reset/core.c
> index 38e189d04..f2375dd17 100644
> --- a/drivers/reset/core.c
> +++ b/drivers/reset/core.c
> @@ -1181,7 +1181,17 @@ __fwnode_reset_control_get(struct fwnode_handle *fwnode, const char *id, int ind
>  		ret = __reset_add_reset_gpio_device(fwnode, &args);
>  		if (ret) {
>  			fwnode_handle_put(args.fwnode);
> -			return ERR_PTR(ret);
> +
> +			/*
> +			 * The GPIO provider may just not be available yet, so
> +			 * EPROBE_DEFER must always be propagated. Any other
> +			 * failure means that the fallback cannot be used,
> +			 * which is not an error for an optional reset.

No, it is very much an error if an optional reset is specified in the
device tree but can't be used.

The /*TODO*/-marked -ENOENT return in __reset_add_reset_gpio_device()
is already papering over the issue.

> +			 */
> +			if (ret == -EPROBE_DEFER || !optional)
> +				return ERR_PTR(ret);
> +
> +			return NULL;

I think instead this could be replaced with:

 		if (ret) {
 			fwnode_handle_put(args.fwnode);
+			if (ret == -ENOENT && optional)
+				return NULL;
			return ERR_PTR(ret);

regards
Philipp

  reply	other threads:[~2026-11-17  9:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  9:20 Yang Siyuan
2026-11-17  9:49 ` Philipp Zabel [this message]
2026-11-17  9:55 ` [PATCH v2] reset: core: honour optional resets when the GPIO fallback returns -ENOENT Yang Siyuan
2026-11-17 10:30   ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c82364fad5948bc1154ce92f029324cc3cddf26.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=hsyysy@163.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®