From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C327EB64DA for ; Mon, 10 Jul 2023 12:32:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231876AbjGJMcm (ORCPT ); Mon, 10 Jul 2023 08:32:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231651AbjGJMcl (ORCPT ); Mon, 10 Jul 2023 08:32:41 -0400 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15949DD; Mon, 10 Jul 2023 05:32:39 -0700 (PDT) Received: from [2a02:8108:8980:2478:8cde:aa2c:f324:937e]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1qIq45-0006AD-MA; Mon, 10 Jul 2023 14:32:29 +0200 Message-ID: <1c85c4d6-7097-bc0a-d0ca-ebe234d63ece@leemhuis.info> Date: Mon, 10 Jul 2023 14:32:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 0/2] perf probe: fix regression introduced by switch to die_get_decl_file Content-Language: en-US, de-DE To: =?UTF-8?Q?Georg_M=c3=bcller?= , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , "Masami Hiramatsu (Google)" Cc: regressions@lists.linux.dev, Arnaldo Carvalho de Melo , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230628084551.1860532-3-georgmueller@gmx.net> From: "Linux regression tracking (Thorsten Leemhuis)" Reply-To: Linux regressions mailing list In-Reply-To: <20230628084551.1860532-3-georgmueller@gmx.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1688992359;2708e7eb; X-HE-SMSGID: 1qIq45-0006AD-MA Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting for once, to make this easily accessible to everyone. Masami, Arnaldo, what's up here? Georg (who is not a regular contributor) afaics found a regression in a commit you authored/committed and even provided a patch-set to fix it (the first one nearly four weeks ago, e.g. before the merge window started), but hasn't received much support from your side to get this in. Could you please look into this to get this cleared up? Or am I missing something and progress to fix this has been made? Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr If I did something stupid, please tell me, as explained on that page. On 28.06.23 10:45, Georg Müller wrote: > When switching from dwarf_decl_file() to die_get_decl_file(), a regression > was introduced when having a binary where the DWARF info is split to > multiple CUs. It is not possible to add probes to certain functions. > > These patches introduce a testcase which shows the current regression > and a fix for the issue > > Signed-off-by: Georg Müller > Link: https://lore.kernel.org/r/5a00d5a5-7be7-ef8a-4044-9a16249fff25@gmx.net/ > > --- > Changes in v2: > - Add testcase > > Changes in v3: > - start new thread > - add stable to cc > > Georg Müller (2): > perf probe: add test for regression introduced by switch to > die_get_decl_file > perf probe: read DWARF files from the correct CU > > .../shell/test_uprobe_from_different_cu.sh | 77 +++++++++++++++++++ > tools/perf/util/dwarf-aux.c | 4 +- > 2 files changed, 80 insertions(+), 1 deletion(-) > create mode 100755 tools/perf/tests/shell/test_uprobe_from_different_cu.sh > > -- > 2.41.0 > > >