From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD8D2C3A5A6 for ; Fri, 20 Sep 2019 03:17:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C6232196E for ; Fri, 20 Sep 2019 03:17:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="W6sz7fe2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406247AbfITDRd (ORCPT ); Thu, 19 Sep 2019 23:17:33 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:2790 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405721AbfITDRd (ORCPT ); Thu, 19 Sep 2019 23:17:33 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 19 Sep 2019 20:17:38 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 19 Sep 2019 20:17:32 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 19 Sep 2019 20:17:32 -0700 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 20 Sep 2019 03:17:32 +0000 Received: from [10.25.73.234] (10.124.1.5) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 20 Sep 2019 03:17:28 +0000 Subject: Re: [PATCH -next] PCI: tegra: Add missing include file To: YueHaibing , , , , , , CC: , , References: <20190920014807.38288-1-yuehaibing@huawei.com> X-Nvconfidentiality: public From: Vidya Sagar Message-ID: <1c864f34-a2a2-0057-5768-ed992871e927@nvidia.com> Date: Fri, 20 Sep 2019 08:47:25 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20190920014807.38288-1-yuehaibing@huawei.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To DRHQMAIL107.nvidia.com (10.27.9.16) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1568949458; bh=8VvBMAhlupWkjElUkwb5koZLPZoxvhNO2s04Qy7oytM=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=W6sz7fe2uDVN07YAbgnFgJb3HF358KpMHAQbbem2SPN6jA5NUEYJnoW/WHNOmQ4PS 9fyoFu0ALAb+MznhImWLXoxxwnCDSXA4rId7LXJev0UoFIkcmz55Tfo6q7Ygomr2nX V0rEPqBllQuhQp81uijYKDezBK+/9s82+KWYnu3f9eBQP6p8PJQF0PlKjvi5YyJI5i +VP7yoyd1p4JN7aoXIymClSPm4zLSpK60gQq4W6xeuBuTTTCK7kwlGdltCLstkQebI EzHh4x6vdNIJIvpxaEsv9w1dImQJ0sVaqY9fqzE3jwyDR5z0oOPa2qim0zdf+IjgMd UO4SwdagAdu0Q== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/20/2019 7:18 AM, YueHaibing wrote: > Fix build error without CONFIG_PINCTRL > > drivers/pci/controller/dwc/pcie-tegra194.c: In function tegra_pcie_config_rp: > drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function pinctrl_pm_select_default_state; > did you mean prandom_seed_full_state? [-Werror=implicit-function-declaration] > ret = pinctrl_pm_select_default_state(dev); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > prandom_seed_full_state > > Reported-by: Hulk Robot > Fixes: ab2a50e7602b ("PCI: tegra: Add support to configure sideband pins") > Signed-off-by: YueHaibing > --- > drivers/pci/controller/dwc/pcie-tegra194.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c > index 09ed8e4..b219d3b2 100644 > --- a/drivers/pci/controller/dwc/pcie-tegra194.c > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c > @@ -28,6 +28,7 @@ > #include > #include > #include > +#include > #include "pcie-designware.h" > #include > #include > Thanks for pushing this change. Reviewed-by: Vidya Sagar